* [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses
@ 2014-02-26 1:19 Jingoo Han
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Jingoo Han @ 2014-02-26 1:19 UTC (permalink / raw)
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
'Laxman Dewangan'
Remove unnecessary parentheses in order to fix the following
checkpatch error.
ERROR: return is not a function, parentheses are not required
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/regulator/tps80031-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/tps80031-regulator.c b/drivers/regulator/tps80031-regulator.c
index ac88c98..26aa6d9 100644
--- a/drivers/regulator/tps80031-regulator.c
+++ b/drivers/regulator/tps80031-regulator.c
@@ -115,7 +115,7 @@ static int tps80031_reg_is_enabled(struct regulator_dev *rdev)
ri->rinfo->state_reg, ret);
return ret;
}
- return ((reg_val & TPS80031_STATE_MASK) == TPS80031_STATE_ON);
+ return (reg_val & TPS80031_STATE_MASK) == TPS80031_STATE_ON;
}
static int tps80031_reg_enable(struct regulator_dev *rdev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf()
2014-02-26 1:19 [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Jingoo Han
@ 2014-02-26 1:21 ` Jingoo Han
2014-03-19 0:19 ` Jingoo Han
2014-03-19 0:26 ` [PATCH V2] " Jingoo Han
2014-02-26 1:22 ` [PATCH 3/3] regulator: 88pm8607: fix indent code style Jingoo Han
2014-03-05 4:33 ` [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Mark Brown
2 siblings, 2 replies; 9+ messages in thread
From: Jingoo Han @ 2014-02-26 1:21 UTC (permalink / raw)
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
'Bengt Jonsson'
For a constant format without additional arguments, use seq_puts()
instead of seq_printf(). Also, it fixes the following checkpatch
warning.
WARNING: Prefer seq_puts to seq_printf
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/regulator/dbx500-prcmu.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
index f111dfb..3dd1096 100644
--- a/drivers/regulator/dbx500-prcmu.c
+++ b/drivers/regulator/dbx500-prcmu.c
@@ -97,10 +97,10 @@ static int ux500_regulator_power_state_cnt_print(struct seq_file *s, void *p)
int err;
/* print power state count */
- err = seq_printf(s, "ux500-regulator power state count: %i\n",
- power_state_active_get());
+ err = seq_puts(s, "ux500-regulator power state count: %i\n",
+ power_state_active_get());
if (err < 0)
- dev_err(dev, "seq_printf overflow\n");
+ dev_err(dev, "seq_puts overflow\n");
return 0;
}
@@ -127,9 +127,9 @@ static int ux500_regulator_status_print(struct seq_file *s, void *p)
int i;
/* print dump header */
- err = seq_printf(s, "ux500-regulator status:\n");
+ err = seq_puts(s, "ux500-regulator status:\n");
if (err < 0)
- dev_err(dev, "seq_printf overflow\n");
+ dev_err(dev, "seq_puts overflow\n");
err = seq_printf(s, "%31s : %8s : %8s\n", "current",
"before", "after");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] regulator: 88pm8607: fix indent code style
2014-02-26 1:19 [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Jingoo Han
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
@ 2014-02-26 1:22 ` Jingoo Han
2014-02-26 2:10 ` Haojian Zhuang
2014-02-27 4:39 ` Mark Brown
2014-03-05 4:33 ` [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Mark Brown
2 siblings, 2 replies; 9+ messages in thread
From: Jingoo Han @ 2014-02-26 1:22 UTC (permalink / raw)
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Jingoo Han',
'Haojian Zhuang'
Fix indent code style in order to fix the following checkpatch
issues.
ERROR: code indent should use tabs where possible
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/regulator/88pm8607.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
index fa99bfc..337634a 100644
--- a/drivers/regulator/88pm8607.c
+++ b/drivers/regulator/88pm8607.c
@@ -2,7 +2,7 @@
* Regulators driver for Marvell 88PM8607
*
* Copyright (C) 2009 Marvell International Ltd.
- * Haojian Zhuang <haojian.zhuang@marvell.com>
+ * Haojian Zhuang <haojian.zhuang@marvell.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
@@ -78,7 +78,7 @@ static const unsigned int BUCK2_suspend_table[] = {
};
static const unsigned int BUCK3_table[] = {
- 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
+ 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
200000, 225000, 250000, 275000, 300000, 325000, 350000, 375000,
400000, 425000, 450000, 475000, 500000, 525000, 550000, 575000,
600000, 625000, 650000, 675000, 700000, 725000, 750000, 775000,
@@ -89,7 +89,7 @@ static const unsigned int BUCK3_table[] = {
};
static const unsigned int BUCK3_suspend_table[] = {
- 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
+ 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
200000, 225000, 250000, 275000, 300000, 325000, 350000, 375000,
400000, 425000, 450000, 475000, 500000, 525000, 550000, 575000,
600000, 625000, 650000, 675000, 700000, 725000, 750000, 775000,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] regulator: 88pm8607: fix indent code style
2014-02-26 1:22 ` [PATCH 3/3] regulator: 88pm8607: fix indent code style Jingoo Han
@ 2014-02-26 2:10 ` Haojian Zhuang
2014-02-27 4:39 ` Mark Brown
1 sibling, 0 replies; 9+ messages in thread
From: Haojian Zhuang @ 2014-02-26 2:10 UTC (permalink / raw)
To: Jingoo Han; +Cc: Mark Brown, Liam Girdwood, linux-kernel
On Wed, Feb 26, 2014 at 9:22 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> Fix indent code style in order to fix the following checkpatch
> issues.
>
> ERROR: code indent should use tabs where possible
> WARNING: please, no space before tabs
> WARNING: please, no spaces at the start of a line
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/regulator/88pm8607.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/88pm8607.c b/drivers/regulator/88pm8607.c
> index fa99bfc..337634a 100644
> --- a/drivers/regulator/88pm8607.c
> +++ b/drivers/regulator/88pm8607.c
> @@ -2,7 +2,7 @@
> * Regulators driver for Marvell 88PM8607
> *
> * Copyright (C) 2009 Marvell International Ltd.
> - * Haojian Zhuang <haojian.zhuang@marvell.com>
> + * Haojian Zhuang <haojian.zhuang@marvell.com>
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2 as
> @@ -78,7 +78,7 @@ static const unsigned int BUCK2_suspend_table[] = {
> };
>
> static const unsigned int BUCK3_table[] = {
> - 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
> + 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
> 200000, 225000, 250000, 275000, 300000, 325000, 350000, 375000,
> 400000, 425000, 450000, 475000, 500000, 525000, 550000, 575000,
> 600000, 625000, 650000, 675000, 700000, 725000, 750000, 775000,
> @@ -89,7 +89,7 @@ static const unsigned int BUCK3_table[] = {
> };
>
> static const unsigned int BUCK3_suspend_table[] = {
> - 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
> + 0, 25000, 50000, 75000, 100000, 125000, 150000, 175000,
> 200000, 225000, 250000, 275000, 300000, 325000, 350000, 375000,
> 400000, 425000, 450000, 475000, 500000, 525000, 550000, 575000,
> 600000, 625000, 650000, 675000, 700000, 725000, 750000, 775000,
> --
> 1.7.10.4
>
>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Regards
Haojian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] regulator: 88pm8607: fix indent code style
2014-02-26 1:22 ` [PATCH 3/3] regulator: 88pm8607: fix indent code style Jingoo Han
2014-02-26 2:10 ` Haojian Zhuang
@ 2014-02-27 4:39 ` Mark Brown
1 sibling, 0 replies; 9+ messages in thread
From: Mark Brown @ 2014-02-27 4:39 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Liam Girdwood', linux-kernel, 'Haojian Zhuang'
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
On Wed, Feb 26, 2014 at 10:22:05AM +0900, Jingoo Han wrote:
> Fix indent code style in order to fix the following checkpatch
> issues.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses
2014-02-26 1:19 [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Jingoo Han
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
2014-02-26 1:22 ` [PATCH 3/3] regulator: 88pm8607: fix indent code style Jingoo Han
@ 2014-03-05 4:33 ` Mark Brown
2 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2014-03-05 4:33 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Liam Girdwood', linux-kernel, 'Laxman Dewangan'
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Wed, Feb 26, 2014 at 10:19:30AM +0900, Jingoo Han wrote:
> Remove unnecessary parentheses in order to fix the following
> checkpatch error.
>
> ERROR: return is not a function, parentheses are not required
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf()
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
@ 2014-03-19 0:19 ` Jingoo Han
2014-03-19 0:26 ` [PATCH V2] " Jingoo Han
1 sibling, 0 replies; 9+ messages in thread
From: Jingoo Han @ 2014-03-19 0:19 UTC (permalink / raw)
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Bengt Jonsson',
'Jingoo Han', 'Fengguang Wu'
On Wednesday, February 26, 2014 10:21 AM, Jingoo Han wrote:
>
> For a constant format without additional arguments, use seq_puts()
> instead of seq_printf(). Also, it fixes the following checkpatch
> warning.
>
> WARNING: Prefer seq_puts to seq_printf
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/regulator/dbx500-prcmu.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
> index f111dfb..3dd1096 100644
> --- a/drivers/regulator/dbx500-prcmu.c
> +++ b/drivers/regulator/dbx500-prcmu.c
> @@ -97,10 +97,10 @@ static int ux500_regulator_power_state_cnt_print(struct seq_file *s, void *p)
> int err;
>
> /* print power state count */
> - err = seq_printf(s, "ux500-regulator power state count: %i\n",
> - power_state_active_get());
> + err = seq_puts(s, "ux500-regulator power state count: %i\n",
> + power_state_active_get());
It makes build error with 'make ARCH=arm allmodconfig', as
Fengguang Wu reported.
drivers/regulator/dbx500-prcmu.c: In function 'ux500_regulator_power_state_cnt_print':
drivers/regulator/dbx500-prcmu.c:103:4: error: too many arguments to function 'seq_puts'
So, I will send v2 patch. Sorry for annoying you.
Thank you.
Best regards,
Jingoo Han
> if (err < 0)
> - dev_err(dev, "seq_printf overflow\n");
> + dev_err(dev, "seq_puts overflow\n");
>
> return 0;
> }
> @@ -127,9 +127,9 @@ static int ux500_regulator_status_print(struct seq_file *s, void *p)
> int i;
>
> /* print dump header */
> - err = seq_printf(s, "ux500-regulator status:\n");
> + err = seq_puts(s, "ux500-regulator status:\n");
> if (err < 0)
> - dev_err(dev, "seq_printf overflow\n");
> + dev_err(dev, "seq_puts overflow\n");
>
> err = seq_printf(s, "%31s : %8s : %8s\n", "current",
> "before", "after");
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2] regulator: dbx500: use seq_puts() instead of seq_printf()
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
2014-03-19 0:19 ` Jingoo Han
@ 2014-03-19 0:26 ` Jingoo Han
2014-03-19 10:20 ` Mark Brown
1 sibling, 1 reply; 9+ messages in thread
From: Jingoo Han @ 2014-03-19 0:26 UTC (permalink / raw)
To: 'Mark Brown'
Cc: 'Liam Girdwood', linux-kernel, 'Bengt Jonsson',
'Jingoo Han', 'Fengguang Wu'
For a constant format without additional arguments, use seq_puts()
instead of seq_printf(). Also, it fixes the following checkpatch
warning.
WARNING: Prefer seq_puts to seq_printf
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Changes since v1:
- Removed unnecessary seq_puts() in ux500_regulator_power_state_cnt_print()
in order to prevent build error, per Fengguang Wu.
drivers/regulator/dbx500-prcmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
index ce89f78..ac2c1d6 100644
--- a/drivers/regulator/dbx500-prcmu.c
+++ b/drivers/regulator/dbx500-prcmu.c
@@ -127,9 +127,9 @@ static int ux500_regulator_status_print(struct seq_file *s, void *p)
int i;
/* print dump header */
- err = seq_printf(s, "ux500-regulator status:\n");
+ err = seq_puts(s, "ux500-regulator status:\n");
if (err < 0)
- dev_err(dev, "seq_printf overflow\n");
+ dev_err(dev, "seq_puts overflow\n");
err = seq_printf(s, "%31s : %8s : %8s\n", "current",
"before", "after");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V2] regulator: dbx500: use seq_puts() instead of seq_printf()
2014-03-19 0:26 ` [PATCH V2] " Jingoo Han
@ 2014-03-19 10:20 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2014-03-19 10:20 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Liam Girdwood', linux-kernel, 'Bengt Jonsson',
'Fengguang Wu'
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
On Wed, Mar 19, 2014 at 09:26:17AM +0900, Jingoo Han wrote:
> For a constant format without additional arguments, use seq_puts()
> instead of seq_printf(). Also, it fixes the following checkpatch
> warning.
Applied, thanks, but please in future send incremental fixes for
already applied patches.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-03-19 10:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-26 1:19 [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Jingoo Han
2014-02-26 1:21 ` [PATCH 2/3] regulator: dbx500: use seq_puts() instead of seq_printf() Jingoo Han
2014-03-19 0:19 ` Jingoo Han
2014-03-19 0:26 ` [PATCH V2] " Jingoo Han
2014-03-19 10:20 ` Mark Brown
2014-02-26 1:22 ` [PATCH 3/3] regulator: 88pm8607: fix indent code style Jingoo Han
2014-02-26 2:10 ` Haojian Zhuang
2014-02-27 4:39 ` Mark Brown
2014-03-05 4:33 ` [PATCH 1/3] regulator: tps80031: remove unnecessary parentheses Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).