* [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning
@ 2021-04-14 14:46 matthias.bgg
2021-04-14 14:46 ` [PATCH 2/3] arm64: dts: mt8183: " matthias.bgg
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: matthias.bgg @ 2021-04-14 14:46 UTC (permalink / raw)
To: Hsin-Yi Wang, Enric Balletbo i Serra, Nicolas Boichat, Fabien Parent
Cc: linux-mediatek, Matthias Brugger, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
From: Matthias Brugger <matthias.bgg@gmail.com>
Fix unit names to make dtbs_check happy.
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
index eb6e595c2975..0aff5eb52e88 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
@@ -32,7 +32,7 @@ reserved-memory {
#size-cells = <2>;
ranges;
- scp_mem_reserved: scp_mem_region {
+ scp_mem_reserved: scp_mem_region@50000000 {
compatible = "shared-dma-pool";
reg = <0 0x50000000 0 0x2900000>;
no-map;
@@ -55,7 +55,7 @@ led-green {
};
};
- ntc@0 {
+ ntc {
compatible = "murata,ncp03wf104";
pullup-uv = <1800000>;
pullup-ohm = <390000>;
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] arm64: dts: mt8183: fix dtbs_check warning
2021-04-14 14:46 [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning matthias.bgg
@ 2021-04-14 14:46 ` matthias.bgg
2021-04-16 5:53 ` Enric Balletbo Serra
2021-04-14 14:46 ` [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings matthias.bgg
2021-04-16 5:52 ` [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning Enric Balletbo Serra
2 siblings, 1 reply; 8+ messages in thread
From: matthias.bgg @ 2021-04-14 14:46 UTC (permalink / raw)
To: Hsin-Yi Wang, Enric Balletbo i Serra, Nicolas Boichat, Fabien Parent
Cc: linux-mediatek, Matthias Brugger, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
From: Matthias Brugger <matthias.bgg@gmail.com>
Fix unit names to make dtbs_check happy.
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 0ff7b67a6806..c5e822b6b77a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -681,13 +681,13 @@ cpu_thermal: cpu_thermal {
sustainable-power = <5000>;
trips {
- threshold: trip-point@0 {
+ threshold: trip-point0 {
temperature = <68000>;
hysteresis = <2000>;
type = "passive";
};
- target: trip-point@1 {
+ target: trip-point1 {
temperature = <80000>;
hysteresis = <2000>;
type = "passive";
@@ -1103,7 +1103,7 @@ u2port0: usb-phy@0 {
status = "okay";
};
- u3port0: usb-phy@0700 {
+ u3port0: usb-phy@700 {
reg = <0x0700 0x900>;
clocks = <&clk26m>;
clock-names = "ref";
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings
2021-04-14 14:46 [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning matthias.bgg
2021-04-14 14:46 ` [PATCH 2/3] arm64: dts: mt8183: " matthias.bgg
@ 2021-04-14 14:46 ` matthias.bgg
2021-04-15 0:29 ` Nicolas Boichat
2021-04-16 5:52 ` [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning Enric Balletbo Serra
2 siblings, 1 reply; 8+ messages in thread
From: matthias.bgg @ 2021-04-14 14:46 UTC (permalink / raw)
To: Hsin-Yi Wang, Enric Balletbo i Serra, Nicolas Boichat, Fabien Parent
Cc: linux-mediatek, Matthias Brugger, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
From: Matthias Brugger <matthias.bgg@gmail.com>
The dsi children don't have any reg property, so we don't need address and
size cells. This makes dtbs_check happy.
CC: Hsin-Yi Wang <hsinyi@chromium.org>
CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
CC: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..f4dca6a33168 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -251,8 +251,7 @@ &cpu7 {
&dsi0 {
status = "okay";
- #address-cells = <1>;
- #size-cells = <0>;
+
panel: panel@0 {
/* compatible will be set in board dts */
reg = <0>;
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings
2021-04-14 14:46 ` [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings matthias.bgg
@ 2021-04-15 0:29 ` Nicolas Boichat
2021-04-15 7:47 ` Matthias Brugger
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Boichat @ 2021-04-15 0:29 UTC (permalink / raw)
To: matthias.bgg
Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Fabien Parent,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Rob Herring, Devicetree List, linux-arm Mailing List, lkml
On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@kernel.org> wrote:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The dsi children don't have any reg property,
Confused, see below.
> so we don't need address and
> size cells. This makes dtbs_check happy.
>
> CC: Hsin-Yi Wang <hsinyi@chromium.org>
> CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> CC: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..f4dca6a33168 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -251,8 +251,7 @@ &cpu7 {
>
> &dsi0 {
> status = "okay";
> - #address-cells = <1>;
> - #size-cells = <0>;
> +
> panel: panel@0 {
> /* compatible will be set in board dts */
> reg = <0>;
^^ isn't that... a reg property?
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings
2021-04-15 0:29 ` Nicolas Boichat
@ 2021-04-15 7:47 ` Matthias Brugger
2021-04-15 8:37 ` Enric Balletbo i Serra
0 siblings, 1 reply; 8+ messages in thread
From: Matthias Brugger @ 2021-04-15 7:47 UTC (permalink / raw)
To: Nicolas Boichat, matthias.bgg
Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Fabien Parent,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Devicetree List, linux-arm Mailing List, lkml
Hi Nicolas,
On 15/04/2021 02:29, Nicolas Boichat wrote:
> On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@kernel.org> wrote:
>>
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The dsi children don't have any reg property,
>
> Confused, see below.
>
>> so we don't need address and
>> size cells. This makes dtbs_check happy.
>>
>> CC: Hsin-Yi Wang <hsinyi@chromium.org>
>> CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> CC: Nicolas Boichat <drinkcat@chromium.org>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> index ff56bcfa3370..f4dca6a33168 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> @@ -251,8 +251,7 @@ &cpu7 {
>>
>> &dsi0 {
>> status = "okay";
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> +
>> panel: panel@0 {
>> /* compatible will be set in board dts */
>> reg = <0>;
>
> ^^ isn't that... a reg property?
>
Yes, that's my fault. I'm not quite sure why we would need this reg property. In
any case also we have it present "dtbs_check W=1" throws the following warning:
mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
/soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or
child "reg" property
Can you have a look at that?
Regards,
Matthias
>> --
>> 2.30.2
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings
2021-04-15 7:47 ` Matthias Brugger
@ 2021-04-15 8:37 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2021-04-15 8:37 UTC (permalink / raw)
To: Matthias Brugger, Nicolas Boichat, matthias.bgg
Cc: Hsin-Yi Wang, Fabien Parent,
moderated list:ARM/Mediatek SoC support, Rob Herring,
Devicetree List, linux-arm Mailing List, lkml
Hi Matthias,
On 15/4/21 9:47, Matthias Brugger wrote:
> Hi Nicolas,
>
> On 15/04/2021 02:29, Nicolas Boichat wrote:
>> On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@kernel.org> wrote:
>>>
>>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> The dsi children don't have any reg property,
>>
>> Confused, see below.
>>
>>> so we don't need address and
>>> size cells. This makes dtbs_check happy.
>>>
>>> CC: Hsin-Yi Wang <hsinyi@chromium.org>
>>> CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>> CC: Nicolas Boichat <drinkcat@chromium.org>
>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> ---
>>>
>>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> index ff56bcfa3370..f4dca6a33168 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> @@ -251,8 +251,7 @@ &cpu7 {
>>>
>>> &dsi0 {
>>> status = "okay";
>>> - #address-cells = <1>;
>>> - #size-cells = <0>;
>>> +
>>> panel: panel@0 {
>>> /* compatible will be set in board dts */
>>> reg = <0>;
>>
>> ^^ isn't that... a reg property?
>>
>
> Yes, that's my fault. I'm not quite sure why we would need this reg property. In
> any case also we have it present "dtbs_check W=1" throws the following warning:
> mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
> /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or
> child "reg" property
>
>
> Can you have a look at that?
>
I think it is needed reg. See at
Documentation/devicetree/bindings/display/dsi-controller.yaml
Regards,
Enric
> Regards,
> Matthias
>
>>> --
>>> 2.30.2
>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning
2021-04-14 14:46 [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning matthias.bgg
2021-04-14 14:46 ` [PATCH 2/3] arm64: dts: mt8183: " matthias.bgg
2021-04-14 14:46 ` [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings matthias.bgg
@ 2021-04-16 5:52 ` Enric Balletbo Serra
2 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo Serra @ 2021-04-16 5:52 UTC (permalink / raw)
To: matthias.bgg
Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Nicolas Boichat,
Fabien Parent, moderated list:ARM/Mediatek SoC support,
Matthias Brugger, Rob Herring, devicetree, Linux ARM,
linux-kernel
Hi Matthias,
Thank you for your patch.
Missatge de l'adreça <matthias.bgg@kernel.org> del dia dc., 14 d’abr.
2021 a les 16:48:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Fix unit names to make dtbs_check happy.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
> index eb6e595c2975..0aff5eb52e88 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
> @@ -32,7 +32,7 @@ reserved-memory {
> #size-cells = <2>;
> ranges;
>
> - scp_mem_reserved: scp_mem_region {
> + scp_mem_reserved: scp_mem_region@50000000 {
> compatible = "shared-dma-pool";
> reg = <0 0x50000000 0 0x2900000>;
> no-map;
> @@ -55,7 +55,7 @@ led-green {
> };
> };
>
> - ntc@0 {
> + ntc {
> compatible = "murata,ncp03wf104";
> pullup-uv = <1800000>;
> pullup-ohm = <390000>;
> --
> 2.30.2
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] arm64: dts: mt8183: fix dtbs_check warning
2021-04-14 14:46 ` [PATCH 2/3] arm64: dts: mt8183: " matthias.bgg
@ 2021-04-16 5:53 ` Enric Balletbo Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo Serra @ 2021-04-16 5:53 UTC (permalink / raw)
To: matthias.bgg
Cc: Hsin-Yi Wang, Enric Balletbo i Serra, Nicolas Boichat,
Fabien Parent, moderated list:ARM/Mediatek SoC support,
Matthias Brugger, Rob Herring, devicetree, Linux ARM,
linux-kernel
Hi Matthias,
Thank you for your patch.
Missatge de l'adreça <matthias.bgg@kernel.org> del dia dc., 14 d’abr.
2021 a les 16:48:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Fix unit names to make dtbs_check happy.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 0ff7b67a6806..c5e822b6b77a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -681,13 +681,13 @@ cpu_thermal: cpu_thermal {
> sustainable-power = <5000>;
>
> trips {
> - threshold: trip-point@0 {
> + threshold: trip-point0 {
> temperature = <68000>;
> hysteresis = <2000>;
> type = "passive";
> };
>
> - target: trip-point@1 {
> + target: trip-point1 {
> temperature = <80000>;
> hysteresis = <2000>;
> type = "passive";
> @@ -1103,7 +1103,7 @@ u2port0: usb-phy@0 {
> status = "okay";
> };
>
> - u3port0: usb-phy@0700 {
> + u3port0: usb-phy@700 {
> reg = <0x0700 0x900>;
> clocks = <&clk26m>;
> clock-names = "ref";
> --
> 2.30.2
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-16 5:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 14:46 [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning matthias.bgg
2021-04-14 14:46 ` [PATCH 2/3] arm64: dts: mt8183: " matthias.bgg
2021-04-16 5:53 ` Enric Balletbo Serra
2021-04-14 14:46 ` [PATCH 3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings matthias.bgg
2021-04-15 0:29 ` Nicolas Boichat
2021-04-15 7:47 ` Matthias Brugger
2021-04-15 8:37 ` Enric Balletbo i Serra
2021-04-16 5:52 ` [PATCH 1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning Enric Balletbo Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).