* [PATCH] lightnvm: pblk: fix chunk close trace event check
@ 2018-10-26 8:12 Hans Holmberg
2018-10-26 18:49 ` Matias Bjørling
0 siblings, 1 reply; 4+ messages in thread
From: Hans Holmberg @ 2018-10-26 8:12 UTC (permalink / raw)
To: Matias Bjorling; +Cc: linux-block, Javier Gonzales, linux-kernel, Hans Holmberg
The check for chunk closes suffers from an off-by-one issue, leading
to chunk close events not being traced. Fix this.
Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
---
drivers/lightnvm/pblk-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 6944aac43b01..6581c35f51ee 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd)
if (caddr == 0)
trace_pblk_chunk_state(pblk_disk_name(pblk),
ppa, NVM_CHK_ST_OPEN);
- else if (caddr == chunk->cnlb)
+ else if (caddr == (chunk->cnlb - 1))
trace_pblk_chunk_state(pblk_disk_name(pblk),
ppa, NVM_CHK_ST_CLOSED);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lightnvm: pblk: fix chunk close trace event check
2018-10-26 8:12 [PATCH] lightnvm: pblk: fix chunk close trace event check Hans Holmberg
@ 2018-10-26 18:49 ` Matias Bjørling
2018-10-29 9:56 ` Hans Holmberg
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjørling @ 2018-10-26 18:49 UTC (permalink / raw)
To: hans; +Cc: linux-block, javier, linux-kernel, hans.holmberg
On 10/26/2018 10:12 AM, Hans Holmberg wrote:
> The check for chunk closes suffers from an off-by-one issue, leading
> to chunk close events not being traced. Fix this.
>
> Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
>
> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
> ---
>
> drivers/lightnvm/pblk-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 6944aac43b01..6581c35f51ee 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd)
> if (caddr == 0)
> trace_pblk_chunk_state(pblk_disk_name(pblk),
> ppa, NVM_CHK_ST_OPEN);
> - else if (caddr == chunk->cnlb)
> + else if (caddr == (chunk->cnlb - 1))
> trace_pblk_chunk_state(pblk_disk_name(pblk),
> ppa, NVM_CHK_ST_CLOSED);
> }
>
Thanks Hans, Applied for 4.21/5.1. Note that you're sending from your
owntronix email account. Checkpatch complains that sender and author
doesn't match.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lightnvm: pblk: fix chunk close trace event check
2018-10-26 18:49 ` Matias Bjørling
@ 2018-10-29 9:56 ` Hans Holmberg
2018-10-29 11:14 ` Matias Bjørling
0 siblings, 1 reply; 4+ messages in thread
From: Hans Holmberg @ 2018-10-29 9:56 UTC (permalink / raw)
To: Matias Bjorling
Cc: linux-block, Javier Gonzalez, Linux Kernel Mailing List, Hans Holmberg
On Fri, Oct 26, 2018 at 8:49 PM Matias Bjørling <mb@lightnvm.io> wrote:
>
> On 10/26/2018 10:12 AM, Hans Holmberg wrote:
> > The check for chunk closes suffers from an off-by-one issue, leading
> > to chunk close events not being traced. Fix this.
> >
> > Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
> >
> > Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
> > ---
> >
> > drivers/lightnvm/pblk-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> > index 6944aac43b01..6581c35f51ee 100644
> > --- a/drivers/lightnvm/pblk-core.c
> > +++ b/drivers/lightnvm/pblk-core.c
> > @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd)
> > if (caddr == 0)
> > trace_pblk_chunk_state(pblk_disk_name(pblk),
> > ppa, NVM_CHK_ST_OPEN);
> > - else if (caddr == chunk->cnlb)
> > + else if (caddr == (chunk->cnlb - 1))
> > trace_pblk_chunk_state(pblk_disk_name(pblk),
> > ppa, NVM_CHK_ST_CLOSED);
> > }
> >
>
> Thanks Hans, Applied for 4.21/5.1. Note that you're sending from your
> owntronix email account. Checkpatch complains that sender and author
> doesn't match.
Ah, I must have messed up my git configuration.
Would you mind updating the patch author to "Hans Holmberg
<hans.holmberg@cnexlabs.com>" in for-4.21/core?
Thanks,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lightnvm: pblk: fix chunk close trace event check
2018-10-29 9:56 ` Hans Holmberg
@ 2018-10-29 11:14 ` Matias Bjørling
0 siblings, 0 replies; 4+ messages in thread
From: Matias Bjørling @ 2018-10-29 11:14 UTC (permalink / raw)
To: hans; +Cc: linux-block, javier, linux-kernel, hans.holmberg
On 10/29/2018 10:56 AM, Hans Holmberg wrote:
> On Fri, Oct 26, 2018 at 8:49 PM Matias Bjørling <mb@lightnvm.io> wrote:
>>
>> On 10/26/2018 10:12 AM, Hans Holmberg wrote:
>>> The check for chunk closes suffers from an off-by-one issue, leading
>>> to chunk close events not being traced. Fix this.
>>>
>>> Fixes: 4c44abf43d00 ("lightnvm: pblk: add trace events for chunk states")
>>>
>>> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
>>> ---
>>>
>>> drivers/lightnvm/pblk-core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>>> index 6944aac43b01..6581c35f51ee 100644
>>> --- a/drivers/lightnvm/pblk-core.c
>>> +++ b/drivers/lightnvm/pblk-core.c
>>> @@ -531,7 +531,7 @@ void pblk_check_chunk_state_update(struct pblk *pblk, struct nvm_rq *rqd)
>>> if (caddr == 0)
>>> trace_pblk_chunk_state(pblk_disk_name(pblk),
>>> ppa, NVM_CHK_ST_OPEN);
>>> - else if (caddr == chunk->cnlb)
>>> + else if (caddr == (chunk->cnlb - 1))
>>> trace_pblk_chunk_state(pblk_disk_name(pblk),
>>> ppa, NVM_CHK_ST_CLOSED);
>>> }
>>>
>>
>> Thanks Hans, Applied for 4.21/5.1. Note that you're sending from your
>> owntronix email account. Checkpatch complains that sender and author
>> doesn't match.
>
> Ah, I must have messed up my git configuration.
> Would you mind updating the patch author to "Hans Holmberg
> <hans.holmberg@cnexlabs.com>" in for-4.21/core?
>
> Thanks,
> Hans
>
Will do. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-29 11:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 8:12 [PATCH] lightnvm: pblk: fix chunk close trace event check Hans Holmberg
2018-10-26 18:49 ` Matias Bjørling
2018-10-29 9:56 ` Hans Holmberg
2018-10-29 11:14 ` Matias Bjørling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).