From: Alan Cooper <alcooperx@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: ": Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Alban Bedel <albeu@free.fr>, Alex Elder <elder@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Avi Fishman <avifishman70@gmail.com>,
bcm-kernel-feedback-list@broadcom.com,
Bjorn Andersson <bjorn.andersson@linaro.org>,
chunfeng yun <chunfeng.yun@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
DTML <devicetree@vger.kernel.org>,
Dmitry Osipenko <digetx@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Hans de Goede <hdegoede@redhat.com>,
James Hogan <jhogan@kernel.org>,
Jianguo Sun <sunjianguo1@huawei.com>,
Johan Hovold <johan@kernel.org>,
Kees Cook <keescook@chromium.org>,
USB list <linux-usb@vger.kernel.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Rishabh Bhatnagar <rishabhb@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers
Date: Tue, 6 Nov 2018 10:55:31 -0500 [thread overview]
Message-ID: <CAOGqxeX1FckLz7XEm-doh_AHUjvRtn00yZfir6dRNMYNOMY5_g@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0AoHuaiPsMTqhWm3a4X95NpPTPUHkt9vS9Z2ow8NobhA@mail.gmail.com>
On Tue, Nov 6, 2018 at 6:09 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On 11/5/18, Al Cooper <alcooperx@gmail.com> wrote:
>
> > +
> > +config USB_BRCM
> > + tristate "Broadcom STB USB support"
> > + depends on ARCH_BRCMSTB
> > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> > + select USB_EHCI_BRCM if USB_EHCI_HCD
> > + select USB_XHCI_BRCM if USB_XHCI_HCD
> > + select USB_XHCI_PLATFORM if USB_XHCI_HCD
> > + select BRCM_USB_PHY if USB_OHCI_HCD || USB_EHCI_HCD || USB_XHCI_HCD
> > + select GENERIC_PHY if BRCM_USB_PHY
> > + default ARCH_BRCMSTB
>
> Is there a build time dependency on the PHY layer? If not, I would suggest
> dropping the last two 'select' statements. I would also suggest
> making the dependency 'depends on ARCH_BRCMSTB || COMPILE_TEST'
> to allow building it on other architecture for better build testing, and
> dropping the 'default' line. Just add this to the defconfig like the other
> drivers you have.
I added COMPILE_TEST and dropped the last 2 select lines.
Most of our other drivers default to "y" for "ARCH_BRCMSTB", would it
be better if I changed it to "default y"?
Thanks
Al
>
> Arnd
next prev parent reply other threads:[~2018-11-06 15:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 21:31 [PATCH V3 0/6] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Al Cooper
2018-11-05 21:31 ` [PATCH V3 1/6] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document Al Cooper
2018-11-05 21:31 ` [PATCH V3 2/6] usb: core: Add ability to skip phy exit on suspend and init on resume Al Cooper
2018-11-05 21:31 ` [PATCH V3 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Al Cooper
2018-11-05 21:31 ` [PATCH V3 4/6] usb: ohci-platform: " Al Cooper
2018-11-06 16:08 ` Alan Stern
2018-11-06 21:40 ` Al Cooper
2018-11-06 23:44 ` Florian Fainelli
2018-11-07 15:23 ` Alan Stern
2018-11-07 15:58 ` Al Cooper
2018-11-07 16:27 ` Alan Stern
2018-11-07 17:29 ` Florian Fainelli
2018-11-07 17:40 ` Al Cooper
2018-11-07 18:11 ` Florian Fainelli
[not found] ` <20181112174532.GA14682@bogus>
2018-11-13 21:54 ` Alan Cooper
2018-11-05 21:31 ` [PATCH V3 5/6] usb: ehci: Add new EHCI driver " Al Cooper
2018-11-05 21:31 ` [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers Al Cooper
2018-11-06 11:09 ` Arnd Bergmann
2018-11-06 15:55 ` Alan Cooper [this message]
2018-11-06 18:22 ` Arnd Bergmann
2018-11-06 19:33 ` Alan Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOGqxeX1FckLz7XEm-doh_AHUjvRtn00yZfir6dRNMYNOMY5_g@mail.gmail.com \
--to=alcooperx@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=albeu@free.fr \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=elder@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=hdegoede@redhat.com \
--cc=jhogan@kernel.org \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mchehab+samsung@kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=sunjianguo1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).