From: Alan Stern <stern@rowland.harvard.edu>
To: Al Cooper <al.cooper@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Al Cooper <alcooperx@gmail.com>, <linux-kernel@vger.kernel.org>,
Alban Bedel <albeu@free.fr>, Alex Elder <elder@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Avi Fishman <avifishman70@gmail.com>,
<bcm-kernel-feedback-list@broadcom.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
"David S. Miller" <davem@davemloft.net>,
<devicetree@vger.kernel.org>, Dmitry Osipenko <digetx@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Hans de Goede <hdegoede@redhat.com>,
James Hogan <jhogan@kernel.org>,
Jianguo Sun <sunjianguo1@huawei.com>,
Johan Hovold <johan@kernel.org>,
Kees Cook <keescook@chromium.org>, <linux-usb@vger.kernel.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Rishabh Bhatnagar <rishabhb@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's
Date: Wed, 7 Nov 2018 11:27:26 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1811071124260.1542-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <e4f2a868-c265-58c8-7b7b-91de91f2cf0b@broadcom.com>
On Wed, 7 Nov 2018, Al Cooper wrote:
> On 11/7/18 10:23 AM, Alan Stern wrote:
> > On Tue, 6 Nov 2018, Florian Fainelli wrote:
> >
> >> On 11/6/18 1:40 PM, Al Cooper wrote:
> >>> On 11/6/18 11:08 AM, Alan Stern wrote:
> >>>> On Mon, 5 Nov 2018, Al Cooper wrote:
> >>>>
> >>>>> Add support for Broadcom STB SoC's to the ohci platform driver.
> >>>>>
> >>>>> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> >>>>> ---
> >>>>
> >>>>> @@ -177,6 +189,8 @@ static int ohci_platform_probe(struct
> >>>>> platform_device *dev)
> >>>>> ohci->flags |= OHCI_QUIRK_FRAME_NO;
> >>>>> if (pdata->num_ports)
> >>>>> ohci->num_ports = pdata->num_ports;
> >>>>> + if (pdata->suspend_without_phy_exit)
> >>>>> + hcd->suspend_without_phy_exit = 1;
> >>>>
> >>>> Sorry if I missed this in the earlier discussions... Is there any
> >>>> possibility of adding a DT binding that could express this requirement,
> >>>> instead of putting it in the platform data?
> >>>>
> >>>> Alan Stern
> >>>>
> >>>
> >>> Alan,
> >>>
> >>> That was my original approach but internal review suggested that I use
> >>> pdata instead. Below is my original patch for:
> >>
> >> And the reason for that suggestion was really because it was percevied
> >> as encoding a driver behavior as a Device Tree property as opposed to
> >> describing something that was inherently and strictly a hardware
> >> behavior (therefore suitable for Device Tree).
> >
> > Right. The best way to approach this problem is to identify and
> > characterize the hardware behavior which makes this override necessary.
> > Then _that_ can be added to DT, since it will be a property of the
> > hardware rather than of the driver.
> >
> >>> Add the ability to skip calling the PHY's exit routine on suspend
> >>> and the PHY's init routine on resume. This is to handle a USB PHY
> >>> that should have it's power_off function called on suspend but cannot
> >>> have it's exit function called because on exit it will disable the
> >>> PHY to the point where register accesses to the Host Controllers
> >>> using the PHY will be disabled and the host drivers will crash.
> >
> > What's special about this PHY? Why does the exit function mess the PHY
> > up? Or to put it another way, why doesn't the exit function mess up
> > other PHYs in the same way?
> >
> > For that matter, can we change the code so that suspend doesn't call
> > the exit function for _any_ PHY? Will just calling the power_off
> > function be good enough? If not, then why not?
> >
> > Alan Stern
> >
>
> In our USB hardware the USB PHY supplies a clock for the EHCI/OHCI and
> XHCI host controllers and if the PHY is totally shut down the EHCI, OHCI
> and XHCI registers will cause an exception if accessed and cause the
> EHCI, OHCI and XHCI drivers to crash. There is always talk of fixing
> this in the hardware by adding an aux clock that will takeover when the
> PHY clock is shut down, but this hasn't happened yet. It seems like
> "exit on suspend" still makes sense on systems that don't have this
> problem (additional power savings?) so removing the exit on suspend for
> all systems is not a good idea.
Then in theory you should be able to add a Device Tree property which
says that the PHY provides a clock for the USB host controller. That
is strictly a property of the hardware; it has nothing to do with the
driver. Therefore it is appropriate for DT.
Wouldn't this solve your issue?
Alan Stern
next prev parent reply other threads:[~2018-11-07 16:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 21:31 [PATCH V3 0/6] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Al Cooper
2018-11-05 21:31 ` [PATCH V3 1/6] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document Al Cooper
2018-11-05 21:31 ` [PATCH V3 2/6] usb: core: Add ability to skip phy exit on suspend and init on resume Al Cooper
2018-11-05 21:31 ` [PATCH V3 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Al Cooper
2018-11-05 21:31 ` [PATCH V3 4/6] usb: ohci-platform: " Al Cooper
2018-11-06 16:08 ` Alan Stern
2018-11-06 21:40 ` Al Cooper
2018-11-06 23:44 ` Florian Fainelli
2018-11-07 15:23 ` Alan Stern
2018-11-07 15:58 ` Al Cooper
2018-11-07 16:27 ` Alan Stern [this message]
2018-11-07 17:29 ` Florian Fainelli
2018-11-07 17:40 ` Al Cooper
2018-11-07 18:11 ` Florian Fainelli
[not found] ` <20181112174532.GA14682@bogus>
2018-11-13 21:54 ` Alan Cooper
2018-11-05 21:31 ` [PATCH V3 5/6] usb: ehci: Add new EHCI driver " Al Cooper
2018-11-05 21:31 ` [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers Al Cooper
2018-11-06 11:09 ` Arnd Bergmann
2018-11-06 15:55 ` Alan Cooper
2018-11-06 18:22 ` Arnd Bergmann
2018-11-06 19:33 ` Alan Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1811071124260.1542-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=akpm@linux-foundation.org \
--cc=al.cooper@broadcom.com \
--cc=albeu@free.fr \
--cc=alcooperx@gmail.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=chunfeng.yun@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=elder@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=hdegoede@redhat.com \
--cc=jhogan@kernel.org \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mchehab+samsung@kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sunjianguo1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).