linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
@ 2020-03-04 16:47 Tony Fischetti
  2020-03-10 11:53 ` Jiri Kosina
  2020-03-10 13:48 ` Filipe Laíns
  0 siblings, 2 replies; 6+ messages in thread
From: Tony Fischetti @ 2020-03-04 16:47 UTC (permalink / raw)
  To: jikos, benjamin.tissoires; +Cc: linux-input, linux-kernel, tony.fischetti

A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
where it disconnects and reconnects every minute--each time incrementing
the device number. This patch adds the device id of the device and
specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
work properly.
---
 drivers/hid/hid-ids.h    | 1 +
 drivers/hid/hid-quirks.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 3a400ce603c4..9e1dfc714ea8 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -726,6 +726,7 @@
 #define USB_DEVICE_ID_LENOVO_X1_COVER	0x6085
 #define USB_DEVICE_ID_LENOVO_X1_TAB	0x60a3
 #define USB_DEVICE_ID_LENOVO_X1_TAB3	0x60b5
+#define USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE	0x608d
 
 #define USB_VENDOR_ID_LG		0x1fd2
 #define USB_DEVICE_ID_LG_MULTITOUCH	0x0064
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index 0e7b2d998395..247747d6d8cf 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -103,6 +103,7 @@ static const struct hid_device_id hid_quirks[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_PENSKETCH_M912), HID_QUIRK_MULTI_INPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M406XE), HID_QUIRK_MULTI_INPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2), HID_QUIRK_ALWAYS_POLL },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C007), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077), HID_QUIRK_ALWAYS_POLL },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_KEYBOARD_G710_PLUS), HID_QUIRK_NOGET },
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
  2020-03-04 16:47 [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse Tony Fischetti
@ 2020-03-10 11:53 ` Jiri Kosina
  2020-03-10 13:48 ` Filipe Laíns
  1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2020-03-10 11:53 UTC (permalink / raw)
  To: Tony Fischetti; +Cc: benjamin.tissoires, linux-input, linux-kernel

On Wed, 4 Mar 2020, Tony Fischetti wrote:

> A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
> where it disconnects and reconnects every minute--each time incrementing
> the device number. This patch adds the device id of the device and
> specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
> work properly.

You are missing Signed-off-by: line here (please see 
Documentation/process/5.Posting.rst and 
Documentation/process/submitting-patches.rst to read what this is about).

Also, we generally prefix all the patches to HID susbsytem with 'HID: ' in 
the subject / shortlog, so as you'll be resending with signoff, could you 
please fix that up at the same time as well?

Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
  2020-03-04 16:47 [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse Tony Fischetti
  2020-03-10 11:53 ` Jiri Kosina
@ 2020-03-10 13:48 ` Filipe Laíns
  2020-03-12 15:22   ` Tony Fischetti
  1 sibling, 1 reply; 6+ messages in thread
From: Filipe Laíns @ 2020-03-10 13:48 UTC (permalink / raw)
  To: Tony Fischetti, jikos, benjamin.tissoires; +Cc: linux-input, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2191 bytes --]

On Wed, 2020-03-04 at 11:47 -0500, Tony Fischetti wrote:
> A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
> where it disconnects and reconnects every minute--each time incrementing
> the device number. This patch adds the device id of the device and
> specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
> work properly.
> ---
>  drivers/hid/hid-ids.h    | 1 +
>  drivers/hid/hid-quirks.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 3a400ce603c4..9e1dfc714ea8 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -726,6 +726,7 @@
>  #define USB_DEVICE_ID_LENOVO_X1_COVER	0x6085
>  #define USB_DEVICE_ID_LENOVO_X1_TAB	0x60a3
>  #define USB_DEVICE_ID_LENOVO_X1_TAB3	0x60b5
> +#define USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE	0x608d

This ID is really ambiguous. Pixart makes the sensors for the big
majority of devices. Isn't there any other identifier you could use? If
there isn't, you could do USB_DEVICE_ID_LENOVO_MOUSE_608D.

>  #define USB_VENDOR_ID_LG		0x1fd2
>  #define USB_DEVICE_ID_LG_MULTITOUCH	0x0064
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index 0e7b2d998395..247747d6d8cf 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -103,6 +103,7 @@ static const struct hid_device_id hid_quirks[] = {
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_PENSKETCH_M912), HID_QUIRK_MULTI_INPUT },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M406XE), HID_QUIRK_MULTI_INPUT },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2), HID_QUIRK_ALWAYS_POLL },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE), HID_QUIRK_ALWAYS_POLL },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C007), HID_QUIRK_ALWAYS_POLL },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077), HID_QUIRK_ALWAYS_POLL },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_KEYBOARD_G710_PLUS), HID_QUIRK_NOGET },

-- 
Filipe Laíns

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
  2020-03-10 13:48 ` Filipe Laíns
@ 2020-03-12 15:22   ` Tony Fischetti
  2020-03-13 11:23     ` Jiri Kosina
  0 siblings, 1 reply; 6+ messages in thread
From: Tony Fischetti @ 2020-03-12 15:22 UTC (permalink / raw)
  To: Filipe Laíns; +Cc: jikos, benjamin.tissoires, linux-input, linux-kernel

Thanks for the feedback, y'all.
I will rename the device and add the signed-off field and resubmit.
Thanks again

On Tue, Mar 10, 2020 at 9:48 AM Filipe Laíns <lains@archlinux.org> wrote:
>
> On Wed, 2020-03-04 at 11:47 -0500, Tony Fischetti wrote:
> > A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction
> > where it disconnects and reconnects every minute--each time incrementing
> > the device number. This patch adds the device id of the device and
> > specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to
> > work properly.
> > ---
> >  drivers/hid/hid-ids.h    | 1 +
> >  drivers/hid/hid-quirks.c | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> > index 3a400ce603c4..9e1dfc714ea8 100644
> > --- a/drivers/hid/hid-ids.h
> > +++ b/drivers/hid/hid-ids.h
> > @@ -726,6 +726,7 @@
> >  #define USB_DEVICE_ID_LENOVO_X1_COVER        0x6085
> >  #define USB_DEVICE_ID_LENOVO_X1_TAB  0x60a3
> >  #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
> > +#define USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE        0x608d
>
> This ID is really ambiguous. Pixart makes the sensors for the big
> majority of devices. Isn't there any other identifier you could use? If
> there isn't, you could do USB_DEVICE_ID_LENOVO_MOUSE_608D.
>
> >  #define USB_VENDOR_ID_LG             0x1fd2
> >  #define USB_DEVICE_ID_LG_MULTITOUCH  0x0064
> > diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> > index 0e7b2d998395..247747d6d8cf 100644
> > --- a/drivers/hid/hid-quirks.c
> > +++ b/drivers/hid/hid-quirks.c
> > @@ -103,6 +103,7 @@ static const struct hid_device_id hid_quirks[] = {
> >       { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_PENSKETCH_M912), HID_QUIRK_MULTI_INPUT },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M406XE), HID_QUIRK_MULTI_INPUT },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2), HID_QUIRK_ALWAYS_POLL },
> > +     { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_PIXART_USB_OPTICAL_MOUSE), HID_QUIRK_ALWAYS_POLL },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C007), HID_QUIRK_ALWAYS_POLL },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077), HID_QUIRK_ALWAYS_POLL },
> >       { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_KEYBOARD_G710_PLUS), HID_QUIRK_NOGET },
>
> --
> Filipe Laíns



-- 
--
Tony Fischetti
tony.fischetti@gmail.com
(718) 431-4597

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
  2020-03-12 15:22   ` Tony Fischetti
@ 2020-03-13 11:23     ` Jiri Kosina
  2020-03-15  1:07       ` Tony Fischetti
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2020-03-13 11:23 UTC (permalink / raw)
  To: Tony Fischetti
  Cc: Filipe Laíns, benjamin.tissoires, linux-input, linux-kernel

On Thu, 12 Mar 2020, Tony Fischetti wrote:

> Thanks for the feedback, y'all.
> I will rename the device and add the signed-off field and resubmit.
> Thanks again

Please do it as a followup patch on top of your previous one, as I've 
already pushed that one out and we are generally not rebasing live 
branches in hid.git.

Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse
  2020-03-13 11:23     ` Jiri Kosina
@ 2020-03-15  1:07       ` Tony Fischetti
  0 siblings, 0 replies; 6+ messages in thread
From: Tony Fischetti @ 2020-03-15  1:07 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Filipe Laíns, benjamin.tissoires, linux-input, linux-kernel

Before I got your email, I sent the patch again, separately.
I'm terribly sorry but I'm new to kernel development—how do I send it
instead as a followup patch? Do you mean just responding to this
thread with the new patch?

On Fri, Mar 13, 2020 at 7:23 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Thu, 12 Mar 2020, Tony Fischetti wrote:
>
> > Thanks for the feedback, y'all.
> > I will rename the device and add the signed-off field and resubmit.
> > Thanks again
>
> Please do it as a followup patch on top of your previous one, as I've
> already pushed that one out and we are generally not rebasing live
> branches in hid.git.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>


-- 
--
Tony Fischetti
tony.fischetti@gmail.com
(718) 431-4597

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-15  1:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 16:47 [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse Tony Fischetti
2020-03-10 11:53 ` Jiri Kosina
2020-03-10 13:48 ` Filipe Laíns
2020-03-12 15:22   ` Tony Fischetti
2020-03-13 11:23     ` Jiri Kosina
2020-03-15  1:07       ` Tony Fischetti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).