* [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config @ 2023-05-23 21:28 Otavio Salvador 2023-05-23 21:54 ` Fabio Estevam 2023-05-24 6:48 ` Arnd Bergmann 0 siblings, 2 replies; 6+ messages in thread From: Otavio Salvador @ 2023-05-23 21:28 UTC (permalink / raw) To: shawnguo Cc: linux-arm-kernel, Otavio Salvador, Alistair Francis, Arnd Bergmann, Fabio Estevam, Kirill A. Shutemov, Marcel Ziswiler, Mark Brown, Michael Ellerman, NXP Linux Team, Pengutronix Kernel Team, Russell King, Sascha Hauer, Stefan Hansson, Stefan Wahren, linux-kernel The KERNEL_GZIP is used in most config and is the default, there is no clear reason to diverge so let default be used. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> --- arch/arm/configs/imx_v6_v7_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig index 4de293da4789a..1f3102eeb7dfe 100644 --- a/arch/arm/configs/imx_v6_v7_defconfig +++ b/arch/arm/configs/imx_v6_v7_defconfig @@ -1,4 +1,3 @@ -CONFIG_KERNEL_LZO=y CONFIG_SYSVIPC=y CONFIG_NO_HZ_IDLE=y CONFIG_HIGH_RES_TIMERS=y -- 2.40.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config 2023-05-23 21:28 [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config Otavio Salvador @ 2023-05-23 21:54 ` Fabio Estevam 2023-05-24 6:48 ` Arnd Bergmann 1 sibling, 0 replies; 6+ messages in thread From: Fabio Estevam @ 2023-05-23 21:54 UTC (permalink / raw) To: Otavio Salvador Cc: shawnguo, linux-arm-kernel, Alistair Francis, Arnd Bergmann, Kirill A. Shutemov, Marcel Ziswiler, Mark Brown, Michael Ellerman, NXP Linux Team, Pengutronix Kernel Team, Russell King, Sascha Hauer, Stefan Hansson, Stefan Wahren, linux-kernel Hi Otavio, On Tue, May 23, 2023 at 6:28 PM Otavio Salvador <otavio@ossystems.com.br> wrote: > > The KERNEL_GZIP is used in most config and is the default, there is no > clear reason to diverge so let default be used. > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> CONFIG_KERNEL_LZO=y was introduced in 2011 by the following commit below: 06965c39b4c6 ("ARM i.MX5: update defconfig") imx_v6_v7_defconfig and sdk7786_defconfig are the only defconfigs that select CONFIG_KERNEL_LZO=y, so it seems fine to remove it: Reviewed-by: Fabio Estevam <festevam@gmail.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config 2023-05-23 21:28 [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config Otavio Salvador 2023-05-23 21:54 ` Fabio Estevam @ 2023-05-24 6:48 ` Arnd Bergmann 2023-05-24 10:47 ` Francesco Dolcini 2023-05-27 12:44 ` Shawn Guo 1 sibling, 2 replies; 6+ messages in thread From: Arnd Bergmann @ 2023-05-24 6:48 UTC (permalink / raw) To: Otavio Salvador, Shawn Guo Cc: linux-arm-kernel, Alistair Francis, Fabio Estevam, Kirill A. Shutemov, Marcel Ziswiler, Mark Brown, Michael Ellerman, NXP Linux Team, Pengutronix Kernel Team, Russell King, Sascha Hauer, Stefan Hansson, Stefan Wahren, linux-kernel On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote: > The KERNEL_GZIP is used in most config and is the default, there is no > clear reason to diverge so let default be used. > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> I don't mind that change, but it seems odd to single this one out, as there are many other options in that particular defconfig that stick out more, picking LZO seems like a reasonable choice for slightly faster booting, though ZSTD would be the more modern choice. If you are looking into cleaning up this file, maybe see if we can kill off these options: CONFIG_EXPERT=y CONFIG_ARCH_FORCE_MAX_ORDER=13 CONFIG_CMDLINE="noinitrd console=ttymxc0,115200" CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files CONFIG_SMC91X=y CONFIG_SMC911X=y CONFIG_SMSC911X=y CONFIG_STAGING=y CONFIG_STAGING_MEDIA=y CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years CONFIG_EXT2_FS=y CONFIG_EXT3_FS=y # select EXT4 instead CONFIG_ISO9660_FS=m I have not investigated why any of them were added originally, so it's likely that some are actually needed. Arnd ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config 2023-05-24 6:48 ` Arnd Bergmann @ 2023-05-24 10:47 ` Francesco Dolcini 2023-05-27 12:44 ` Shawn Guo 1 sibling, 0 replies; 6+ messages in thread From: Francesco Dolcini @ 2023-05-24 10:47 UTC (permalink / raw) To: Arnd Bergmann Cc: Otavio Salvador, Shawn Guo, linux-arm-kernel, Alistair Francis, Fabio Estevam, Kirill A. Shutemov, Marcel Ziswiler, Mark Brown, Michael Ellerman, NXP Linux Team, Pengutronix Kernel Team, Russell King, Sascha Hauer, Stefan Hansson, Stefan Wahren, linux-kernel On Wed, May 24, 2023 at 08:48:26AM +0200, Arnd Bergmann wrote: > On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote: > > The KERNEL_GZIP is used in most config and is the default, there is no > > clear reason to diverge so let default be used. > > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > > If you are looking into cleaning up this file, maybe see if we can > kill off these options: > > CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years This would be a bad idea from my point of view, this is regularly used despite the fact that it is in staging. Of course, I agree on the graduating thingy ... Francesco ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config 2023-05-24 6:48 ` Arnd Bergmann 2023-05-24 10:47 ` Francesco Dolcini @ 2023-05-27 12:44 ` Shawn Guo 2023-05-27 13:29 ` Otavio Salvador 1 sibling, 1 reply; 6+ messages in thread From: Shawn Guo @ 2023-05-27 12:44 UTC (permalink / raw) To: Arnd Bergmann Cc: Otavio Salvador, linux-arm-kernel, Alistair Francis, Fabio Estevam, Kirill A. Shutemov, Marcel Ziswiler, Mark Brown, Michael Ellerman, NXP Linux Team, Pengutronix Kernel Team, Russell King, Sascha Hauer, Stefan Hansson, Stefan Wahren, linux-kernel On Wed, May 24, 2023 at 08:48:26AM +0200, Arnd Bergmann wrote: > On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote: > > The KERNEL_GZIP is used in most config and is the default, there is no > > clear reason to diverge so let default be used. > > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > > I don't mind that change, but it seems odd to single this one out, as > there are many other options in that particular defconfig that > stick out more, picking LZO seems like a reasonable choice for slightly > faster booting, though ZSTD would be the more modern choice. > > If you are looking into cleaning up this file, maybe see if we can > kill off these options: > > CONFIG_EXPERT=y > CONFIG_ARCH_FORCE_MAX_ORDER=13 > CONFIG_CMDLINE="noinitrd console=ttymxc0,115200" > CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files > CONFIG_SMC91X=y > CONFIG_SMC911X=y > CONFIG_SMSC911X=y > CONFIG_STAGING=y > CONFIG_STAGING_MEDIA=y > CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years > CONFIG_EXT2_FS=y > CONFIG_EXT3_FS=y # select EXT4 instead > CONFIG_ISO9660_FS=m > > I have not investigated why any of them were added originally, > so it's likely that some are actually needed. Otavio, Would you investigate the suggested options and see if we can clean up more than just KERNEL_LZO? Shawn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config 2023-05-27 12:44 ` Shawn Guo @ 2023-05-27 13:29 ` Otavio Salvador 0 siblings, 0 replies; 6+ messages in thread From: Otavio Salvador @ 2023-05-27 13:29 UTC (permalink / raw) To: Shawn Guo Cc: Arnd Bergmann, Otavio Salvador, linux-arm-kernel, Alistair Francis, Fabio Estevam, Kirill A. Shutemov, Marcel Ziswiler, Mark Brown, Michael Ellerman, NXP Linux Team, Pengutronix Kernel Team, Russell King, Sascha Hauer, Stefan Hansson, Stefan Wahren, linux-kernel Hello Shawn, Em sáb., 27 de mai. de 2023 às 09:44, Shawn Guo <shawnguo@kernel.org> escreveu: > > On Wed, May 24, 2023 at 08:48:26AM +0200, Arnd Bergmann wrote: > > On Tue, May 23, 2023, at 23:28, Otavio Salvador wrote: > > > The KERNEL_GZIP is used in most config and is the default, there is no > > > clear reason to diverge so let default be used. > > > > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > > > > I don't mind that change, but it seems odd to single this one out, as > > there are many other options in that particular defconfig that > > stick out more, picking LZO seems like a reasonable choice for slightly > > faster booting, though ZSTD would be the more modern choice. > > > > If you are looking into cleaning up this file, maybe see if we can > > kill off these options: > > > > CONFIG_EXPERT=y > > CONFIG_ARCH_FORCE_MAX_ORDER=13 > > CONFIG_CMDLINE="noinitrd console=ttymxc0,115200" > > CONFIG_CS89x0_PLATFORM=y # none of these four are in dts files > > CONFIG_SMC91X=y > > CONFIG_SMC911X=y > > CONFIG_SMSC911X=y > > CONFIG_STAGING=y > > CONFIG_STAGING_MEDIA=y > > CONFIG_VIDEO_IMX_MEDIA=y # not graduated from staging after 6 years > > CONFIG_EXT2_FS=y > > CONFIG_EXT3_FS=y # select EXT4 instead > > CONFIG_ISO9660_FS=m > > > > I have not investigated why any of them were added originally, > > so it's likely that some are actually needed. > > Would you investigate the suggested options and see if we can clean up > more than just KERNEL_LZO? Sure. I'll view them. I'll prepare more patches for it. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-27 13:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-05-23 21:28 [PATCH] ARM: imx_v6_v7_defconfig: Remove KERNEL_LZO config Otavio Salvador 2023-05-23 21:54 ` Fabio Estevam 2023-05-24 6:48 ` Arnd Bergmann 2023-05-24 10:47 ` Francesco Dolcini 2023-05-27 12:44 ` Shawn Guo 2023-05-27 13:29 ` Otavio Salvador
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).