LKML Archive on lore.kernel.org
 help / Atom feed
* [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs
@ 2018-07-11 14:26 Geert Uytterhoeven
  2018-07-11 21:46 ` Olof Johansson
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-07-11 14:26 UTC (permalink / raw)
  To: Russell King, Arnd Bergmann, Olof Johansson, Kevin Hilman
  Cc: linux-arm-kernel, linux-kernel, Geert Uytterhoeven

This allows to derive the kernel flavor from the kernel version at
runtime.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Handle "new" multi_v4t_defconfig.
---
 arch/arm/configs/multi_v4t_defconfig | 1 +
 arch/arm/configs/multi_v5_defconfig  | 1 +
 arch/arm/configs/multi_v7_defconfig  | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/arm/configs/multi_v4t_defconfig b/arch/arm/configs/multi_v4t_defconfig
index 9a6390c172d6b676..9bbb76e8260611df 100644
--- a/arch/arm/configs/multi_v4t_defconfig
+++ b/arch/arm/configs/multi_v4t_defconfig
@@ -1,3 +1,4 @@
+CONFIG_LOCALVERSION="-multi_v4t"
 CONFIG_KERNEL_LZMA=y
 CONFIG_SYSVIPC=y
 CONFIG_LOG_BUF_SHIFT=14
diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig
index 7c41bee284630d14..5797c8b40c763b55 100644
--- a/arch/arm/configs/multi_v5_defconfig
+++ b/arch/arm/configs/multi_v5_defconfig
@@ -1,3 +1,4 @@
+CONFIG_LOCALVERSION="-multi_v5"
 CONFIG_SYSVIPC=y
 CONFIG_FHANDLE=y
 CONFIG_NO_HZ=y
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4c71fcb03bccfb8d..155d1eb10c6580fe 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -1,3 +1,4 @@
+CONFIG_LOCALVERSION="-multi_v7"
 CONFIG_SYSVIPC=y
 CONFIG_NO_HZ=y
 CONFIG_HIGH_RES_TIMERS=y
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs
  2018-07-11 14:26 [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs Geert Uytterhoeven
@ 2018-07-11 21:46 ` Olof Johansson
  2018-07-12  7:25   ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2018-07-11 21:46 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Russell King, Arnd Bergmann, Kevin Hilman,
	Linux ARM Mailing List, Linux Kernel Mailing List

Hi,

On Wed, Jul 11, 2018 at 7:26 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> This allows to derive the kernel flavor from the kernel version at
> runtime.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I prefer not to have this go in -- this is extremely likely to creep
into derivative configs and as such it would have no value (you can't
be sure it's still the same config).

/proc/config.gz is the way to keep track of exactly what config you're
running anyway, right?

-Olof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs
  2018-07-11 21:46 ` Olof Johansson
@ 2018-07-12  7:25   ` Geert Uytterhoeven
  0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-07-12  7:25 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Geert Uytterhoeven, Russell King, Arnd Bergmann, Kevin Hilman,
	Linux ARM, Linux Kernel Mailing List

Hi Olof,

On Wed, Jul 11, 2018 at 11:46 PM Olof Johansson <olof@lixom.net> wrote:
> On Wed, Jul 11, 2018 at 7:26 AM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > This allows to derive the kernel flavor from the kernel version at
> > runtime.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I prefer not to have this go in -- this is extremely likely to creep
> into derivative configs and as such it would have no value (you can't
> be sure it's still the same config).

Fair enough. Unfortunately we cannot prevent that from happening :-(

> /proc/config.gz is the way to keep track of exactly what config you're
> running anyway, right?

Yes, in some convoluted and hard to identify way ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 14:26 [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs Geert Uytterhoeven
2018-07-11 21:46 ` Olof Johansson
2018-07-12  7:25   ` Geert Uytterhoeven

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox