* [PATCH 1/2] wcn36xx: Correct Kconfig dependency [not found] <201611092150.OxpAuHow%fengguang.wu@intel.com> @ 2016-11-09 18:02 ` Bjorn Andersson 2016-11-09 20:32 ` Marcel Holtmann 2016-11-09 18:02 ` [PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson 1 sibling, 1 reply; 5+ messages in thread From: Bjorn Andersson @ 2016-11-09 18:02 UTC (permalink / raw) To: Andy Gross, Eugene Krasnikov, Kalle Valo Cc: wcn36xx, linux-wireless, netdev, linux-kernel In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be compiled as module as well, so we need to mention this dependency. But we still want allow the driver to be compiled in case either of those are =n, for compile testing reasons. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/wcn36xx/Kconfig b/drivers/net/wireless/ath/wcn36xx/Kconfig index 591ebaea8265..4b83e87f0b94 100644 --- a/drivers/net/wireless/ath/wcn36xx/Kconfig +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig @@ -1,6 +1,8 @@ config WCN36XX tristate "Qualcomm Atheros WCN3660/3680 support" depends on MAC80211 && HAS_DMA + depends on QCOM_WCNSS_CTRL || QCOM_WCNSS_CTRL=n + depends on QCOM_SMD || QCOM_SMD=n ---help--- This module adds support for wireless adapters based on Qualcomm Atheros WCN3660 and WCN3680 mobile chipsets. -- 2.5.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency 2016-11-09 18:02 ` [PATCH 1/2] wcn36xx: Correct Kconfig dependency Bjorn Andersson @ 2016-11-09 20:32 ` Marcel Holtmann 2016-11-09 20:45 ` Bjorn Andersson 0 siblings, 1 reply; 5+ messages in thread From: Marcel Holtmann @ 2016-11-09 20:32 UTC (permalink / raw) To: Bjorn Andersson Cc: Andy Gross, Eugene Krasnikov, Kalle Valo, wcn36xx, linux-wireless, netdev, linux-kernel Hi Bjorn, > In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be > compiled as module as well, so we need to mention this dependency. > But we still want allow the driver to be compiled in case either of > those are =n, for compile testing reasons. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/ath/wcn36xx/Kconfig b/drivers/net/wireless/ath/wcn36xx/Kconfig > index 591ebaea8265..4b83e87f0b94 100644 > --- a/drivers/net/wireless/ath/wcn36xx/Kconfig > +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig > @@ -1,6 +1,8 @@ > config WCN36XX > tristate "Qualcomm Atheros WCN3660/3680 support" > depends on MAC80211 && HAS_DMA > + depends on QCOM_WCNSS_CTRL || QCOM_WCNSS_CTRL=n > + depends on QCOM_SMD || QCOM_SMD=n I thought we wanted to move towards being able to compile the WiFi and Bluetooth support without requiring QCOM_SMD. Regards Marcel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency 2016-11-09 20:32 ` Marcel Holtmann @ 2016-11-09 20:45 ` Bjorn Andersson 0 siblings, 0 replies; 5+ messages in thread From: Bjorn Andersson @ 2016-11-09 20:45 UTC (permalink / raw) To: Marcel Holtmann Cc: Andy Gross, Eugene Krasnikov, Kalle Valo, wcn36xx, linux-wireless, netdev, linux-kernel On Wed 09 Nov 12:32 PST 2016, Marcel Holtmann wrote: > Hi Bjorn, > > > In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be > > compiled as module as well, so we need to mention this dependency. > > But we still want allow the driver to be compiled in case either of > > those are =n, for compile testing reasons. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/wireless/ath/wcn36xx/Kconfig b/drivers/net/wireless/ath/wcn36xx/Kconfig > > index 591ebaea8265..4b83e87f0b94 100644 > > --- a/drivers/net/wireless/ath/wcn36xx/Kconfig > > +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig > > @@ -1,6 +1,8 @@ > > config WCN36XX > > tristate "Qualcomm Atheros WCN3660/3680 support" > > depends on MAC80211 && HAS_DMA > > + depends on QCOM_WCNSS_CTRL || QCOM_WCNSS_CTRL=n > > + depends on QCOM_SMD || QCOM_SMD=n > > I thought we wanted to move towards being able to compile the WiFi and > Bluetooth support without requiring QCOM_SMD. > That's right. The problem I spotted was that without the dependency on QCOM_SMD we're allowed to compile these modules as builtin, but as IS_ENABLED(CONFIG_QCOM_SMD) is true we don't get the stubs and as such the kernel doesn't link. So we must enforce these modules to be compiled as modules if either QCOM_SMD or QCOM_WCNSS_CTRL are compiled as modules, and we do that with the first part of the depends lines. The second part of the depends lines states that the alternative dependency is that the modules are not enabled at all, in which case we will fall back to using the function stubs. So this is unfortunately how we have to describe it in Kconfig to work with the function stubs, sorry for not getting this right in the first place. Regards, Bjorn ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR() [not found] <201611092150.OxpAuHow%fengguang.wu@intel.com> 2016-11-09 18:02 ` [PATCH 1/2] wcn36xx: Correct Kconfig dependency Bjorn Andersson @ 2016-11-09 18:02 ` Bjorn Andersson 2016-11-09 20:11 ` Andy Gross 1 sibling, 1 reply; 5+ messages in thread From: Bjorn Andersson @ 2016-11-09 18:02 UTC (permalink / raw) To: Andy Gross, Eugene Krasnikov, Kalle Valo Cc: wcn36xx, linux-wireless, netdev, linux-kernel The correct include file for getting errno constants and ERR_PTR() is linux/err.h, rather than linux/errno.h, so fix the include. Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Andy, I don't see anything else going into v4.10 for smem_state.h. So if you are okay I would like Kalle to pick this patch through his tree and be able to merge my wcn36xx patches for v4.10. include/linux/soc/qcom/smem_state.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/soc/qcom/smem_state.h b/include/linux/soc/qcom/smem_state.h index 7b88697929e9..b8478ee7a71f 100644 --- a/include/linux/soc/qcom/smem_state.h +++ b/include/linux/soc/qcom/smem_state.h @@ -1,7 +1,7 @@ #ifndef __QCOM_SMEM_STATE__ #define __QCOM_SMEM_STATE__ -#include <linux/errno.h> +#include <linux/err.h> struct device_node; struct qcom_smem_state; -- 2.5.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR() 2016-11-09 18:02 ` [PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson @ 2016-11-09 20:11 ` Andy Gross 0 siblings, 0 replies; 5+ messages in thread From: Andy Gross @ 2016-11-09 20:11 UTC (permalink / raw) To: Bjorn Andersson Cc: Eugene Krasnikov, Kalle Valo, wcn36xx, linux-wireless, netdev, Linux Kernel list On 9 November 2016 at 12:02, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > The correct include file for getting errno constants and ERR_PTR() is > linux/err.h, rather than linux/errno.h, so fix the include. > > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > > Andy, I don't see anything else going into v4.10 for smem_state.h. So if you > are okay I would like Kalle to pick this patch through his tree and be able to > merge my wcn36xx patches for v4.10. > > include/linux/soc/qcom/smem_state.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/soc/qcom/smem_state.h b/include/linux/soc/qcom/smem_state.h > index 7b88697929e9..b8478ee7a71f 100644 > --- a/include/linux/soc/qcom/smem_state.h > +++ b/include/linux/soc/qcom/smem_state.h > @@ -1,7 +1,7 @@ > #ifndef __QCOM_SMEM_STATE__ > #define __QCOM_SMEM_STATE__ > > -#include <linux/errno.h> > +#include <linux/err.h> > > struct device_node; > struct qcom_smem_state; > -- > 2.5.0 > This time with less html. Acked-by: Andy Gross <andy.gross@linaro.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-09 20:45 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <201611092150.OxpAuHow%fengguang.wu@intel.com> 2016-11-09 18:02 ` [PATCH 1/2] wcn36xx: Correct Kconfig dependency Bjorn Andersson 2016-11-09 20:32 ` Marcel Holtmann 2016-11-09 20:45 ` Bjorn Andersson 2016-11-09 18:02 ` [PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR() Bjorn Andersson 2016-11-09 20:11 ` Andy Gross
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).