* Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card
[not found] <<20181105084506.6476-1-kai.heng.feng@canonical.com>
@ 2018-11-08 12:17 ` Oleksandr Natalenko
2018-11-23 6:06 ` Kai Heng Feng
0 siblings, 1 reply; 5+ messages in thread
From: Oleksandr Natalenko @ 2018-11-08 12:17 UTC (permalink / raw)
To: kai.heng.feng; +Cc: arnd, gregkh, linux-kernel, linux-usb, stern, ulf.hansson
> This is based on Ulf's work [1] [2].
>
> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> platforms and ~1.5W on AMD platforms.
>
> [1] https://patchwork.kernel.org/patch/10440583/
> [2] https://patchwork.kernel.org/patch/10445725/
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
--
Oleksandr Natalenko (post-factum)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card
2018-11-08 12:17 ` [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card Oleksandr Natalenko
@ 2018-11-23 6:06 ` Kai Heng Feng
2018-11-23 12:21 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Kai Heng Feng @ 2018-11-23 6:06 UTC (permalink / raw)
To: Ulf Hansson
Cc: Arnd Bergmann, Greg Kroah-Hartman, Linux Kernel Mailing List,
Linux USB List, Alan Stern, Oleksandr Natalenko
Hi Ulf,
> On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko <oleksandr@natalenko.name> wrote:
>
>> This is based on Ulf's work [1] [2].
>> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
>> platforms and ~1.5W on AMD platforms.
>> [1] https://patchwork.kernel.org/patch/10440583/
>> [2] https://patchwork.kernel.org/patch/10445725/
>
> Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Do you think this series is ready to be merged to v4.20?
Kai-Heng
>
> --
> Oleksandr Natalenko (post-factum)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card
2018-11-23 6:06 ` Kai Heng Feng
@ 2018-11-23 12:21 ` Ulf Hansson
2018-12-06 8:57 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2018-11-23 12:21 UTC (permalink / raw)
To: Kai Heng Feng
Cc: Arnd Bergmann, Greg Kroah-Hartman, Linux Kernel Mailing List,
Linux USB List, Alan Stern, Oleksandr Natalenko
On Fri, 23 Nov 2018 at 07:06, Kai Heng Feng <kai.heng.feng@canonical.com> wrote:
>
> Hi Ulf,
>
> > On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko <oleksandr@natalenko.name> wrote:
> >
> >> This is based on Ulf's work [1] [2].
> >> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> >> platforms and ~1.5W on AMD platforms.
> >> [1] https://patchwork.kernel.org/patch/10440583/
> >> [2] https://patchwork.kernel.org/patch/10445725/
> >
> > Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
>
> Do you think this series is ready to be merged to v4.20?
I have had a brief look at the latest version a while ago, looked
good. However, allow a few more days before I can give it my final
blessing.
BTW. We need to figure out what path to route the changes through. I
can pick it via my mmc tree, unless someone object to that.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card
2018-11-23 12:21 ` Ulf Hansson
@ 2018-12-06 8:57 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2018-12-06 8:57 UTC (permalink / raw)
To: Kai Heng Feng
Cc: Arnd Bergmann, Greg Kroah-Hartman, Linux Kernel Mailing List,
Linux USB List, Alan Stern, Oleksandr Natalenko
On Fri, 23 Nov 2018 at 13:21, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Fri, 23 Nov 2018 at 07:06, Kai Heng Feng <kai.heng.feng@canonical.com> wrote:
> >
> > Hi Ulf,
> >
> > > On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko <oleksandr@natalenko.name> wrote:
> > >
> > >> This is based on Ulf's work [1] [2].
> > >> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> > >> platforms and ~1.5W on AMD platforms.
> > >> [1] https://patchwork.kernel.org/patch/10440583/
> > >> [2] https://patchwork.kernel.org/patch/10445725/
> > >
> > > Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> >
> > Do you think this series is ready to be merged to v4.20?
>
> I have had a brief look at the latest version a while ago, looked
> good. However, allow a few more days before I can give it my final
> blessing.
>
> BTW. We need to figure out what path to route the changes through. I
> can pick it via my mmc tree, unless someone object to that.
Okay, so I have picked up the patches and applied them to my next
branch to my mmc tree. While doing that, I have also added Oleksandr's
tested-by tag for all patches, including the four mmc patches. I also
added your tested-by tags to the the four mmc patches.
Finally I made little cosmetic change to last patch in this series,
which was dropping the surrounding #ifdef CONFIG_PM while do the
assignment of .driver.pm to &rtsx_usb_ms_pm_ops, as that isn't needed.
If anybody have any objections, please tell me.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card
@ 2018-11-05 8:45 Kai-Heng Feng
0 siblings, 0 replies; 5+ messages in thread
From: Kai-Heng Feng @ 2018-11-05 8:45 UTC (permalink / raw)
To: arnd, gregkh; +Cc: ulf.hansson, stern, linux-kernel, linux-usb, Kai-Heng Feng
Hi,
This is based on Ulf's work [1] [2].
This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
platforms and ~1.5W on AMD platforms.
[1] https://patchwork.kernel.org/patch/10440583/
[2] https://patchwork.kernel.org/patch/10445725/
Kai-Heng Feng (5):
memstick: rtsx_usb_ms: Add missing pm_runtime_disable() in probe
function
misc: rtsx_usb: Use USB remote wakeup signaling for card insertion
detection
memstick: Prevent memstick host from getting runtime suspended during
card detection
memstick: rtsx_usb_ms: Use ms_dev() helper
memstick: rtsx_usb_ms: Support runtime power management
v7: Keep CONFIG_PM_SLEEP for .suspend and .resume callbacks.
Use CONFIG_PM for .runtime_suspend and .runtime_resume callbacks.
Reorder pm_runtime_get_noresume() before pm_runtime_enable().
Add missing pm_runtime_disable().
v6: Move pm_runtime_get_noresume() to media_check(), to avoid
potentially unblanced rpm count.
v5: Corretly use system suspend/resume and runtime suspend/resume callback.
Prevent runtime callbacks get call during system suspend.
v4: Use pm_runtime_put() in memstick_check().
v3: Skip parent device check in rtsx_usb_resume_child().
Remove dev_dbg() if it only prints function name.
Use ms_dev() helper at more places.
Remove const qualifier for UNIVERSAL_DEV_PM_OPS.
v2: Resend to linux-usb and LKML.
drivers/memstick/core/memstick.c | 3 +
drivers/memstick/host/rtsx_usb_ms.c | 172 +++++++++++++++++-----------
drivers/misc/cardreader/rtsx_usb.c | 8 ++
3 files changed, 117 insertions(+), 66 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-06 8:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <<20181105084506.6476-1-kai.heng.feng@canonical.com>
2018-11-08 12:17 ` [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card Oleksandr Natalenko
2018-11-23 6:06 ` Kai Heng Feng
2018-11-23 12:21 ` Ulf Hansson
2018-12-06 8:57 ` Ulf Hansson
2018-11-05 8:45 Kai-Heng Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).