* linux-next: build warning after merge of the mmc-uh tree
@ 2016-06-06 1:38 Stephen Rothwell
2016-06-06 1:51 ` Shawn Lin
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2016-06-06 1:38 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-next, linux-kernel, Shawn Lin
Hi Ulf,
After merging the mmc-uh tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from include/linux/err.h:4:0,
from drivers/mmc/core/mmc.c:13:
drivers/mmc/core/mmc.c: In function 'mmc_select_hs400es':
include/linux/err.h:21:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
#define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
^
include/linux/compiler.h:170:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
drivers/mmc/core/mmc.c:1244:6: note: in expansion of macro 'IS_ERR_VALUE'
if (IS_ERR_VALUE(err))
^
Introduced by commit
8141f0ace818 ("mmc: core: implement enhanced strobe support")
I think error values now must be "long".
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build warning after merge of the mmc-uh tree
2016-06-06 1:38 linux-next: build warning after merge of the mmc-uh tree Stephen Rothwell
@ 2016-06-06 1:51 ` Shawn Lin
2016-06-07 21:42 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Lin @ 2016-06-06 1:51 UTC (permalink / raw)
To: Stephen Rothwell, Ulf Hansson; +Cc: shawn.lin, linux-next, linux-kernel
Hi Stephen,
On 2016/6/6 9:38, Stephen Rothwell wrote:
> Hi Ulf,
>
> After merging the mmc-uh tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from include/linux/err.h:4:0,
> from drivers/mmc/core/mmc.c:13:
> drivers/mmc/core/mmc.c: In function 'mmc_select_hs400es':
> include/linux/err.h:21:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO)
> ^
> include/linux/compiler.h:170:42: note: in definition of macro 'unlikely'
> # define unlikely(x) __builtin_expect(!!(x), 0)
> ^
> drivers/mmc/core/mmc.c:1244:6: note: in expansion of macro 'IS_ERR_VALUE'
> if (IS_ERR_VALUE(err))
> ^
Yup, sorry for this noise. Arnd had removed a lot of IS_ERR_VALUE
abuses, but I forgot to amend this one.
Hi Ulf,
Should I come up with a new fix or you could manually amend it from
"IS_ERR_VALUE(err)" to "err < 0"? :)
>
> Introduced by commit
>
> 8141f0ace818 ("mmc: core: implement enhanced strobe support")
>
> I think error values now must be "long".
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build warning after merge of the mmc-uh tree
2016-06-06 1:51 ` Shawn Lin
@ 2016-06-07 21:42 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2016-06-07 21:42 UTC (permalink / raw)
To: Shawn Lin, Stephen Rothwell; +Cc: linux-next, linux-kernel
On 6 June 2016 at 03:51, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Hi Stephen,
>
> On 2016/6/6 9:38, Stephen Rothwell wrote:
>>
>> Hi Ulf,
>>
>> After merging the mmc-uh tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> In file included from include/linux/err.h:4:0,
>> from drivers/mmc/core/mmc.c:13:
>> drivers/mmc/core/mmc.c: In function 'mmc_select_hs400es':
>> include/linux/err.h:21:49: warning: cast to pointer from integer of
>> different size [-Wint-to-pointer-cast]
>> #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned
>> long)-MAX_ERRNO)
>> ^
>> include/linux/compiler.h:170:42: note: in definition of macro 'unlikely'
>> # define unlikely(x) __builtin_expect(!!(x), 0)
>> ^
>> drivers/mmc/core/mmc.c:1244:6: note: in expansion of macro 'IS_ERR_VALUE'
>> if (IS_ERR_VALUE(err))
>> ^
>
>
> Yup, sorry for this noise. Arnd had removed a lot of IS_ERR_VALUE
> abuses, but I forgot to amend this one.
>
>
> Hi Ulf,
>
> Should I come up with a new fix or you could manually amend it from
> "IS_ERR_VALUE(err)" to "err < 0"? :)
>
>>
>> Introduced by commit
>>
>> 8141f0ace818 ("mmc: core: implement enhanced strobe support")
>>
>> I think error values now must be "long".
>>
Thanks for reporting and fixing!
I have amended the commit above and published the change on my next branch.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-07 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-06 1:38 linux-next: build warning after merge of the mmc-uh tree Stephen Rothwell
2016-06-06 1:51 ` Shawn Lin
2016-06-07 21:42 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).