* Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP
2021-06-15 3:00 ` [PATCH v1] dt-bindings: mmc: change " Wenbin Mei
@ 2021-06-24 20:46 ` Rob Herring
2021-06-29 15:09 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-06-24 20:46 UTC (permalink / raw)
To: Wenbin Mei
Cc: Rob Herring, linux-arm-kernel, Seiya Wang, devicetree, linux-mmc,
srv_heupstream, linux-kernel, Chaotian Jing, Ulf Hansson,
linux-mediatek, Matthias Brugger
On Tue, 15 Jun 2021 11:00:33 +0800, Wenbin Mei wrote:
> MT8195 mmc host IP is compatible with MT8183, and currently it shows:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which means the compatible string in the device tree would be:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
> "mediatek,mt8183-mmc";
> The bindings is wrong and that isn't the result we want.
> instead we want:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which would give us:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> and
> compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";
>
> Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] dt-bindings: mmc: change compatiable string for MT8195 mmc host IP
2021-06-15 3:00 ` [PATCH v1] dt-bindings: mmc: change " Wenbin Mei
2021-06-24 20:46 ` Rob Herring
@ 2021-06-29 15:09 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2021-06-29 15:09 UTC (permalink / raw)
To: Wenbin Mei
Cc: Rob Herring, Matthias Brugger, Chaotian Jing, Seiya Wang,
linux-mmc, DTML, Linux ARM,
moderated list:ARM/Mediatek SoC support,
Linux Kernel Mailing List, srv_heupstream
On Tue, 15 Jun 2021 at 05:01, Wenbin Mei <wenbin.mei@mediatek.com> wrote:
>
> MT8195 mmc host IP is compatible with MT8183, and currently it shows:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which means the compatible string in the device tree would be:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc",
> "mediatek,mt8183-mmc";
> The bindings is wrong and that isn't the result we want.
> instead we want:
> properties:
> compatible:
> oneOf:
> ...
> - items:
> - const: mediatek,mt8192-mmc
> - const: mediatek,mt8183-mmc
> - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
> which would give us:
> compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc";
> and
> compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc";
>
> Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195)
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 8648d48..adaba90 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -31,6 +31,8 @@ properties:
> - const: mediatek,mt2701-mmc
> - items:
> - const: mediatek,mt8192-mmc
> + - const: mediatek,mt8183-mmc
> + - items:
> - const: mediatek,mt8195-mmc
> - const: mediatek,mt8183-mmc
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread