* [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings
@ 2021-08-25 18:18 Gwendal Grignou
2021-08-27 5:21 ` Dmitry Osipenko
0 siblings, 1 reply; 3+ messages in thread
From: Gwendal Grignou @ 2021-08-25 18:18 UTC (permalink / raw)
To: bleung, enric.balletbo, groeck; +Cc: linux-kernel, Gwendal Grignou
Fix printf format issues in new tracing events.
Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
Changes since v1:
- Use %u instead of %d for ec timestamp, it is presented as a u32.
drivers/platform/chrome/cros_ec_trace.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
index f50b9f9b8610..9d0c848af310 100644
--- a/drivers/platform/chrome/cros_ec_trace.h
+++ b/drivers/platform/chrome/cros_ec_trace.h
@@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp,
__entry->current_time = current_time;
__entry->delta = current_timestamp - current_time;
),
- TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
+ TP_printk("ec_ts: %9d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
__entry->ec_sample_timestamp,
__entry->ec_fifo_timestamp,
__entry->fifo_timestamp,
@@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data,
__entry->current_time = current_time;
__entry->delta = current_timestamp - current_time;
),
- TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
+ TP_printk("ec_num: %4d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
__entry->ec_sensor_num,
__entry->ec_fifo_timestamp,
__entry->fifo_timestamp,
@@ -153,7 +153,7 @@ TRACE_EVENT(cros_ec_sensorhub_filter,
__entry->x = state->x_offset;
__entry->y = state->y_offset;
),
- TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %d x: %12lld y: %12lld",
+ TP_printk("dx: %12lld. dy: %12lld median_m: %12lld median_error: %12lld len: %lld x: %12lld y: %12lld",
__entry->dx,
__entry->dy,
__entry->median_m,
--
2.33.0.rc2.250.ged5fa647cd-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings
2021-08-25 18:18 [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings Gwendal Grignou
@ 2021-08-27 5:21 ` Dmitry Osipenko
2021-08-30 18:01 ` Gwendal Grignou
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Osipenko @ 2021-08-27 5:21 UTC (permalink / raw)
To: Gwendal Grignou, bleung, enric.balletbo, groeck; +Cc: linux-kernel
25.08.2021 21:18, Gwendal Grignou пишет:
> Fix printf format issues in new tracing events.
>
> Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> Changes since v1:
> - Use %u instead of %d for ec timestamp, it is presented as a u32.
>
> drivers/platform/chrome/cros_ec_trace.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
> index f50b9f9b8610..9d0c848af310 100644
> --- a/drivers/platform/chrome/cros_ec_trace.h
> +++ b/drivers/platform/chrome/cros_ec_trace.h
> @@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp,
> __entry->current_time = current_time;
> __entry->delta = current_timestamp - current_time;
> ),
> - TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> + TP_printk("ec_ts: %9d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
ec_ts unsigned
> __entry->ec_sample_timestamp,
> __entry->ec_fifo_timestamp,
> __entry->fifo_timestamp,
> @@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data,
> __entry->current_time = current_time;
> __entry->delta = current_timestamp - current_time;
> ),
> - TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> + TP_printk("ec_num: %4d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
ec_num unsigned
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings
2021-08-27 5:21 ` Dmitry Osipenko
@ 2021-08-30 18:01 ` Gwendal Grignou
0 siblings, 0 replies; 3+ messages in thread
From: Gwendal Grignou @ 2021-08-30 18:01 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Benson Leung, Enric Balletbo i Serra, Guenter Roeck, linux-kernel
Fixed in V3.
Thanks,
Gwendal.
On Thu, Aug 26, 2021 at 10:21 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 25.08.2021 21:18, Gwendal Grignou пишет:
> > Fix printf format issues in new tracing events.
> >
> > Fixes: 814318242 ("platform/chrome: cros_ec_trace: Add fields to command traces")
> >
> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> > ---
> > Changes since v1:
> > - Use %u instead of %d for ec timestamp, it is presented as a u32.
> >
> > drivers/platform/chrome/cros_ec_trace.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
> > index f50b9f9b8610..9d0c848af310 100644
> > --- a/drivers/platform/chrome/cros_ec_trace.h
> > +++ b/drivers/platform/chrome/cros_ec_trace.h
> > @@ -92,7 +92,7 @@ TRACE_EVENT(cros_ec_sensorhub_timestamp,
> > __entry->current_time = current_time;
> > __entry->delta = current_timestamp - current_time;
> > ),
> > - TP_printk("ec_ts: %12lld, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> > + TP_printk("ec_ts: %9d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
>
> ec_ts unsigned
>
> > __entry->ec_sample_timestamp,
> > __entry->ec_fifo_timestamp,
> > __entry->fifo_timestamp,
> > @@ -122,7 +122,7 @@ TRACE_EVENT(cros_ec_sensorhub_data,
> > __entry->current_time = current_time;
> > __entry->delta = current_timestamp - current_time;
> > ),
> > - TP_printk("ec_num: %4d, ec_fifo_ts: %12lld, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
> > + TP_printk("ec_num: %4d, ec_fifo_ts: %9u, fifo_ts: %12lld, curr_ts: %12lld, curr_time: %12lld, delta %12lld",
>
> ec_num unsigned
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-30 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 18:18 [PATCH v2] platform/chrome: cros_ec_trace: Fix format warnings Gwendal Grignou
2021-08-27 5:21 ` Dmitry Osipenko
2021-08-30 18:01 ` Gwendal Grignou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).