linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
@ 2016-11-07 22:44 Chris Roth
  2016-11-08  6:48 ` Greg KH
  2016-11-08 22:08 ` [PATCH v5] " chris.roth
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Roth @ 2016-11-07 22:44 UTC (permalink / raw)
  To: linux-usb, netdev, linux-kernel; +Cc: Allan Chou, Artjom Simon

From: Allan Chou <allan@asix.com.tw>

Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
Bridge Controller (Vendor=04b4 ProdID=3610).

Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
with the Kensington SD4600P USB-C Universal Dock with Power,
which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
Controller.

A similar patch was signed-off and tested-by Allan Chou
<allan@asix.com.tw> on 2015-12-01.

Allan verified his similar patch on x86 Linux kernel 4.1.6 system
with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.

Tested-by: Allan Chou <allan@asix.com.tw>
Tested-by: Chris Roth <chris.roth@usask.ca>
Tested-by: Artjom Simon <artjom.simon@gmail.com>

Signed-off-by: Allan Chou <allan@asix.com.tw>
Signed-off-by: Chris Roth <chris.roth@usask.ca>
---
 drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index e6338c1..8a6675d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
     .tx_fixup = ax88179_tx_fixup,
 };

+static const struct driver_info cypress_GX3_info = {
+    .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
+    .bind = ax88179_bind,
+    .unbind = ax88179_unbind,
+    .status = ax88179_status,
+    .link_reset = ax88179_link_reset,
+    .reset = ax88179_reset,
+    .stop = ax88179_stop,
+    .flags = FLAG_ETHER | FLAG_FRAMING_AX,
+    .rx_fixup = ax88179_rx_fixup,
+    .tx_fixup = ax88179_tx_fixup,
+};
+
 static const struct driver_info dlink_dub1312_info = {
     .description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter",
     .bind = ax88179_bind,
@@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = {
     , USB_DEVICE(0x0b95, 0x178a),
     .driver_info = (unsigned long)&ax88178a_info,
 }, {
+    /* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */
+    USB_DEVICE(0x04b4, 0x3610),
+    .driver_info = (unsigned long)&cypress_GX3_info,
+}, {
     /* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */
     USB_DEVICE(0x2001, 0x4a00),
     .driver_info = (unsigned long)&dlink_dub1312_info,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
  2016-11-07 22:44 [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610 Chris Roth
@ 2016-11-08  6:48 ` Greg KH
  2016-11-08 22:08 ` [PATCH v5] " chris.roth
  1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2016-11-08  6:48 UTC (permalink / raw)
  To: Chris Roth; +Cc: linux-usb, netdev, linux-kernel, Allan Chou, Artjom Simon

On Mon, Nov 07, 2016 at 04:44:20PM -0600, Chris Roth wrote:
> From: Allan Chou <allan@asix.com.tw>
> 
> Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
> Bridge Controller (Vendor=04b4 ProdID=3610).
> 
> Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
> with the Kensington SD4600P USB-C Universal Dock with Power,
> which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
> Controller.
> 
> A similar patch was signed-off and tested-by Allan Chou
> <allan@asix.com.tw> on 2015-12-01.
> 
> Allan verified his similar patch on x86 Linux kernel 4.1.6 system
> with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.
> 
> Tested-by: Allan Chou <allan@asix.com.tw>
> Tested-by: Chris Roth <chris.roth@usask.ca>
> Tested-by: Artjom Simon <artjom.simon@gmail.com>
> 
> Signed-off-by: Allan Chou <allan@asix.com.tw>
> Signed-off-by: Chris Roth <chris.roth@usask.ca>
> ---
>  drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
> index e6338c1..8a6675d 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
>      .tx_fixup = ax88179_tx_fixup,
>  };
> 
> +static const struct driver_info cypress_GX3_info = {
> +    .description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
> +    .bind = ax88179_bind,
> +    .unbind = ax88179_unbind,
> +    .status = ax88179_status,
> +    .link_reset = ax88179_link_reset,
> +    .reset = ax88179_reset,
> +    .stop = ax88179_stop,
> +    .flags = FLAG_ETHER | FLAG_FRAMING_AX,
> +    .rx_fixup = ax88179_rx_fixup,
> +    .tx_fixup = ax88179_tx_fixup,
> +};

Your tabs got eaten and converted to spaces, making this patch
impossible to apply :(

And you forgot to list what changed from v3, please put that below the
--- line.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
  2016-11-07 22:44 [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610 Chris Roth
  2016-11-08  6:48 ` Greg KH
@ 2016-11-08 22:08 ` chris.roth
  2016-11-10  2:47   ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: chris.roth @ 2016-11-08 22:08 UTC (permalink / raw)
  To: linux-usb, netdev, linux-kernel, artjom.simon, gregkh
  Cc: Allan Chou, Chris Roth

From: Allan Chou <allan@asix.com.tw>

Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
Bridge Controller (Vendor=04b4 ProdID=3610).

Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
with the Kensington SD4600P USB-C Universal Dock with Power,
which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
Controller.

A similar patch was signed-off and tested-by Allan Chou
<allan@asix.com.tw> on 2015-12-01.

Allan verified his similar patch on x86 Linux kernel 4.1.6 system
with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.

Tested-by: Allan Chou <allan@asix.com.tw>
Tested-by: Chris Roth <chris.roth@usask.ca>
Tested-by: Artjom Simon <artjom.simon@gmail.com>

Signed-off-by: Allan Chou <allan@asix.com.tw>
Signed-off-by: Chris Roth <chris.roth@usask.ca>
---
Changes in v4, v5:
 - Add verification of patch on 4.8.6, 4.9-rc4 (v4)
 - Add tester Artjom Simon <artjom.simon@gmail.com> (v4)
 - Reformat spaces to tabs (v5)

 drivers/net/usb/ax88179_178a.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index e6338c1..8a6675d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1656,6 +1656,19 @@ static const struct driver_info ax88178a_info = {
 	.tx_fixup = ax88179_tx_fixup,
 };
 
+static const struct driver_info cypress_GX3_info = {
+	.description = "Cypress GX3 SuperSpeed to Gigabit Ethernet Controller",
+	.bind = ax88179_bind,
+	.unbind = ax88179_unbind,
+	.status = ax88179_status,
+	.link_reset = ax88179_link_reset,
+	.reset = ax88179_reset,
+	.stop = ax88179_stop,
+	.flags = FLAG_ETHER | FLAG_FRAMING_AX,
+	.rx_fixup = ax88179_rx_fixup,
+	.tx_fixup = ax88179_tx_fixup,
+};
+
 static const struct driver_info dlink_dub1312_info = {
 	.description = "D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter",
 	.bind = ax88179_bind,
@@ -1718,6 +1731,10 @@ static const struct usb_device_id products[] = {
 	USB_DEVICE(0x0b95, 0x178a),
 	.driver_info = (unsigned long)&ax88178a_info,
 }, {
+	/* Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller */
+	USB_DEVICE(0x04b4, 0x3610),
+	.driver_info = (unsigned long)&cypress_GX3_info,
+}, {
 	/* D-Link DUB-1312 USB 3.0 to Gigabit Ethernet Adapter */
 	USB_DEVICE(0x2001, 0x4a00),
 	.driver_info = (unsigned long)&dlink_dub1312_info,
-- 
2.7.4

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.
  2016-11-08 22:08 ` [PATCH v5] " chris.roth
@ 2016-11-10  2:47   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-11-10  2:47 UTC (permalink / raw)
  To: chris.roth; +Cc: linux-usb, netdev, linux-kernel, artjom.simon, gregkh, allan

From: <chris.roth@usask.ca>
Date: Tue, 8 Nov 2016 16:08:01 -0600

> From: Allan Chou <allan@asix.com.tw>
> 
> Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet
> Bridge Controller (Vendor=04b4 ProdID=3610).
> 
> Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems
> with the Kensington SD4600P USB-C Universal Dock with Power,
> which uses the Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge
> Controller.
> 
> A similar patch was signed-off and tested-by Allan Chou
> <allan@asix.com.tw> on 2015-12-01.
> 
> Allan verified his similar patch on x86 Linux kernel 4.1.6 system
> with Cypress GX3 SuperSpeed to Gigabit Ethernet Bridge Controller.
> 
> Tested-by: Allan Chou <allan@asix.com.tw>
> Tested-by: Chris Roth <chris.roth@usask.ca>
> Tested-by: Artjom Simon <artjom.simon@gmail.com>
> 
> Signed-off-by: Allan Chou <allan@asix.com.tw>
> Signed-off-by: Chris Roth <chris.roth@usask.ca>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-10  2:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-07 22:44 [PATCH v4] Net Driver: Add Cypress GX3 VID=04b4 PID=3610 Chris Roth
2016-11-08  6:48 ` Greg KH
2016-11-08 22:08 ` [PATCH v5] " chris.roth
2016-11-10  2:47   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).