From: Dan Williams <dan.j.williams@intel.com>
To: Jerry Hoemann <jerry.hoemann@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 6/6] nfit allow override of root dsm mask
Date: Fri, 30 Jun 2017 20:49:50 -0700 [thread overview]
Message-ID: <CAPcyv4iR4T_umcF3H2aEGidmFMLUg4KSLmqMyoYvkOpbzn_YDQ@mail.gmail.com> (raw)
In-Reply-To: <660571c18986eb8c7025d4b68c0be5f7df48e569.1498810220.git.jerry.hoemann@hpe.com>
On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> Have module parameter override_dsm_mask override the dsm_mask for
> root calls like it does for non-root dsm calls.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
> drivers/acpi/nfit/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 4e24d69..87acaf2 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1641,6 +1641,8 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
> set_bit(ND_CMD_CALL, &nd_desc->cmd_mask);
>
> dsm_mask = 0x3bf;
> + if (override_dsm_mask)
> + dsm_mask = override_dsm_mask;
> for_each_set_bit(i, &dsm_mask, BITS_PER_LONG)
> if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i))
> set_bit(i, &nd_desc->bus_dsm_mask);
Another reason not to apply this is to take a look at what happened
with the introduction of _LSI, _LSR, and _LSW. We should not expect
that _DSM will keep being used for future NVDIMM root bus methods.
prev parent reply other threads:[~2017-07-01 3:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 16:09 [PATCH v3 0/7] Enable DSM pass thru for root functions Jerry Hoemann
2017-06-30 16:09 ` [PATCH v4 1/6] libnvdimm: passthru functions clear to send Jerry Hoemann
2017-06-30 16:09 ` [PATCH v4 2/6] acpi, nfit: Enable DSM pass thru for root functions Jerry Hoemann
2017-06-30 16:09 ` [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru Jerry Hoemann
2017-07-01 3:55 ` Dan Williams
2017-07-01 19:58 ` Jerry Hoemann
2017-07-01 20:08 ` Dan Williams
2017-07-01 20:10 ` Dan Williams
2017-07-01 20:38 ` Jerry Hoemann
2017-07-01 20:46 ` Dan Williams
2017-07-04 20:08 ` Jerry Hoemann
2017-07-04 20:37 ` Dan Williams
2017-07-05 15:26 ` Linda Knippers
2017-07-05 16:24 ` Jerry Hoemann
2017-07-05 16:35 ` Dan Williams
2017-07-05 23:14 ` Jerry Hoemann
2017-07-06 5:25 ` Dan Williams
2017-06-30 16:09 ` [PATCH v4 4/6] acpi, nfit: Show bus_dsm_mask in sysfs Jerry Hoemann
2017-06-30 16:09 ` [PATCH v4 5/6] libnvdimm: New ACPI 6.2 DSM functions Jerry Hoemann
2017-06-30 16:09 ` [PATCH v4 6/6] nfit allow override of root dsm mask Jerry Hoemann
2017-07-01 3:49 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4iR4T_umcF3H2aEGidmFMLUg4KSLmqMyoYvkOpbzn_YDQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).