* [PATCH] md: allow to set the fail_fast on RAID1/RAID10
@ 2021-09-13 3:20 Li Feng
2021-09-15 15:08 ` Li Feng
0 siblings, 1 reply; 6+ messages in thread
From: Li Feng @ 2021-09-13 3:20 UTC (permalink / raw)
To: Song Liu, linux-raid, linux-kernel; +Cc: Li Feng
When the running RAID1/RAID10 need to be set with the fail_fast flag,
we have to remove each device from RAID and re-add it again with the
--fail_fast flag.
Export the fail_fast flag to the userspace to support the read and
write.
Signed-off-by: Li Feng <fengli@smartx.com>
---
drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index ae8fe54ea358..ce63972a4555 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
static struct rdev_sysfs_entry rdev_ppl_size =
__ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
+static ssize_t
+fail_fast_show(struct md_rdev *rdev, char *page)
+{
+ return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
+}
+
+static ssize_t
+fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
+{
+ int ret;
+ bool bit;
+
+ ret = kstrtobool(buf, &bit);
+ if (ret)
+ return ret;
+
+ if (test_bit(FailFast, &rdev->flags) && !bit) {
+ clear_bit(FailFast, &rdev->flags);
+ md_update_sb(rdev->mddev, 1);
+ } else if (!test_bit(FailFast, &rdev->flags) && bit) {
+ set_bit(FailFast, &rdev->flags);
+ md_update_sb(rdev->mddev, 1);
+ }
+ return len;
+}
+
+static struct rdev_sysfs_entry rdev_fail_fast =
+__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
+
static struct attribute *rdev_default_attrs[] = {
&rdev_state.attr,
&rdev_errors.attr,
@@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
&rdev_unack_bad_blocks.attr,
&rdev_ppl_sector.attr,
&rdev_ppl_size.attr,
+ &rdev_fail_fast.attr,
NULL,
};
static ssize_t
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10
2021-09-13 3:20 [PATCH] md: allow to set the fail_fast on RAID1/RAID10 Li Feng
@ 2021-09-15 15:08 ` Li Feng
2021-09-27 13:24 ` Li Feng
0 siblings, 1 reply; 6+ messages in thread
From: Li Feng @ 2021-09-15 15:08 UTC (permalink / raw)
To: Song Liu, linux-raid, open list
ping ...
Thanks,
Feng Li
Li Feng <fengli@smartx.com> 于2021年9月13日周一 上午11:22写道：
>
> When the running RAID1/RAID10 need to be set with the fail_fast flag,
> we have to remove each device from RAID and re-add it again with the
> --fail_fast flag.
>
> Export the fail_fast flag to the userspace to support the read and
> write.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index ae8fe54ea358..ce63972a4555 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
> static struct rdev_sysfs_entry rdev_ppl_size =
> __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
>
> +static ssize_t
> +fail_fast_show(struct md_rdev *rdev, char *page)
> +{
> + return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
> +}
> +
> +static ssize_t
> +fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
> +{
> + int ret;
> + bool bit;
> +
> + ret = kstrtobool(buf, &bit);
> + if (ret)
> + return ret;
> +
> + if (test_bit(FailFast, &rdev->flags) && !bit) {
> + clear_bit(FailFast, &rdev->flags);
> + md_update_sb(rdev->mddev, 1);
> + } else if (!test_bit(FailFast, &rdev->flags) && bit) {
> + set_bit(FailFast, &rdev->flags);
> + md_update_sb(rdev->mddev, 1);
> + }
> + return len;
> +}
> +
> +static struct rdev_sysfs_entry rdev_fail_fast =
> +__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
> +
> static struct attribute *rdev_default_attrs[] = {
> &rdev_state.attr,
> &rdev_errors.attr,
> @@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
> &rdev_unack_bad_blocks.attr,
> &rdev_ppl_sector.attr,
> &rdev_ppl_size.attr,
> + &rdev_fail_fast.attr,
> NULL,
> };
> static ssize_t
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10
2021-09-15 15:08 ` Li Feng
@ 2021-09-27 13:24 ` Li Feng
2021-10-07 7:00 ` Li Feng
0 siblings, 1 reply; 6+ messages in thread
From: Li Feng @ 2021-09-27 13:24 UTC (permalink / raw)
To: Song Liu, linux-raid, open list
Hi Song,
What about this feature?
Thanks,
Feng Li
Li Feng <fengli@smartx.com> 于2021年9月15日周三 下午11:08写道：
>
> ping ...
>
> Thanks,
> Feng Li
>
> Li Feng <fengli@smartx.com> 于2021年9月13日周一 上午11:22写道：
> >
> > When the running RAID1/RAID10 need to be set with the fail_fast flag,
> > we have to remove each device from RAID and re-add it again with the
> > --fail_fast flag.
> >
> > Export the fail_fast flag to the userspace to support the read and
> > write.
> >
> > Signed-off-by: Li Feng <fengli@smartx.com>
> > ---
> > drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/drivers/md/md.c b/drivers/md/md.c
> > index ae8fe54ea358..ce63972a4555 100644
> > --- a/drivers/md/md.c
> > +++ b/drivers/md/md.c
> > @@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
> > static struct rdev_sysfs_entry rdev_ppl_size =
> > __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
> >
> > +static ssize_t
> > +fail_fast_show(struct md_rdev *rdev, char *page)
> > +{
> > + return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
> > +}
> > +
> > +static ssize_t
> > +fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
> > +{
> > + int ret;
> > + bool bit;
> > +
> > + ret = kstrtobool(buf, &bit);
> > + if (ret)
> > + return ret;
> > +
> > + if (test_bit(FailFast, &rdev->flags) && !bit) {
> > + clear_bit(FailFast, &rdev->flags);
> > + md_update_sb(rdev->mddev, 1);
> > + } else if (!test_bit(FailFast, &rdev->flags) && bit) {
> > + set_bit(FailFast, &rdev->flags);
> > + md_update_sb(rdev->mddev, 1);
> > + }
> > + return len;
> > +}
> > +
> > +static struct rdev_sysfs_entry rdev_fail_fast =
> > +__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
> > +
> > static struct attribute *rdev_default_attrs[] = {
> > &rdev_state.attr,
> > &rdev_errors.attr,
> > @@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
> > &rdev_unack_bad_blocks.attr,
> > &rdev_ppl_sector.attr,
> > &rdev_ppl_size.attr,
> > + &rdev_fail_fast.attr,
> > NULL,
> > };
> > static ssize_t
> > --
> > 2.31.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10
2021-09-27 13:24 ` Li Feng
@ 2021-10-07 7:00 ` Li Feng
2021-10-07 14:58 ` Song Liu
0 siblings, 1 reply; 6+ messages in thread
From: Li Feng @ 2021-10-07 7:00 UTC (permalink / raw)
To: Song Liu, linux-raid, open list
Continue ping...
Thanks,
Feng Li
Li Feng <fengli@smartx.com> 于2021年9月27日周一 下午9:24写道：
>
> Hi Song,
>
> What about this feature?
>
> Thanks,
> Feng Li
>
> Li Feng <fengli@smartx.com> 于2021年9月15日周三 下午11:08写道：
> >
> > ping ...
> >
> > Thanks,
> > Feng Li
> >
> > Li Feng <fengli@smartx.com> 于2021年9月13日周一 上午11:22写道：
> > >
> > > When the running RAID1/RAID10 need to be set with the fail_fast flag,
> > > we have to remove each device from RAID and re-add it again with the
> > > --fail_fast flag.
> > >
> > > Export the fail_fast flag to the userspace to support the read and
> > > write.
> > >
> > > Signed-off-by: Li Feng <fengli@smartx.com>
> > > ---
> > > drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
> > > 1 file changed, 30 insertions(+)
> > >
> > > diff --git a/drivers/md/md.c b/drivers/md/md.c
> > > index ae8fe54ea358..ce63972a4555 100644
> > > --- a/drivers/md/md.c
> > > +++ b/drivers/md/md.c
> > > @@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
> > > static struct rdev_sysfs_entry rdev_ppl_size =
> > > __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
> > >
> > > +static ssize_t
> > > +fail_fast_show(struct md_rdev *rdev, char *page)
> > > +{
> > > + return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
> > > +}
> > > +
> > > +static ssize_t
> > > +fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
> > > +{
> > > + int ret;
> > > + bool bit;
> > > +
> > > + ret = kstrtobool(buf, &bit);
> > > + if (ret)
> > > + return ret;
> > > +
> > > + if (test_bit(FailFast, &rdev->flags) && !bit) {
> > > + clear_bit(FailFast, &rdev->flags);
> > > + md_update_sb(rdev->mddev, 1);
> > > + } else if (!test_bit(FailFast, &rdev->flags) && bit) {
> > > + set_bit(FailFast, &rdev->flags);
> > > + md_update_sb(rdev->mddev, 1);
> > > + }
> > > + return len;
> > > +}
> > > +
> > > +static struct rdev_sysfs_entry rdev_fail_fast =
> > > +__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
> > > +
> > > static struct attribute *rdev_default_attrs[] = {
> > > &rdev_state.attr,
> > > &rdev_errors.attr,
> > > @@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
> > > &rdev_unack_bad_blocks.attr,
> > > &rdev_ppl_sector.attr,
> > > &rdev_ppl_size.attr,
> > > + &rdev_fail_fast.attr,
> > > NULL,
> > > };
> > > static ssize_t
> > > --
> > > 2.31.1
> > >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10
2021-10-07 7:00 ` Li Feng
@ 2021-10-07 14:58 ` Song Liu
2021-10-08 3:23 ` Li Feng
0 siblings, 1 reply; 6+ messages in thread
From: Song Liu @ 2021-10-07 14:58 UTC (permalink / raw)
To: Li Feng; +Cc: linux-raid, open list
On Thu, Oct 7, 2021 at 12:00 AM Li Feng <fengli@smartx.com> wrote:
>
> Continue ping...
>
> Thanks,
> Feng Li
Hmm.. this is weird. I didn't see previous emails in this thread.
Could you please
send it again?
Thanks,
Song
>
> Li Feng <fengli@smartx.com> 于2021年9月27日周一 下午9:24写道：
> >
> > Hi Song,
> >
> > What about this feature?
> >
> > Thanks,
> > Feng Li
> >
> > Li Feng <fengli@smartx.com> 于2021年9月15日周三 下午11:08写道：
> > >
> > > ping ...
> > >
> > > Thanks,
> > > Feng Li
> > >
> > > Li Feng <fengli@smartx.com> 于2021年9月13日周一 上午11:22写道：
> > > >
> > > > When the running RAID1/RAID10 need to be set with the fail_fast flag,
> > > > we have to remove each device from RAID and re-add it again with the
> > > > --fail_fast flag.
> > > >
> > > > Export the fail_fast flag to the userspace to support the read and
> > > > write.
> > > >
> > > > Signed-off-by: Li Feng <fengli@smartx.com>
> > > > ---
> > > > drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
> > > > 1 file changed, 30 insertions(+)
> > > >
> > > > diff --git a/drivers/md/md.c b/drivers/md/md.c
> > > > index ae8fe54ea358..ce63972a4555 100644
> > > > --- a/drivers/md/md.c
> > > > +++ b/drivers/md/md.c
> > > > @@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
> > > > static struct rdev_sysfs_entry rdev_ppl_size =
> > > > __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
> > > >
> > > > +static ssize_t
> > > > +fail_fast_show(struct md_rdev *rdev, char *page)
> > > > +{
> > > > + return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
> > > > +}
> > > > +
> > > > +static ssize_t
> > > > +fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
> > > > +{
> > > > + int ret;
> > > > + bool bit;
> > > > +
> > > > + ret = kstrtobool(buf, &bit);
> > > > + if (ret)
> > > > + return ret;
> > > > +
> > > > + if (test_bit(FailFast, &rdev->flags) && !bit) {
> > > > + clear_bit(FailFast, &rdev->flags);
> > > > + md_update_sb(rdev->mddev, 1);
> > > > + } else if (!test_bit(FailFast, &rdev->flags) && bit) {
> > > > + set_bit(FailFast, &rdev->flags);
> > > > + md_update_sb(rdev->mddev, 1);
> > > > + }
> > > > + return len;
> > > > +}
> > > > +
> > > > +static struct rdev_sysfs_entry rdev_fail_fast =
> > > > +__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
> > > > +
> > > > static struct attribute *rdev_default_attrs[] = {
> > > > &rdev_state.attr,
> > > > &rdev_errors.attr,
> > > > @@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
> > > > &rdev_unack_bad_blocks.attr,
> > > > &rdev_ppl_sector.attr,
> > > > &rdev_ppl_size.attr,
> > > > + &rdev_fail_fast.attr,
> > > > NULL,
> > > > };
> > > > static ssize_t
> > > > --
> > > > 2.31.1
> > > >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10
2021-10-07 14:58 ` Song Liu
@ 2021-10-08 3:23 ` Li Feng
0 siblings, 0 replies; 6+ messages in thread
From: Li Feng @ 2021-10-08 3:23 UTC (permalink / raw)
To: Song Liu; +Cc: linux-raid, open list
Done, thanks for responding.
Thanks,
Feng Li
Song Liu <song@kernel.org> 于2021年10月7日周四 下午10:59写道：
>
> On Thu, Oct 7, 2021 at 12:00 AM Li Feng <fengli@smartx.com> wrote:
> >
> > Continue ping...
> >
> > Thanks,
> > Feng Li
>
> Hmm.. this is weird. I didn't see previous emails in this thread.
> Could you please
> send it again?
>
> Thanks,
> Song
>
> >
> > Li Feng <fengli@smartx.com> 于2021年9月27日周一 下午9:24写道：
> > >
> > > Hi Song,
> > >
> > > What about this feature?
> > >
> > > Thanks,
> > > Feng Li
> > >
> > > Li Feng <fengli@smartx.com> 于2021年9月15日周三 下午11:08写道：
> > > >
> > > > ping ...
> > > >
> > > > Thanks,
> > > > Feng Li
> > > >
> > > > Li Feng <fengli@smartx.com> 于2021年9月13日周一 上午11:22写道：
> > > > >
> > > > > When the running RAID1/RAID10 need to be set with the fail_fast flag,
> > > > > we have to remove each device from RAID and re-add it again with the
> > > > > --fail_fast flag.
> > > > >
> > > > > Export the fail_fast flag to the userspace to support the read and
> > > > > write.
> > > > >
> > > > > Signed-off-by: Li Feng <fengli@smartx.com>
> > > > > ---
> > > > > drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
> > > > > 1 file changed, 30 insertions(+)
> > > > >
> > > > > diff --git a/drivers/md/md.c b/drivers/md/md.c
> > > > > index ae8fe54ea358..ce63972a4555 100644
> > > > > --- a/drivers/md/md.c
> > > > > +++ b/drivers/md/md.c
> > > > > @@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
> > > > > static struct rdev_sysfs_entry rdev_ppl_size =
> > > > > __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
> > > > >
> > > > > +static ssize_t
> > > > > +fail_fast_show(struct md_rdev *rdev, char *page)
> > > > > +{
> > > > > + return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
> > > > > +}
> > > > > +
> > > > > +static ssize_t
> > > > > +fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
> > > > > +{
> > > > > + int ret;
> > > > > + bool bit;
> > > > > +
> > > > > + ret = kstrtobool(buf, &bit);
> > > > > + if (ret)
> > > > > + return ret;
> > > > > +
> > > > > + if (test_bit(FailFast, &rdev->flags) && !bit) {
> > > > > + clear_bit(FailFast, &rdev->flags);
> > > > > + md_update_sb(rdev->mddev, 1);
> > > > > + } else if (!test_bit(FailFast, &rdev->flags) && bit) {
> > > > > + set_bit(FailFast, &rdev->flags);
> > > > > + md_update_sb(rdev->mddev, 1);
> > > > > + }
> > > > > + return len;
> > > > > +}
> > > > > +
> > > > > +static struct rdev_sysfs_entry rdev_fail_fast =
> > > > > +__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
> > > > > +
> > > > > static struct attribute *rdev_default_attrs[] = {
> > > > > &rdev_state.attr,
> > > > > &rdev_errors.attr,
> > > > > @@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
> > > > > &rdev_unack_bad_blocks.attr,
> > > > > &rdev_ppl_sector.attr,
> > > > > &rdev_ppl_size.attr,
> > > > > + &rdev_fail_fast.attr,
> > > > > NULL,
> > > > > };
> > > > > static ssize_t
> > > > > --
> > > > > 2.31.1
> > > > >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-08 3:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 3:20 [PATCH] md: allow to set the fail_fast on RAID1/RAID10 Li Feng
2021-09-15 15:08 ` Li Feng
2021-09-27 13:24 ` Li Feng
2021-10-07 7:00 ` Li Feng
2021-10-07 14:58 ` Song Liu
2021-10-08 3:23 ` Li Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).