From: "Roman Beranek" <romanberanek@icloud.com>
To: "Maxime Ripard" <maxime@cerno.tech>
Cc: "Chen-Yu Tsai" <wens@csie.org>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-sunxi@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG
Date: Tue, 21 Mar 2023 17:50:43 +0100 [thread overview]
Message-ID: <CRC7SQGZJDK0.3FEG3RZR6IR5U@iMac.local> (raw)
In-Reply-To: <20230321145646.w6kr7ddurfxpg5rt@houat>
Hello Maxime,
On Tue Mar 21, 2023 at 3:56 PM CET, Maxime Ripard wrote:
>
> This is similar to
> https://lore.kernel.org/all/20230319160704.9858-2-frank@oltmanns.dev/
>
> What's the story there?
Yes, Frank Oltmanns wrote me recently in relation to a patch I wrote
~ 3 years ago that addressed the framerate issue, proposing to
collaborate on pushing it upstream, however as I've been keeping up
with my inbox rather sporadically these days, by the time I read his
message, Frank had already taken the initiative and sent the patch.
So that's how we've got to this slightly awkward situation with two
patches on the same subject arriving 1 day apart of each other.
The problem with the original patch was that it went around
sun4i_dotclock by feeding it a rate adjusted such that the pll-mipi rate
was set correctly. I couldn't quite figure out at the time of how big
a portion of the tcon logic does the sun4i_dotclock code need to be made
aware of.
>Also, how was it tested/confirmed?
By counting Vblank interrupts (GIC 118).
Roman
next prev parent reply other threads:[~2023-03-21 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:16 [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG Roman Beranek
2023-03-21 14:56 ` Maxime Ripard
2023-03-21 16:50 ` Roman Beranek [this message]
2023-03-21 20:53 ` Roman Beranek
2023-03-27 20:21 ` Maxime Ripard
2023-03-25 11:40 ` Frank Oltmanns
2023-03-27 20:20 ` Maxime Ripard
2023-03-27 23:48 ` Roman Beranek
2023-03-29 19:58 ` Maxime Ripard
2023-03-30 4:45 ` Frank Oltmanns
2023-03-31 5:36 ` Roman Beranek
2023-04-05 12:34 ` Roman Beranek
2023-04-05 15:03 ` Maxime Ripard
2023-04-12 7:14 ` Roman Beranek
2023-04-12 14:09 ` Maxime Ripard
2023-04-08 7:07 ` Jernej Škrabec
2023-04-12 1:22 ` Roman Beranek
2023-03-28 19:28 ` Frank Oltmanns
2023-03-29 19:56 ` Maxime Ripard
2023-03-30 4:41 ` Frank Oltmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CRC7SQGZJDK0.3FEG3RZR6IR5U@iMac.local \
--to=romanberanek@icloud.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime@cerno.tech \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).