* [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.
@ 2017-06-26 23:31 Quytelda Kahja
2017-06-27 20:37 ` Kershner, David A
0 siblings, 1 reply; 2+ messages in thread
From: Quytelda Kahja @ 2017-06-26 23:31 UTC (permalink / raw)
To: david.kershner, gregkh, Timothy.Sell, david.binder
Cc: devel, linux-kernel, Quytelda Kahja
Replace the literal function name "create_bus_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index a692561c81c8..b6caa7a98692 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev)
err_debugfs_dir:
debugfs_remove_recursive(dev->debugfs_dir);
kfree(hdr_info);
- dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
+ dev_err(&dev->device, "%s failed: %d\n", __func__, err);
return err;
}
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.
2017-06-26 23:31 [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl Quytelda Kahja
@ 2017-06-27 20:37 ` Kershner, David A
0 siblings, 0 replies; 2+ messages in thread
From: Kershner, David A @ 2017-06-27 20:37 UTC (permalink / raw)
To: Quytelda Kahja, gregkh, Sell, Timothy C, Binder, David Anthony
Cc: devel, linux-kernel
> -----Original Message-----
> From: Quytelda Kahja [mailto:quytelda@tamalin.org]
> Sent: Monday, June 26, 2017 7:32 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com>;
> Binder, David Anthony <David.Binder@unisys.com>
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Quytelda
> Kahja <quytelda@tamalin.org>
> Subject: [PATCH] Staging: visorbus: Fix coding style warning from
> checkpatch.pl.
>
> Replace the literal function name "create_bus_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
>
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
I can't get this to apply to Greg's staging-next branch. It appears to be missing
at least patch:
commit 9e78fd35d staging: unisys: visorbus: renamed functions like *_bus_instance
to match driver namespace
Please update and send again.
Thanks,
David Kershner
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561c81c8..b6caa7a98692 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1032,7 +1032,7 @@ create_bus_instance(struct visor_device *dev)
> err_debugfs_dir:
> debugfs_remove_recursive(dev->debugfs_dir);
> kfree(hdr_info);
> - dev_err(&dev->device, "create_bus_instance failed: %d\n", err);
> + dev_err(&dev->device, "%s failed: %d\n", __func__, err);
> return err;
> }
>
> --
> 2.13.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-27 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-26 23:31 [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl Quytelda Kahja
2017-06-27 20:37 ` Kershner, David A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).