From: Pascal Schmidt <der.eremit@email.de>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix for ide-scsi crash
Date: Tue, 20 Jan 2004 15:59:09 +0100 [thread overview]
Message-ID: <E1AixLR-0000Hh-00@neptune.local> (raw)
In-Reply-To: <1g4Ao-60b-25@gated-at.bofh.it>
On Tue, 20 Jan 2004 15:00:16 +0100, you wrote in linux.kernel:
>> I'd really like the ATA cdrom driver to handle different sector sizes
>> properly. There really is no excuse for a block device driver to hardcode
>> its blocksize if it can avoid it.
>
> Agree, it's a bug. Pascal, care to take a stab at fixing it? You're the
> most avid ide-cd non-2kb block size user at the moment :)
There's a lot of macros related to sector sizes in ide-cd.h. I suppose
all that would need to be changed to depend on the real hardware sector
size?
I don't have any idea about block layer internals or about sending
commands to a drive.
In fact, I don't even know how to start or what uses of sector size
in ide-cd.c really need to be changed. Much less do I know where
information about hardware sector size could be gotten and how it should
be stored for use by ide-cd.
--
Ciao,
Pascal
next parent reply other threads:[~2004-01-20 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1fMNb-6UA-15@gated-at.bofh.it>
[not found] ` <1fYEB-pz-23@gated-at.bofh.it>
[not found] ` <1g4Ao-60b-25@gated-at.bofh.it>
2004-01-20 14:59 ` Pascal Schmidt [this message]
2004-01-20 19:04 ` [PATCH] fix for ide-scsi crash bill davidsen
2004-01-20 17:08 Pascal Schmidt
2004-01-20 20:01 ` Andries Brouwer
2004-01-20 20:58 ` Pascal Schmidt
-- strict thread matches above, loose matches on Subject: below --
2004-01-20 9:44 Andries.Brouwer
2004-01-20 12:04 ` Pascal Schmidt
2004-01-20 13:56 ` Jens Axboe
2004-01-20 17:56 ` Linus Torvalds
2004-01-20 18:46 ` Ben Pfaff
2004-01-19 22:56 Andries.Brouwer
2004-01-19 18:51 Pascal Schmidt
2004-01-20 7:32 ` Linus Torvalds
2004-01-20 13:54 ` Jens Axboe
2004-01-19 4:35 Andries.Brouwer
2004-01-19 22:35 ` Willem Riede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1AixLR-0000Hh-00@neptune.local \
--to=der.eremit@email.de \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).