From: Linus Torvalds <torvalds@osdl.org>
To: Andries.Brouwer@cwi.nl
Cc: der.eremit@email.de, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix for ide-scsi crash
Date: Tue, 20 Jan 2004 09:56:41 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0401200953470.2123@home.osdl.org> (raw)
In-Reply-To: <UTC200401200944.i0K9iRE25868.aeb@smtp.cwi.nl>
On Tue, 20 Jan 2004 Andries.Brouwer@cwi.nl wrote:
>
> If Andries wants to
> re-send the whitespace fixes, I can apply those too, but I hate applying
> patches like this where the whitespace fixes hide the real fix.
>
> Yes, it seems we presently have no good mechanism / policy here.
> Patches are noise. If some kernel version works and another doesnt,
> one has to look at the diffs. Whitespace-only diffs are bad,
> I would never submit them. They also needlessly invalidate existing patches.
Whitespace-only diffs can be very useful. In particular, they are common
when somebody starts working on a piece of code without a maintainer, and
the old code was terminally broken wrt whitespace. Happens quite often in
the driver world.
So I don't have any real issues with applying whitespace-only patches, and
I much prefer them to patches that mix whitespace and bugfixes. In
particular, if the whitespace fixes are preparation for some other
cleanup, it's usually a good idea.
(I agree that if the whitespace fix is just random, it's usually not worth
it).
Linus
next prev parent reply other threads:[~2004-01-20 17:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 9:44 [PATCH] fix for ide-scsi crash Andries.Brouwer
2004-01-20 12:04 ` Pascal Schmidt
2004-01-20 13:56 ` Jens Axboe
2004-01-20 17:56 ` Linus Torvalds [this message]
2004-01-20 18:46 ` Ben Pfaff
-- strict thread matches above, loose matches on Subject: below --
2004-01-20 17:08 Pascal Schmidt
2004-01-20 20:01 ` Andries Brouwer
2004-01-20 20:58 ` Pascal Schmidt
[not found] <1fMNb-6UA-15@gated-at.bofh.it>
[not found] ` <1fYEB-pz-23@gated-at.bofh.it>
[not found] ` <1g4Ao-60b-25@gated-at.bofh.it>
2004-01-20 14:59 ` Pascal Schmidt
2004-01-20 19:04 ` bill davidsen
2004-01-19 22:56 Andries.Brouwer
2004-01-19 18:51 Pascal Schmidt
2004-01-20 7:32 ` Linus Torvalds
2004-01-20 13:54 ` Jens Axboe
2004-01-19 4:35 Andries.Brouwer
2004-01-19 22:35 ` Willem Riede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0401200953470.2123@home.osdl.org \
--to=torvalds@osdl.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=der.eremit@email.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).