From: Avri Altman <Avri.Altman@wdc.com>
To: Can Guo <cang@codeaurora.org>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
"hongwus@codeaurora.org" <hongwus@codeaurora.org>,
"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kernel-team@android.com" <kernel-team@android.com>,
"saravanak@google.com" <saravanak@google.com>,
"salyzyn@google.com" <salyzyn@google.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bart Van Assche <bvanassche@acm.org>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
Tomas Winkler <tomas.winkler@intel.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: RE: [PATCH v7 5/8] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic
Date: Thu, 6 Feb 2020 10:28:16 +0000 [thread overview]
Message-ID: <MN2PR04MB6991346267CD619E823501F0FC1D0@MN2PR04MB6991.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1580978008-9327-6-git-send-email-cang@codeaurora.org>
Hi,
>
> The async version of ufshcd_hold(async == true), which is only called
> in queuecommand path as for now, is expected to work in atomic context,
> thus it should not sleep or schedule out. When it runs into the condition
> that clocks are ON but link is still in hibern8 state, it should bail out
> without flushing the clock ungate work.
Fixes: f2a785ac2312 (scsi: ufshcd: Fix race between clk scaling and ungate work)
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> Reviewed-by: Hongwu Su <hongwus@codeaurora.org>
> Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
> Reviewed-by: Bean Huo <beanhuo@micron.com>
> Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index bbc2607..e8f7f9d 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1518,6 +1518,11 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
> */
> if (ufshcd_can_hibern8_during_gating(hba) &&
> ufshcd_is_link_hibern8(hba)) {
> + if (async) {
> + rc = -EAGAIN;
> + hba->clk_gating.active_reqs--;
> + break;
> + }
> spin_unlock_irqrestore(hba->host->host_lock, flags);
> flush_work(&hba->clk_gating.ungate_work);
> spin_lock_irqsave(hba->host->host_lock, flags);
Since now the above code is shared in all cases,
Maybe find a more economical way to pack it?
Thanks,
Avri
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-02-06 10:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1580978008-9327-1-git-send-email-cang@codeaurora.org>
2020-02-06 8:33 ` [PATCH v7 1/8] scsi: ufs: Flush exception event before suspend Can Guo
2020-02-06 8:33 ` [PATCH v7 2/8] scsi: ufs: set load before setting voltage in regulators Can Guo
2020-02-06 8:33 ` [PATCH v7 3/8] scsi: ufs: Remove the check before call setup clock notify vops Can Guo
2020-02-06 8:33 ` [PATCH v7 4/8] scsi: ufs-qcom: Adjust bus bandwidth voting and unvoting Can Guo
2020-02-06 8:33 ` [PATCH v7 5/8] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Can Guo
2020-02-06 10:28 ` Avri Altman [this message]
2020-02-10 1:28 ` Can Guo
2020-02-10 1:59 ` Can Guo
2020-02-10 8:23 ` Avri Altman
2020-02-06 8:33 ` [PATCH v7 6/8] scsi: ufs: Add dev ref clock gating wait time support Can Guo
2020-02-06 8:33 ` [PATCH v7 7/8] scsi: ufs-qcom: Delay specific time before gate ref clk Can Guo
2020-02-06 20:33 ` Bjorn Andersson
2020-02-07 1:09 ` Can Guo
2020-02-07 2:10 ` Bjorn Andersson
2020-02-08 0:10 ` Can Guo
2020-02-06 8:33 ` [PATCH v7 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4 Can Guo
2020-02-06 13:20 ` Avri Altman
2020-02-07 2:56 ` Can Guo
2020-02-07 5:10 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR04MB6991346267CD619E823501F0FC1D0@MN2PR04MB6991.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).