* [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node
@ 2020-04-27 16:19 Lad Prabhakar
2020-04-27 19:59 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Lad Prabhakar @ 2020-04-27 16:19 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring
Cc: Lad Prabhakar, devicetree, linux-renesas-soc, linux-kernel,
Lad Prabhakar
Add missing compatible strings "renesas,rcar-gen2-iic" and
"renesas,rmobile-iic" to iic3 node of r8a7743 SoC.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm/boot/dts/r8a7743.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index e8b340b..d54cbfc 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -551,7 +551,9 @@
/* doesn't need pinmux */
#address-cells = <1>;
#size-cells = <0>;
- compatible = "renesas,iic-r8a7743";
+ compatible = "renesas,iic-r8a7743",
+ "renesas,rcar-gen2-iic",
+ "renesas,rmobile-iic";
reg = <0 0xe60b0000 0 0x425>;
interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 926>;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node
2020-04-27 16:19 [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node Lad Prabhakar
@ 2020-04-27 19:59 ` Geert Uytterhoeven
2020-04-27 21:43 ` Prabhakar Mahadev Lad
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-04-27 19:59 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Lad Prabhakar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Linux Kernel Mailing List
Hi Prabhakar,
On Mon, Apr 27, 2020 at 6:20 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Add missing compatible strings "renesas,rcar-gen2-iic" and
> "renesas,rmobile-iic" to iic3 node of r8a7743 SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -551,7 +551,9 @@
> /* doesn't need pinmux */
> #address-cells = <1>;
> #size-cells = <0>;
> - compatible = "renesas,iic-r8a7743";
> + compatible = "renesas,iic-r8a7743",
> + "renesas,rcar-gen2-iic",
> + "renesas,rmobile-iic";
> reg = <0 0xe60b0000 0 0x425>;
> interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 926>;
This was intentional, cfr. commit 072b817589b17660 ("ARM: dts: r8a7743:
Remove generic compatible string from iic3"), and my review comments on
"[PATCH 02/22] ARM: dts: r8a7744: Add I2C and IIC support"
(https://lore.kernel.org/linux-devicetree/CAMuHMdVt2DDQJ9Ud6i=GWAeWW0TdpF5xiCxtRiv0dZTGCPEt8A@mail.gmail.com/).
The note at the bottom of Section 45.1 of the RZ/G1 Hardware User's
Manual says: "Automatic transmission for PMIC control (DVFS) is not
available ...".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node
2020-04-27 19:59 ` Geert Uytterhoeven
@ 2020-04-27 21:43 ` Prabhakar Mahadev Lad
0 siblings, 0 replies; 3+ messages in thread
From: Prabhakar Mahadev Lad @ 2020-04-27 21:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring, Lad Prabhakar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Linux Kernel Mailing List
Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 27 April 2020 21:00
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; Rob Herring <robh+dt@kernel.org>;
> Lad Prabhakar <prabhakar.csengg@gmail.com>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; Linux Kernel Mailing List <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node
>
> Hi Prabhakar,
>
> On Mon, Apr 27, 2020 at 6:20 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > Add missing compatible strings "renesas,rcar-gen2-iic" and
> > "renesas,rmobile-iic" to iic3 node of r8a7743 SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -551,7 +551,9 @@
> > /* doesn't need pinmux */
> > #address-cells = <1>;
> > #size-cells = <0>;
> > - compatible = "renesas,iic-r8a7743";
> > + compatible = "renesas,iic-r8a7743",
> > + "renesas,rcar-gen2-iic",
> > + "renesas,rmobile-iic";
> > reg = <0 0xe60b0000 0 0x425>;
> > interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&cpg CPG_MOD 926>;
>
> This was intentional, cfr. commit 072b817589b17660 ("ARM: dts: r8a7743:
> Remove generic compatible string from iic3"), and my review comments on
> "[PATCH 02/22] ARM: dts: r8a7744: Add I2C and IIC support"
> (https://lore.kernel.org/linux-devicetree/CAMuHMdVt2DDQJ9Ud6i=GWAeWW0TdpF5xiCxtRiv0dZTGCPEt8A@mail.gmail.com/).
>
> The note at the bottom of Section 45.1 of the RZ/G1 Hardware User's
> Manual says: "Automatic transmission for PMIC control (DVFS) is not
> available ...".
>
Completely missed that, thank you for pointing it out.
Cheers,
--Prabhakar
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-27 21:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 16:19 [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node Lad Prabhakar
2020-04-27 19:59 ` Geert Uytterhoeven
2020-04-27 21:43 ` Prabhakar Mahadev Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).