From: Long Li <longli@microsoft.com>
To: Cheng Xu <chengyou@linux.alibaba.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
Ajay Sharma <sharmaajay@microsoft.com>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter
Date: Thu, 21 Jul 2022 18:01:33 +0000 [thread overview]
Message-ID: <PH7PR21MB326345CED09A427C7309715DCE919@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <f030aeab-b503-8381-53f5-15862e1333b0@linux.alibaba.com>
> Subject: Re: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft
> Azure Network Adapter
>
>
>
> On 6/16/22 10:07 AM, longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
>
> <...>
>
> > +
> > +static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd,
> > + struct ib_qp_init_attr *attr,
> > + struct ib_udata *udata)
> > +{
> > + struct mana_ib_pd *pd = container_of(ibpd, struct mana_ib_pd,
> ibpd);
> > + struct mana_ib_qp *qp = container_of(ibqp, struct mana_ib_qp,
> ibqp);
> > + struct mana_ib_dev *mdev =
> > + container_of(ibpd->device, struct mana_ib_dev, ib_dev);
> > + struct mana_ib_cq *send_cq =
> > + container_of(attr->send_cq, struct mana_ib_cq, ibcq);
> > + struct ib_ucontext *ib_ucontext = ibpd->uobject->context;
> > + struct mana_ib_create_qp_resp resp = {};
> > + struct mana_ib_ucontext *mana_ucontext;
> > + struct gdma_dev *gd = mdev->gdma_dev;
> > + struct mana_ib_create_qp ucmd = {};
> > + struct mana_obj_spec wq_spec = {};
> > + struct mana_obj_spec cq_spec = {};
> > + struct mana_port_context *mpc;
> > + struct mana_context *mc;
> > + struct net_device *ndev;
> > + struct ib_umem *umem;
> > + int err;
> > + u32 port;
> > +
> > + mana_ucontext =
> > + container_of(ib_ucontext, struct mana_ib_ucontext,
> ibucontext);
> > + mc = gd->driver_data;
> > +
> > + if (udata->inlen < sizeof(ucmd))
> > + return -EINVAL;
> > +
> > + err = ib_copy_from_udata(&ucmd, udata, min(sizeof(ucmd), udata-
> >inlen));
> > + if (err) {
> > + ibdev_dbg(&mdev->ib_dev,
> > + "Failed to copy from udata create qp-raw, %d\n",
> err);
> > + return -EFAULT;
> > + }
> > +
> > + /* IB ports start with 1, MANA Ethernet ports start with 0 */
> > + port = ucmd.port;
> > + if (ucmd.port > mc->num_ports)
> > + return -EINVAL;
> > +
> > + if (attr->cap.max_send_wr > MAX_SEND_BUFFERS_PER_QUEUE) {
> > + ibdev_dbg(&mdev->ib_dev,
> > + "Requested max_send_wr %d exceeding limit\n",
> > + attr->cap.max_send_wr);
> > + return -EINVAL;
> > + }
> > +
> > + if (attr->cap.max_send_sge > MAX_TX_WQE_SGL_ENTRIES) {
> > + ibdev_dbg(&mdev->ib_dev,
> > + "Requested max_send_sge %d exceeding limit\n",
> > + attr->cap.max_send_sge);
> > + return -EINVAL;
> > + }
> > +
> > + ndev = mc->ports[port - 1];
> > + mpc = netdev_priv(ndev);
> > + ibdev_dbg(&mdev->ib_dev, "port %u ndev %p mpc %p\n", port,
> ndev, mpc);
> > +
> > + err = mana_ib_cfg_vport(mdev, port - 1, pd, mana_ucontext-
> >doorbell);
> > + if (err)
> > + return -ENODEV;
> > +
> > + qp->port = port;
> > +
> > + ibdev_dbg(&mdev->ib_dev, "ucmd sq_buf_addr 0x%llx port %u\n",
> > + ucmd.sq_buf_addr, ucmd.port);
> > +
> > + umem = ib_umem_get(ibpd->device, ucmd.sq_buf_addr,
> ucmd.sq_buf_size,
> > + IB_ACCESS_LOCAL_WRITE);
> > + if (IS_ERR(umem)) {
> > + err = PTR_ERR(umem);
> > + ibdev_dbg(&mdev->ib_dev,
> > + "Failed to get umem for create qp-raw, err %d\n",
> > + err);
> > + goto err_free_vport;
> > + }
> > + qp->sq_umem = umem;
> > +
> > + err = mana_ib_gd_create_dma_region(mdev, qp->sq_umem,
> > + &qp->sq_gdma_region, PAGE_SIZE);
> > + if (err) {
> > + ibdev_err(&mdev->ib_dev,
> > + "Failed to create dma region for create qp-
> raw, %d\n",
> > + err);
>
> It is better not print in userspace-triggered paths.
>
> There are also same issues in other paths.
>
> Thanks,
> Cheng Xu
Thank you, I will scan the code and make sure user-mode can't flood error messages.
This error is a hardware/PF error. It means the hardware channel has faulted. It's logged at error level.
Long
prev parent reply other threads:[~2022-07-21 18:01 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 2:07 [Patch v4 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver longli
2022-06-16 2:07 ` [Patch v4 01/12] net: mana: Add support for auxiliary device longli
2022-07-11 1:08 ` Dexuan Cui
2022-07-12 18:26 ` Long Li
2022-06-16 2:07 ` [Patch v4 02/12] net: mana: Record the physical address for doorbell page region longli
2022-07-11 1:09 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 03/12] net: mana: Handle vport sharing between devices longli
2022-07-11 1:13 ` Dexuan Cui
2022-07-12 18:48 ` Long Li
2022-07-20 23:42 ` Jason Gunthorpe
2022-07-21 0:06 ` Long Li
2022-07-21 14:38 ` Jason Gunthorpe
2022-07-21 17:58 ` Long Li
2022-07-21 18:32 ` Jason Gunthorpe
2022-07-29 18:44 ` Long Li
2022-07-29 19:12 ` Jason Gunthorpe
2022-07-29 21:20 ` Long Li
2022-08-02 18:08 ` Jason Gunthorpe
2022-08-03 2:08 ` Long Li
2022-06-16 2:07 ` [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA longli
2022-07-11 1:13 ` Dexuan Cui
2022-07-12 18:48 ` Long Li
2022-07-20 23:42 ` Jason Gunthorpe
2022-06-16 2:07 ` [Patch v4 05/12] net: mana: Set the DMA device max segment size longli
2022-07-11 1:14 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration longli
2022-07-11 1:29 ` Dexuan Cui
2022-07-13 4:39 ` Ajay Sharma
2022-07-13 7:22 ` Dexuan Cui
2022-07-20 23:43 ` Jason Gunthorpe
2022-07-21 0:15 ` Long Li
2022-06-16 2:07 ` [Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver longli
2022-07-11 1:31 ` Dexuan Cui
2022-07-12 18:54 ` Long Li
2022-06-16 2:07 ` [Patch v4 08/12] net: mana: Record port number in netdev longli
2022-07-11 1:31 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 09/12] net: mana: Move header files to a common location longli
2022-07-11 1:32 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 10/12] net: mana: Define max values for SGL entries longli
2022-07-11 1:32 ` Dexuan Cui
2022-07-12 18:56 ` Long Li
2022-06-16 2:07 ` [Patch v4 11/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES longli
2022-07-11 1:32 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter longli
2022-06-25 4:20 ` [EXTERNAL] " Ajay Sharma
2022-06-26 0:03 ` Jason Gunthorpe
2022-07-11 1:42 ` Dexuan Cui
2022-07-13 4:32 ` Ajay Sharma
2022-07-13 7:36 ` Dexuan Cui
2022-07-12 19:14 ` Greg KH
2022-07-12 23:46 ` Long Li
2022-07-13 6:14 ` Greg KH
2022-07-20 23:49 ` Jason Gunthorpe
2022-07-21 19:24 ` [EXTERNAL] " Ajay Sharma
2022-07-21 9:17 ` Cheng Xu
2022-07-21 18:01 ` Long Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB326345CED09A427C7309715DCE919@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=chengyou@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=shiraz.saleem@intel.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).