From: Dexuan Cui <decui@microsoft.com>
To: Long Li <longli@microsoft.com>, KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
Ajay Sharma <sharmaajay@microsoft.com>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter
Date: Mon, 11 Jul 2022 01:42:41 +0000 [thread overview]
Message-ID: <SN6PR2101MB1327827B0EA68876717F0699BF879@SN6PR2101MB1327.namprd21.prod.outlook.com> (raw)
In-Reply-To: <1655345240-26411-13-git-send-email-longli@linuxonhyperv.com>
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com>
> Sent: Wednesday, June 15, 2022 7:07 PM
> ...
> +int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct
> ib_umem *umem,
> + mana_handle_t *gdma_region, u64 page_sz)
> +{
> + ...
> + err = mana_gd_send_request(gc, create_req_msg_size, create_req,
> + sizeof(create_resp), &create_resp);
> + kfree(create_req);
> +
> + if (err || create_resp.hdr.status) {
> + ibdev_err(&dev->ib_dev,
> + "Failed to create DMA region: %d, 0x%x\n", err,
> + create_resp.hdr.status);
if (!err)
err = -EPROTO;
> + goto error;
> + }
> + ...
> + err = mana_gd_send_request(gc, add_req_msg_size,
> + add_req, sizeof(add_resp),
> + &add_resp);
> + if (!err || add_resp.hdr.status != expected_status) {
> + ibdev_err(&dev->ib_dev,
> + "Failed put DMA pages %u: %d,0x%x\n",
> + i, err, add_resp.hdr.status);
> + err = -EPROTO;
Should we try to undo what has been done by calling GDMA_DESTROY_DMA_REGION?
> + goto free_req;
> + }
> +
> + num_pages_cur += num_pages_to_handle;
> + num_pages_to_handle =
> + min_t(size_t, num_pages_total - num_pages_cur,
> + max_pgs_add_cmd);
> + add_req_msg_size = sizeof(*add_req) +
> + num_pages_to_handle * sizeof(u64);
> + }
> +free_req:
> + kfree(add_req);
> + }
> +
> +error:
> + return err;
> +}
> + ...
> +int mana_ib_gd_create_mr(struct mana_ib_dev *dev, struct mana_ib_mr
> *mr,
> + struct gdma_create_mr_params *mr_params)
> +{
> + struct gdma_create_mr_response resp = {};
> + struct gdma_create_mr_request req = {};
> + struct gdma_dev *mdev = dev->gdma_dev;
> + struct gdma_context *gc;
> + int err;
> +
> + gc = mdev->gdma_context;
> +
> + mana_gd_init_req_hdr(&req.hdr, GDMA_CREATE_MR, sizeof(req),
> + sizeof(resp));
> + req.pd_handle = mr_params->pd_handle;
> +
> + switch (mr_params->mr_type) {
> + case GDMA_MR_TYPE_GVA:
> + req.mr_type = GDMA_MR_TYPE_GVA;
> + req.gva.dma_region_handle = mr_params->gva.dma_region_handle;
> + req.gva.virtual_address = mr_params->gva.virtual_address;
> + req.gva.access_flags = mr_params->gva.access_flags;
> + break;
> +
> + case GDMA_MR_TYPE_GPA:
> + req.mr_type = GDMA_MR_TYPE_GPA;
> + req.gpa.access_flags = mr_params->gpa.access_flags;
> + break;
> +
> + case GDMA_MR_TYPE_FMR:
> + req.mr_type = GDMA_MR_TYPE_FMR;
> + req.fmr.page_size = mr_params->fmr.page_size;
> + req.fmr.reserved_pte_count = mr_params->fmr.reserved_pte_count;
> + break;
> +
> + default:
> + ibdev_dbg(&dev->ib_dev,
> + "invalid param (GDMA_MR_TYPE) passed, type %d\n",
> + req.mr_type);
Here req.mr_type is always 0.
We should remove the 3 above lines of "req.mr_type = ...", and
add a line "req.mr_type = mr_params->mr_type;" before the "switch" line..
> + err = -EINVAL;
> + goto error;
> + }
> +
> + err = mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp), &resp);
> +
> + if (err || resp.hdr.status) {
> + ibdev_err(&dev->ib_dev, "Failed to create mr %d, %u", err,
> + resp.hdr.status);
if (!err)
err = -EPROTO;
> + goto error;
> + }
> +
> + mr->ibmr.lkey = resp.lkey;
> + mr->ibmr.rkey = resp.rkey;
> + mr->mr_handle = resp.mr_handle;
> +
> + return 0;
> +error:
> + return err;
> +}
> + ...
> +static int mana_ib_probe(struct auxiliary_device *adev,
> + const struct auxiliary_device_id *id)
> +{
> + struct mana_adev *madev = container_of(adev, struct mana_adev, adev);
> + struct gdma_dev *mdev = madev->mdev;
> + struct mana_context *mc;
> + struct mana_ib_dev *dev;
> + int ret = 0;
No need to initialize 'ret' to 0.
> +int mana_ib_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata)
> +{
> + struct mana_ib_mr *mr = container_of(ibmr, struct mana_ib_mr, ibmr);
> + struct ib_device *ibdev = ibmr->device;
> + struct mana_ib_dev *dev;
> + int err;
> +
> + dev = container_of(ibdev, struct mana_ib_dev, ib_dev);
> +
> + err = mana_ib_gd_destroy_mr(dev, mr->mr_handle);
> + if (err)
Should we return here without calling ib_umem_release() and kfree(mr)?
> + return err;
> +
> + if (mr->umem)
> + ib_umem_release(mr->umem);
> +
> + kfree(mr);
> +
> + return 0;
> +}
next prev parent reply other threads:[~2022-07-11 1:42 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 2:07 [Patch v4 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver longli
2022-06-16 2:07 ` [Patch v4 01/12] net: mana: Add support for auxiliary device longli
2022-07-11 1:08 ` Dexuan Cui
2022-07-12 18:26 ` Long Li
2022-06-16 2:07 ` [Patch v4 02/12] net: mana: Record the physical address for doorbell page region longli
2022-07-11 1:09 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 03/12] net: mana: Handle vport sharing between devices longli
2022-07-11 1:13 ` Dexuan Cui
2022-07-12 18:48 ` Long Li
2022-07-20 23:42 ` Jason Gunthorpe
2022-07-21 0:06 ` Long Li
2022-07-21 14:38 ` Jason Gunthorpe
2022-07-21 17:58 ` Long Li
2022-07-21 18:32 ` Jason Gunthorpe
2022-07-29 18:44 ` Long Li
2022-07-29 19:12 ` Jason Gunthorpe
2022-07-29 21:20 ` Long Li
2022-08-02 18:08 ` Jason Gunthorpe
2022-08-03 2:08 ` Long Li
2022-06-16 2:07 ` [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA longli
2022-07-11 1:13 ` Dexuan Cui
2022-07-12 18:48 ` Long Li
2022-07-20 23:42 ` Jason Gunthorpe
2022-06-16 2:07 ` [Patch v4 05/12] net: mana: Set the DMA device max segment size longli
2022-07-11 1:14 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration longli
2022-07-11 1:29 ` Dexuan Cui
2022-07-13 4:39 ` Ajay Sharma
2022-07-13 7:22 ` Dexuan Cui
2022-07-20 23:43 ` Jason Gunthorpe
2022-07-21 0:15 ` Long Li
2022-06-16 2:07 ` [Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver longli
2022-07-11 1:31 ` Dexuan Cui
2022-07-12 18:54 ` Long Li
2022-06-16 2:07 ` [Patch v4 08/12] net: mana: Record port number in netdev longli
2022-07-11 1:31 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 09/12] net: mana: Move header files to a common location longli
2022-07-11 1:32 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 10/12] net: mana: Define max values for SGL entries longli
2022-07-11 1:32 ` Dexuan Cui
2022-07-12 18:56 ` Long Li
2022-06-16 2:07 ` [Patch v4 11/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES longli
2022-07-11 1:32 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter longli
2022-06-25 4:20 ` [EXTERNAL] " Ajay Sharma
2022-06-26 0:03 ` Jason Gunthorpe
2022-07-11 1:42 ` Dexuan Cui [this message]
2022-07-13 4:32 ` Ajay Sharma
2022-07-13 7:36 ` Dexuan Cui
2022-07-12 19:14 ` Greg KH
2022-07-12 23:46 ` Long Li
2022-07-13 6:14 ` Greg KH
2022-07-20 23:49 ` Jason Gunthorpe
2022-07-21 19:24 ` [EXTERNAL] " Ajay Sharma
2022-07-21 9:17 ` Cheng Xu
2022-07-21 18:01 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR2101MB1327827B0EA68876717F0699BF879@SN6PR2101MB1327.namprd21.prod.outlook.com \
--to=decui@microsoft.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=shiraz.saleem@intel.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).