From: Dexuan Cui <decui@microsoft.com>
To: Long Li <longli@microsoft.com>, KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
Ajay Sharma <sharmaajay@microsoft.com>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: RE: [Patch v4 03/12] net: mana: Handle vport sharing between devices
Date: Mon, 11 Jul 2022 01:13:35 +0000 [thread overview]
Message-ID: <SN6PR2101MB13272044B91D6E37F7F5124FBF879@SN6PR2101MB1327.namprd21.prod.outlook.com> (raw)
In-Reply-To: <1655345240-26411-4-git-send-email-longli@linuxonhyperv.com>
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com>
> Sent: Wednesday, June 15, 2022 7:07 PM
> +void mana_uncfg_vport(struct mana_port_context *apc)
> +{
> + mutex_lock(&apc->vport_mutex);
> + apc->vport_use_count--;
> + WARN_ON(apc->vport_use_count < 0);
> + mutex_unlock(&apc->vport_mutex);
> +}
> +EXPORT_SYMBOL_GPL(mana_uncfg_vport);
> +
> +int mana_cfg_vport(struct mana_port_context *apc, u32 protection_dom_id,
> + u32 doorbell_pg_id)
> {
> struct mana_config_vport_resp resp = {};
> struct mana_config_vport_req req = {};
> int err;
>
> + /* Ethernet driver and IB driver can't take the port at the same time */
> + mutex_lock(&apc->vport_mutex);
> + if (apc->vport_use_count > 0) {
> + mutex_unlock(&apc->vport_mutex);
> + return -ENODEV;
Maybe -EBUSY is better?
> @@ -563,9 +581,19 @@ static int mana_cfg_vport(struct mana_port_context
> *apc, u32 protection_dom_id,
>
> apc->tx_shortform_allowed = resp.short_form_allowed;
> apc->tx_vp_offset = resp.tx_vport_offset;
> +
> + netdev_info(apc->ndev, "Configured vPort %llu PD %u DB %u\n",
> + apc->port_handle, protection_dom_id, doorbell_pg_id);
Should this be netdev_dbg()?
The log buffer can be flooded if there are many vPorts per VF PCI device and
there are a lot of VFs.
> out:
> + if (err) {
> + mutex_lock(&apc->vport_mutex);
> + apc->vport_use_count--;
> + mutex_unlock(&apc->vport_mutex);
> + }
Change this to the blelow?
if (err)
mana_uncfg_vport(apc);
> @@ -626,6 +654,9 @@ static int mana_cfg_vport_steering(struct
> mana_port_context *apc,
> resp.hdr.status);
> err = -EPROTO;
> }
> +
> + netdev_info(ndev, "Configured steering vPort %llu entries %u\n",
> + apc->port_handle, num_entries);
netdev_dbg()?
In general, the patch looks good to me.
Reviewed-by: Dexuan Cui <decui@microsoft.com>
next prev parent reply other threads:[~2022-07-11 1:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 2:07 [Patch v4 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver longli
2022-06-16 2:07 ` [Patch v4 01/12] net: mana: Add support for auxiliary device longli
2022-07-11 1:08 ` Dexuan Cui
2022-07-12 18:26 ` Long Li
2022-06-16 2:07 ` [Patch v4 02/12] net: mana: Record the physical address for doorbell page region longli
2022-07-11 1:09 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 03/12] net: mana: Handle vport sharing between devices longli
2022-07-11 1:13 ` Dexuan Cui [this message]
2022-07-12 18:48 ` Long Li
2022-07-20 23:42 ` Jason Gunthorpe
2022-07-21 0:06 ` Long Li
2022-07-21 14:38 ` Jason Gunthorpe
2022-07-21 17:58 ` Long Li
2022-07-21 18:32 ` Jason Gunthorpe
2022-07-29 18:44 ` Long Li
2022-07-29 19:12 ` Jason Gunthorpe
2022-07-29 21:20 ` Long Li
2022-08-02 18:08 ` Jason Gunthorpe
2022-08-03 2:08 ` Long Li
2022-06-16 2:07 ` [Patch v4 04/12] net: mana: Add functions for allocating doorbell page from GDMA longli
2022-07-11 1:13 ` Dexuan Cui
2022-07-12 18:48 ` Long Li
2022-07-20 23:42 ` Jason Gunthorpe
2022-06-16 2:07 ` [Patch v4 05/12] net: mana: Set the DMA device max segment size longli
2022-07-11 1:14 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 06/12] net: mana: Define data structures for protection domain and memory registration longli
2022-07-11 1:29 ` Dexuan Cui
2022-07-13 4:39 ` Ajay Sharma
2022-07-13 7:22 ` Dexuan Cui
2022-07-20 23:43 ` Jason Gunthorpe
2022-07-21 0:15 ` Long Li
2022-06-16 2:07 ` [Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver longli
2022-07-11 1:31 ` Dexuan Cui
2022-07-12 18:54 ` Long Li
2022-06-16 2:07 ` [Patch v4 08/12] net: mana: Record port number in netdev longli
2022-07-11 1:31 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 09/12] net: mana: Move header files to a common location longli
2022-07-11 1:32 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 10/12] net: mana: Define max values for SGL entries longli
2022-07-11 1:32 ` Dexuan Cui
2022-07-12 18:56 ` Long Li
2022-06-16 2:07 ` [Patch v4 11/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES longli
2022-07-11 1:32 ` Dexuan Cui
2022-06-16 2:07 ` [Patch v4 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter longli
2022-06-25 4:20 ` [EXTERNAL] " Ajay Sharma
2022-06-26 0:03 ` Jason Gunthorpe
2022-07-11 1:42 ` Dexuan Cui
2022-07-13 4:32 ` Ajay Sharma
2022-07-13 7:36 ` Dexuan Cui
2022-07-12 19:14 ` Greg KH
2022-07-12 23:46 ` Long Li
2022-07-13 6:14 ` Greg KH
2022-07-20 23:49 ` Jason Gunthorpe
2022-07-21 19:24 ` [EXTERNAL] " Ajay Sharma
2022-07-21 9:17 ` Cheng Xu
2022-07-21 18:01 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR2101MB13272044B91D6E37F7F5124FBF879@SN6PR2101MB1327.namprd21.prod.outlook.com \
--to=decui@microsoft.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=shiraz.saleem@intel.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).