Re: [PATCH] removal of "static foo = 0"

From: Alexander Viro <viro@math.psu.edu>
To: Elmer Joandi <elmer@ylenurme.ee>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] removal of "static foo = 0"
Date: Sun, 26 Nov 2000 13:36:28 -0500 (EST)	[thread overview]
Message-ID: <Pine.GSO.4.21.0011261321580.3258-100000@weyl.math.psu.edu> (raw)
In-Reply-To: <Pine.LNX.4.10.10011261942420.11180-100000@yle-server.ylenurme.sise>

On Sun, 26 Nov 2000, Elmer Joandi wrote:

> 
> Kernel has become so big that it really needs universal  debugging macros
> instead of comments. Comments are waste of brain&fingerpower, if the same
> can be explained by long variable names and debug macros.
> 
> static Subsystem_module_LocalVariableForThisPurpose;
> 
> int Subsytem_module_function_this_and_that(){
> 	DEBUG_ASSERT( Subsystem_module_LocalVariableForThisPurpose  == 0 );
> 	DEBUG_ASSERT(MOST_OF_TIME,FS_AREA,MYFS_MODULE, somethingaboutIndodes->node != NULL )
> }

I would suggest you to read through the following book and files:
	* Kernighan & Pike, "The Practice of Programming"
	* Documentation/CodingStyle
	* drivers/net/aironet4500_proc.c
and consider, erm, discrepancies. On the second thought, reading K&R
might also be useful. IOW, no offense, but your C is bad beyond belief.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/