From: Alan Stern <stern@rowland.harvard.edu>
To: Lin Ming <ming.m.lin@intel.com>
Cc: linux-kernel@vger.kernel.org, <linux-ide@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <linux-pm@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <JBottomley@parallels.com>,
Tejun Heo <tj@kernel.org>, Huang Ying <ying.huang@intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v3 3/6] [SCSI] runtime resume device before system suspend
Date: Wed, 23 Nov 2011 12:02:39 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1111231149300.2111-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1322031686-28233-4-git-send-email-ming.m.lin@intel.com>
On Wed, 23 Nov 2011, Lin Ming wrote:
> From: Alan Stern <stern@rowland.harvard.edu>
>
> scsi device runtime PM is using PMSG_SUSPEND. System PM may use other state
> that may not be compatiable with PMSG_SUSPEND.
Actually SCSI runtime PM uses PMSG_AUTO_AUTOSUSPEND, which is the same
as PMSG_SUSPEND except that the PM_EVENT_AUTO bit is also set in the
pm_message.event field. Currently they _are_ compatible.
> So we need to runtime resume the device before system suspend.
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
>
> Alan,
>
> Could you add your Signed-off-by?
> Free free to change the commit logs.
I don't know; this is a little questionable.
The point of this patch is to handle drivers that do different things
for runtime suspend and system sleep. The only SCSI driver that
currently supports runtime suspend is sd, and it treats runtime suspend
the same as system sleep. (Earlier I said it doesn't spin down disks
for runtime suspend -- that was wrong, it does. It skips the spin-down
step only for PM_EVENT_FREEZE, which is part of the hibernation
procedure.)
Until other SCSI drivers support runtime suspend, this patch shouldn't
be needed. And spinning up runtime-suspended disks could add a lengthy
delay to the system sleep transition, so it's better not to do this if
at all possible.
Alan Stern
> drivers/scsi/scsi_pm.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
> index d329f8b..549ea72 100644
> --- a/drivers/scsi/scsi_pm.c
> +++ b/drivers/scsi/scsi_pm.c
> @@ -49,8 +49,10 @@ static int scsi_bus_suspend_common(struct device *dev, pm_message_t msg)
> {
> int err = 0;
>
> - if (scsi_is_sdev_device(dev))
> + if (scsi_is_sdev_device(dev)) {
> + pm_runtime_resume(dev);
> err = scsi_dev_type_suspend(dev, msg);
> + }
> return err;
> }
next prev parent reply other threads:[~2011-11-23 17:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 7:01 [PATCH v3 0/6] ata port runtime power management support Lin Ming
2011-11-23 7:01 ` [PATCH v3 1/6] ata: make ata port as parent device of scsi host Lin Ming
2011-11-23 7:01 ` [PATCH v3 2/6] scsi: add flag to skip the runtime PM calls on the host Lin Ming
2011-11-23 7:01 ` [PATCH v3 3/6] [SCSI] runtime resume device before system suspend Lin Ming
2011-11-23 17:02 ` Alan Stern [this message]
2011-11-24 12:21 ` Lin Ming
2011-11-24 16:36 ` Alan Stern
2011-11-24 19:57 ` Tejun Heo
2011-11-24 22:54 ` Alan Stern
2011-11-24 23:01 ` Tejun Heo
2011-11-25 0:17 ` Alan Stern
2011-11-25 13:50 ` Lin Ming
2011-11-25 15:19 ` Alan Stern
2011-11-23 7:01 ` [PATCH v3 4/6] [SCSI] sd: check runtime status in sd_shutdown Lin Ming
2011-11-23 7:01 ` [PATCH v3 5/6] ata: add ata port system PM callbacks Lin Ming
2011-11-23 7:01 ` [PATCH v3 6/6] ata: add ata port runtime " Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1111231149300.2111-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=JBottomley@parallels.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=tj@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).