From: Alan Stern <stern@rowland.harvard.edu>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Tejun Heo <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <JBottomley@parallels.com>,
"Huang, Ying" <ying.huang@intel.com>,
"Zhang, Rui" <rui.zhang@intel.com>
Subject: Re: [PATCH v3 3/6] [SCSI] runtime resume device before system suspend
Date: Fri, 25 Nov 2011 10:19:58 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1111251018560.1951-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1322229039.4246.8.camel@hp6530s>
On Fri, 25 Nov 2011, Lin Ming wrote:
> Below is the updated patch with your suggested patch description and
> comments.
>
> Looks OK?
>
> Subject: [PATCH] [SCSI] check runtime PM status in system PM
>
> The only high-level SCSI driver that currently implements runtime PM is
> sd, and sd treats runtime suspend exactly the same as the SUSPEND and
> HIBERNATE stages of system sleep, but not the same as the FREEZE stage.
>
> Therefore, when entering the SUSPEND or HIBERNATE stages of system
> sleep, we can skip the callback to the driver if the device is already
> in runtime suspend. When entering the FREEZE stage, however, we should
> first issue a runtime resume. The overhead of doing this is
> negligible, because a suspended drive would be spun up during the THAW
> stage of hibernation anyway.
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> drivers/scsi/scsi_pm.c | 16 +++++++++++++++-
> 1 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
> index d329f8b..a633076 100644
> --- a/drivers/scsi/scsi_pm.c
> +++ b/drivers/scsi/scsi_pm.c
> @@ -49,8 +49,22 @@ static int scsi_bus_suspend_common(struct device *dev, pm_message_t msg)
> {
> int err = 0;
>
> - if (scsi_is_sdev_device(dev))
> + if (scsi_is_sdev_device(dev)) {
> + /*
> + * sd is the only high-level SCSI driver to implement runtime
> + * PM, and sd treats runtime suspend, system suspend, and
> + * system hibernate identically (but not system freeze).
> + */
> + if (pm_runtime_suspended(dev)) {
> + if (msg.event == PM_EVENT_SUSPEND ||
> + msg.event == PM_EVENT_HIBERNATE)
> + return 0; /* already suspended */
> +
> + /* wake up device so that FREEZE will succeed */
> + pm_runtime_resume(dev);
> + }
> err = scsi_dev_type_suspend(dev, msg);
> + }
> return err;
> }
This looks good to me.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
next prev parent reply other threads:[~2011-11-25 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 7:01 [PATCH v3 0/6] ata port runtime power management support Lin Ming
2011-11-23 7:01 ` [PATCH v3 1/6] ata: make ata port as parent device of scsi host Lin Ming
2011-11-23 7:01 ` [PATCH v3 2/6] scsi: add flag to skip the runtime PM calls on the host Lin Ming
2011-11-23 7:01 ` [PATCH v3 3/6] [SCSI] runtime resume device before system suspend Lin Ming
2011-11-23 17:02 ` Alan Stern
2011-11-24 12:21 ` Lin Ming
2011-11-24 16:36 ` Alan Stern
2011-11-24 19:57 ` Tejun Heo
2011-11-24 22:54 ` Alan Stern
2011-11-24 23:01 ` Tejun Heo
2011-11-25 0:17 ` Alan Stern
2011-11-25 13:50 ` Lin Ming
2011-11-25 15:19 ` Alan Stern [this message]
2011-11-23 7:01 ` [PATCH v3 4/6] [SCSI] sd: check runtime status in sd_shutdown Lin Ming
2011-11-23 7:01 ` [PATCH v3 5/6] ata: add ata port system PM callbacks Lin Ming
2011-11-23 7:01 ` [PATCH v3 6/6] ata: add ata port runtime " Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1111251018560.1951-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=JBottomley@parallels.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=tj@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).