linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: B.Zolnierkiewicz@elka.pw.edu.pl
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ide-iops: Use platform-dependent port I/O operations
Date: Mon, 13 Dec 2004 02:45:09 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.58L.0412130227420.8571@blysk.ds.pg.gda.pl> (raw)

Hello,

 Given the contents of <asm-generic/ide_iops.h> and platform-specific
peculiarities (like address-dependent hardware byte lane swappers), I
believe ide-iops should use __ide_* for port I/O string operations,
similarly to __ide_mm_* that are already used for memory-mapped I/O ones.  

 Please consider.

  Maciej

Signed-off-by: Maciej W. Rozycki <macro@mips.com>

patch-mips-2.6.10-rc3-20041212-ide-iops-0
diff -up --recursive --new-file linux-mips-2.6.10-rc3-20041212.macro/drivers/ide/ide-iops.c linux-mips-2.6.10-rc3-20041212/drivers/ide/ide-iops.c
--- linux-mips-2.6.10-rc3-20041212.macro/drivers/ide/ide-iops.c	Tue Nov 16 05:56:44 2004
+++ linux-mips-2.6.10-rc3-20041212/drivers/ide/ide-iops.c	Mon Dec 13 01:33:39 2004
@@ -46,7 +46,7 @@ static u16 ide_inw (unsigned long port)
 
 static void ide_insw (unsigned long port, void *addr, u32 count)
 {
-	insw(port, addr, count);
+	__ide_insw(port, addr, count);
 }
 
 static u32 ide_inl (unsigned long port)
@@ -56,7 +56,7 @@ static u32 ide_inl (unsigned long port)
 
 static void ide_insl (unsigned long port, void *addr, u32 count)
 {
-	insl(port, addr, count);
+	__ide_insl(port, addr, count);
 }
 
 static void ide_outb (u8 val, unsigned long port)
@@ -76,7 +76,7 @@ static void ide_outw (u16 val, unsigned 
 
 static void ide_outsw (unsigned long port, void *addr, u32 count)
 {
-	outsw(port, addr, count);
+	__ide_outsw(port, addr, count);
 }
 
 static void ide_outl (u32 val, unsigned long port)
@@ -86,7 +86,7 @@ static void ide_outl (u32 val, unsigned 
 
 static void ide_outsl (unsigned long port, void *addr, u32 count)
 {
-	outsl(port, addr, count);
+	__ide_outsl(port, addr, count);
 }
 
 void default_hwif_iops (ide_hwif_t *hwif)

             reply	other threads:[~2004-12-13  2:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-13  2:45 Maciej W. Rozycki [this message]
2004-12-13 21:39 ` [PATCH] ide-iops: Use platform-dependent port I/O operations Bartlomiej Zolnierkiewicz
2004-12-14  1:09   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58L.0412130227420.8571@blysk.ds.pg.gda.pl \
    --to=macro@linux-mips.org \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).