From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-iops: Use platform-dependent port I/O operations
Date: Mon, 13 Dec 2004 22:39:02 +0100 [thread overview]
Message-ID: <58cb370e04121313393f00c37c@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58L.0412130227420.8571@blysk.ds.pg.gda.pl>
Hi,
On Mon, 13 Dec 2004 02:45:09 +0000 (GMT), Maciej W. Rozycki
<macro@linux-mips.org> wrote:
> Hello,
>
> Given the contents of <asm-generic/ide_iops.h> and platform-specific
> peculiarities (like address-dependent hardware byte lane swappers), I
Could you give some specific examples? Thanks.
> believe ide-iops should use __ide_* for port I/O string operations,
> similarly to __ide_mm_* that are already used for memory-mapped I/O ones.
>
> Please consider.
This patch looks quite OK but it breaks few archs which don't include
<asm-generic/ide_iops.h> and don't define __ide_[in,out]* macros.
Bartlomiej
next prev parent reply other threads:[~2004-12-13 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-13 2:45 [PATCH] ide-iops: Use platform-dependent port I/O operations Maciej W. Rozycki
2004-12-13 21:39 ` Bartlomiej Zolnierkiewicz [this message]
2004-12-14 1:09 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e04121313393f00c37c@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).