From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-iops: Use platform-dependent port I/O operations
Date: Tue, 14 Dec 2004 01:09:09 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.58L.0412140039410.9181@blysk.ds.pg.gda.pl> (raw)
In-Reply-To: <58cb370e04121313393f00c37c@mail.gmail.com>
Hi,
> > Given the contents of <asm-generic/ide_iops.h> and platform-specific
> > peculiarities (like address-dependent hardware byte lane swappers), I
>
> Could you give some specific examples? Thanks.
Well, you could have a look at the few options at the top of
<asm-mips/io.h>, but on second thoughts, as long as port I/O string
operations either use an unswapping address space or revert any swapping
that might have been done by hardware (either for data or for addresses),
they should work as is. Unlike with memory-mapped I/O that should be
feasible, because port I/O is specific to ISA/EISA/PCI which are always
little-endian.
Anyway, I still think the patch should go in for consistency.
> > believe ide-iops should use __ide_* for port I/O string operations,
> > similarly to __ide_mm_* that are already used for memory-mapped I/O ones.
> >
> > Please consider.
>
> This patch looks quite OK but it breaks few archs which don't include
> <asm-generic/ide_iops.h> and don't define __ide_[in,out]* macros.
I can have a look at it -- that is as trivial as copying missing
definitions from <asm-generic/ide_iops.h>. I'm afraid I won't even be
able to perform compilation tests, though.
Maciej
prev parent reply other threads:[~2004-12-14 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-13 2:45 [PATCH] ide-iops: Use platform-dependent port I/O operations Maciej W. Rozycki
2004-12-13 21:39 ` Bartlomiej Zolnierkiewicz
2004-12-14 1:09 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58L.0412140039410.9181@blysk.ds.pg.gda.pl \
--to=macro@linux-mips.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).