From: Jan Engelhardt <jengelh@computergmbh.de>
To: dave young <hidave.darkstar@gmail.com>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>, Willy Tarreau <w@1wt.eu>,
Cyrill Gorcunov <gorcunov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: coding style
Date: Fri, 15 Jun 2007 11:16:08 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706151109430.32724@fbirervta.pbzchgretzou.qr> (raw)
In-Reply-To: <a8e1da0706142338s6cd76e94hf7a4c44ed5b067a0@mail.gmail.com>
Cyrill wrote:
>> err = foo(arg_a, arg_b, arg_c,
>> arg_d);
1 23 4
(note: monospace font needed)
Dave wrote:
> The Documentation/CodingStyle says:
>
> Outside of comments, documentation and except in Kconfig, spaces are never
> used for indentation, and the above example is deliberately broken.
Everything is right. The indent only goes from "1" to "2" [see above],
"3" to "4" is called
Cyrill wrote:
>> [spaces only for] alignment
Cyrill wrote:
>> so which one is preferred for the kernel?
err = very_long_function_name(lots_of_arguments,
less,
less,
less,
less,
even_more_arguments,
more_of_this,
more_of_that,
more,
more,
more);
IMO, preferred:
err = very_long_function_name(lots_of_arguments, less, less, less, less,
even_more_arguments, more_of_this, more_of_that, more, more, more);
YMMV.
Jan
--
next prev parent reply other threads:[~2007-06-15 9:16 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 18:48 coding style Cyrill Gorcunov
2007-06-15 4:51 ` Willy Tarreau
2007-06-15 5:09 ` Kok, Auke
2007-06-15 6:38 ` dave young
2007-06-15 6:47 ` debian developer
2007-06-15 6:54 ` dave young
2007-06-15 9:06 ` Mailing style (was Re: coding style) Bernd Petrovitsch
2007-06-15 9:19 ` debian developer
2007-06-15 9:16 ` Jan Engelhardt [this message]
2007-06-15 17:32 ` coding style Cyrill Gorcunov
2007-06-15 17:54 ` Chris Friesen
2007-06-15 18:03 ` Randy Dunlap
2007-06-15 19:10 ` Jan Engelhardt
2007-06-15 19:18 ` Cyrill Gorcunov
2007-06-15 19:21 ` Kok, Auke
2007-06-15 19:29 ` Cyrill Gorcunov
2007-06-15 19:31 ` Jan Engelhardt
2007-06-15 19:41 ` Cyrill Gorcunov
2007-06-15 20:21 ` Linus Torvalds
2007-06-15 20:35 ` Jan Engelhardt
2007-06-16 12:30 ` Stefan Richter
2007-06-15 20:21 ` Jan Engelhardt
2007-06-15 20:39 ` Linus Torvalds
2007-06-16 6:38 ` Jan Engelhardt
2007-06-16 12:40 ` Stefan Richter
2007-06-16 15:49 ` Linus Torvalds
2007-06-19 14:05 ` Mark Lord
2007-06-15 19:45 ` Kok, Auke
2007-06-15 19:49 ` Cyrill Gorcunov
2007-06-15 20:28 ` Jan Engelhardt
2007-06-15 22:10 ` Randy Dunlap
2007-06-16 12:59 ` please keep the CodingStyle text in check (was Re: coding style) Stefan Richter
2007-06-15 18:05 ` coding style Kok, Auke
2007-06-15 18:22 ` Cyrill Gorcunov
2007-06-16 13:07 ` Stefan Richter
2007-06-16 14:31 ` gorcunov
2007-06-16 17:43 ` Stefan Richter
2007-06-16 18:22 ` Cyrill Gorcunov
2007-06-16 14:22 ` Clifford Wolf
2007-06-15 8:56 ` Krzysztof Halasa
-- strict thread matches above, loose matches on Subject: below --
2001-01-23 15:07 Coding Style Jonathan Earle
2001-01-24 3:23 ` john slee
[not found] <Pine.LNX.4.10.10101192217390.9361-100000@penguin.transmeta .com>
[not found] ` <3A68E309.2540A5E1@purplecoder.com>
2001-01-20 6:29 ` Linus Torvalds
2001-01-20 15:32 ` Anton Altaparmakov
2001-01-21 8:24 ` george anzinger
2001-01-19 17:59 Mark I Manning IV
2001-01-20 0:09 ` David Ford
2001-01-20 1:26 ` John Cavan
2001-01-20 0:46 ` Albert D. Cahalan
2001-01-20 5:34 ` Linus Torvalds
2001-01-21 2:00 ` Matthias Andree
2001-01-22 8:24 ` Ralf Baechle
2001-01-22 22:28 ` Mark I Manning IV
2001-01-23 3:56 ` adrian
2001-01-23 20:05 ` Boris Dragovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706151109430.32724@fbirervta.pbzchgretzou.qr \
--to=jengelh@computergmbh.de \
--cc=auke-jan.h.kok@intel.com \
--cc=gorcunov@gmail.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).