From: Mikulas Patocka <mpatocka@redhat.com>
To: Niels de Vos <ndevos@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bryn M. Reeves" <bmr@redhat.com>
Subject: Re: [PATCH v2] fs: Invalidate the cache for a parent block-device if fsync() is called for a partition
Date: Mon, 23 Jan 2012 14:23:20 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.1201231422470.1760@hs20-bc2-1.build.redhat.com> (raw)
In-Reply-To: <1327315109-7740-1-git-send-email-ndevos@redhat.com>
On Mon, 23 Jan 2012, Niels de Vos wrote:
> Executing an fsync() on a file-descriptor of a partition flushes the
> caches for that partition by calling blkdev_issue_flush(). However, it
> seems that reading data through the parent device will still return the
> old cached data.
>
> The cache for the block-device is not synced if the block-device is kept
> open (due to a mounted partition, for example). Only when all users for
> the disk have exited, the cache for the disk is made consistent again.
>
> Calling invalidate_bdev() on the parent block-device in case
> blkdev_fsync() was called for a partition, fixes this.
>
> The problem can be worked around by forcing the caches to be flushed
> with either
> # blockdev --flushbufs ${dev_disk}
> or
> # echo 3 > /proc/sys/vm/drop_caches
>
> CC: Bryn M. Reeves <bmr@redhat.com>
> CC: Mikulas Patocka <mpatocka@redhat.com>
> Signed-off-by: Niels de Vos <ndevos@redhat.com>
>
Acked-by: Mikulas Patocka <mpatocka@redhat.com>
> ---
> v2:
> - Do not call invalidate_bdev() from blkdev_issue_flush() and prevent
> performance degration with journalled filesystems.
>
> Suggested was to call invalidate_bdev() in fsync_bdev(), but this is
> not in the call-path of mkfs.ext3 and similar tools. Hence the issue
> persists.
>
> - Correct phrasing a little, changing ioctl-BLKFLSBUF is not required.
>
> - This issue also occurs when doing an ioctl-BLKFLSBUF on a partition.
> Reading the whole disk will still return cached data. If this is an
> issue, it will need a seperate patch.
> ---
> fs/block_dev.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index 0e575d1..433c4de 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -424,6 +424,10 @@ int blkdev_fsync(struct file *filp, loff_t start, loff_t end, int datasync)
> if (error == -EOPNOTSUPP)
> error = 0;
>
> + /* invalidate parent block_device */
> + if (!error && bdev != bdev->bd_contains)
> + invalidate_bdev(bdev->bd_contains);
> +
> return error;
> }
> EXPORT_SYMBOL(blkdev_fsync);
> --
> 1.7.6.5
>
next prev parent reply other threads:[~2012-01-23 19:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 1:58 [PATCH] block: Invalidate the cache for a parent block-device Mikulas Patocka
2012-01-20 9:35 ` Niels de Vos
2012-01-23 10:38 ` [PATCH v2] fs: Invalidate the cache for a parent block-device if fsync() is called for a partition Niels de Vos
2012-01-23 16:27 ` Jeff Moyer
2012-01-23 16:46 ` Niels de Vos
2012-01-23 19:23 ` Mikulas Patocka [this message]
2012-01-23 20:04 ` Jeff Moyer
2012-01-26 10:03 ` Andrew Morton
2012-01-26 11:50 ` Niels de Vos
2012-01-26 13:33 ` [PATCH v3] " Niels de Vos
2012-01-26 21:40 ` Andrew Morton
2012-01-26 21:45 ` Christoph Hellwig
2012-01-26 21:50 ` Mikulas Patocka
2012-01-27 12:19 ` Ric Wheeler
2012-01-31 16:00 ` Niels de Vos
2012-01-31 18:58 ` Andrew Morton
2012-01-31 19:04 ` Christoph Hellwig
2012-01-31 19:32 ` Andrew Morton
2012-01-31 19:37 ` Christoph Hellwig
2012-01-31 19:48 ` Andrew Morton
2012-01-26 21:49 ` Jeff Moyer
2012-01-26 22:13 ` Mikulas Patocka
2012-01-26 22:26 ` Kernel Oops report (Android gingerbread) Fan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1201231422470.1760@hs20-bc2-1.build.redhat.com \
--to=mpatocka@redhat.com \
--cc=bmr@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndevos@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).