* [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver @ 2017-11-11 11:51 Colin King 2017-11-13 3:43 ` Liu, Monk 0 siblings, 1 reply; 4+ messages in thread From: Colin King @ 2017-11-11 11:51 UTC (permalink / raw) To: Alex Deucher, Christian König, David Airlie, Monk Liu, Xiangliang Yu, amd-gfx, dri-devel Cc: kernel-janitors, linux-kernel From: Colin Ian King <colin.king@canonical.com> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf = (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver 2017-11-11 11:51 [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Colin King @ 2017-11-13 3:43 ` Liu, Monk 2017-11-13 14:40 ` Chen, Horace 0 siblings, 1 reply; 4+ messages in thread From: Liu, Monk @ 2017-11-13 3:43 UTC (permalink / raw) To: Chen, Horace, Colin King, Deucher, Alexander, Koenig, Christian, David Airlie, Yu, Xiangliang, amd-gfx, dri-devel Cc: kernel-janitors, linux-kernel + Horace -----Original Message----- From: Colin King [mailto:colin.king@canonical.com] Sent: 2017年11月11日 19:51 To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver From: Colin Ian King <colin.king@canonical.com> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf = (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver 2017-11-13 3:43 ` Liu, Monk @ 2017-11-13 14:40 ` Chen, Horace 2017-11-13 19:21 ` Alex Deucher 0 siblings, 1 reply; 4+ messages in thread From: Chen, Horace @ 2017-11-13 14:40 UTC (permalink / raw) To: Liu, Monk, Colin King, Deucher, Alexander, Koenig, Christian, David Airlie, Yu, Xiangliang, amd-gfx, dri-devel Cc: kernel-janitors, linux-kernel Reivewed-by: Horace Chen <horace.chen@amd.com> -----Original Message----- From: Liu, Monk Sent: Monday, November 13, 2017 11:43 AM To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Importance: High + Horace -----Original Message----- From: Colin King [mailto:colin.king@canonical.com] Sent: 2017年11月11日 19:51 To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver From: Colin Ian King <colin.king@canonical.com> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 6738df836a70..b1cc179512fa 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { - uint32_t pf2vf_ver = 0; uint32_t pf2vf_size = 0; uint32_t checksum = 0; uint32_t checkval; @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) adev->virt.fw_reserve.p_pf2vf = (struct amdgim_pf2vf_info_header *)( adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); -- 2.14.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver 2017-11-13 14:40 ` Chen, Horace @ 2017-11-13 19:21 ` Alex Deucher 0 siblings, 0 replies; 4+ messages in thread From: Alex Deucher @ 2017-11-13 19:21 UTC (permalink / raw) To: Chen, Horace Cc: Liu, Monk, Colin King, Deucher, Alexander, Koenig, Christian, David Airlie, Yu, Xiangliang, amd-gfx, dri-devel, kernel-janitors, linux-kernel On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace <Horace.Chen@amd.com> wrote: > Reivewed-by: Horace Chen <horace.chen@amd.com> Applied. thanks! Alex > > -----Original Message----- > From: Liu, Monk > Sent: Monday, November 13, 2017 11:43 AM > To: Chen, Horace <Horace.Chen@amd.com>; Colin King <colin.king@canonical.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver > Importance: High > > + Horace > > -----Original Message----- > From: Colin King [mailto:colin.king@canonical.com] > Sent: 2017年11月11日 19:51 > To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; David Airlie <airlied@linux.ie>; Liu, Monk <Monk.Liu@amd.com>; Yu, Xiangliang <Xiangliang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver > > From: Colin Ian King <colin.king@canonical.com> > > Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed. > > Cleans up clang warning: > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > index 6738df836a70..b1cc179512fa 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj, > > void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) { > - uint32_t pf2vf_ver = 0; > uint32_t pf2vf_size = 0; > uint32_t checksum = 0; > uint32_t checkval; > @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) > adev->virt.fw_reserve.p_pf2vf = > (struct amdgim_pf2vf_info_header *)( > adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET); > - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version; > AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size); > AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum); > > -- > 2.14.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-13 19:21 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-11-11 11:51 [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver Colin King 2017-11-13 3:43 ` Liu, Monk 2017-11-13 14:40 ` Chen, Horace 2017-11-13 19:21 ` Alex Deucher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).