* [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
@ 2019-03-11 18:51 Tony Luck
2019-03-11 20:25 ` Ghannam, Yazen
0 siblings, 1 reply; 6+ messages in thread
From: Tony Luck @ 2019-03-11 18:51 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Tony Luck, x86, linux-kernel, Ashok Raj
There has been a lurking "TBD" in the machine check poll routine ever
since it was first split out from the machine check handler. The potential
issue is that the poll routine may have just begun a read from the STATUS
register in a machine check bank when the hardware logs an error in that
bank and signals a machine check. That race used to be pretty small back
when machine checks were broadcast, but the addition of local machine check
means that the poll code could continue running and clear the error from the
bank before the local machine check handler on another CPU gets around to
reading it.
Fix the code to be sure to only process errors that need to be processed
in the poll code, leaving other logged errors alone for the machine check
handler to find and process.
Fixes: b79109c3bbcf ("x86, mce: separate correct machine check poller and fatal exception handler")
Fixes: ed7290d0ee8f ("x86, mce: implement new status bits")
Reported-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/kernel/cpu/mce/core.c | 42 ++++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 6ce290c506d9..806551b381ae 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -712,19 +712,47 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
barrier();
m.status = mce_rdmsrl(msr_ops.status(i));
+
+ /* If this entry is not valid, ignore it */
if (!(m.status & MCI_STATUS_VAL))
continue;
/*
- * Uncorrected or signalled events are handled by the exception
- * handler when it is enabled, so don't process those here.
- *
- * TBD do the same check for MCI_STATUS_EN here?
+ * If we are logging everything (at CPU online) or this
+ * is a corrected error, then we must log it.
*/
- if (!(flags & MCP_UC) &&
- (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
- continue;
+ if ((flags & MCP_UC) || (m.status & MCI_STATUS_UC) == 0)
+ goto log_it;
+
+ /*
+ * Older systems that do not support software error recovery
+ * should skip over uncorrected errors, but log everything else
+ */
+ if (!mca_cfg.ser) {
+ if (m.status & MCI_STATUS_UC)
+ continue;
+ goto log_it;
+ }
+
+ /* Log "not enabled" (speculative) errors */
+ if (!(m.status & MCI_STATUS_EN))
+ goto log_it;
+
+ /*
+ * Log UCNA (SDM: 15.6.3 "UCR Error Classification")
+ * UC == 1 && PCC == 0 && S == 0
+ */
+ if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
+ goto log_it;
+
+ /*
+ * Skip anything else. Presumption is that our read of this
+ * bank is racing with a machine check. Leave the log alone
+ * for do_machine_check() to deal with it.
+ */
+ continue;
+log_it:
error_seen = true;
mce_read_aux(&m, i);
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
2019-03-11 18:51 [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log Tony Luck
@ 2019-03-11 20:25 ` Ghannam, Yazen
2019-03-11 20:42 ` Luck, Tony
0 siblings, 1 reply; 6+ messages in thread
From: Ghannam, Yazen @ 2019-03-11 20:25 UTC (permalink / raw)
To: Tony Luck, Borislav Petkov; +Cc: x86, linux-kernel, Ashok Raj
> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org <linux-kernel-owner@vger.kernel.org> On Behalf Of Tony Luck
> Sent: Monday, March 11, 2019 1:51 PM
> To: Borislav Petkov <bp@alien8.de>
> Cc: Tony Luck <tony.luck@intel.com>; x86@kernel.org; linux-kernel@vger.kernel.org; Ashok Raj <ashok.raj@intel.com>
> Subject: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
>
> There has been a lurking "TBD" in the machine check poll routine ever
> since it was first split out from the machine check handler. The potential
> issue is that the poll routine may have just begun a read from the STATUS
> register in a machine check bank when the hardware logs an error in that
> bank and signals a machine check. That race used to be pretty small back
> when machine checks were broadcast, but the addition of local machine check
> means that the poll code could continue running and clear the error from the
> bank before the local machine check handler on another CPU gets around to
> reading it.
>
> Fix the code to be sure to only process errors that need to be processed
> in the poll code, leaving other logged errors alone for the machine check
> handler to find and process.
>
> Fixes: b79109c3bbcf ("x86, mce: separate correct machine check poller and fatal exception handler")
> Fixes: ed7290d0ee8f ("x86, mce: implement new status bits")
> Reported-by: Ashok Raj <ashok.raj@intel.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
> arch/x86/kernel/cpu/mce/core.c | 42 ++++++++++++++++++++++++++++------
> 1 file changed, 35 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> index 6ce290c506d9..806551b381ae 100644
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -712,19 +712,47 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
>
> barrier();
> m.status = mce_rdmsrl(msr_ops.status(i));
> +
> + /* If this entry is not valid, ignore it */
> if (!(m.status & MCI_STATUS_VAL))
> continue;
>
> /*
> - * Uncorrected or signalled events are handled by the exception
> - * handler when it is enabled, so don't process those here.
> - *
> - * TBD do the same check for MCI_STATUS_EN here?
> + * If we are logging everything (at CPU online) or this
> + * is a corrected error, then we must log it.
> */
> - if (!(flags & MCP_UC) &&
> - (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
> - continue;
> + if ((flags & MCP_UC) || (m.status & MCI_STATUS_UC) == 0)
> + goto log_it;
> +
> + /*
> + * Older systems that do not support software error recovery
> + * should skip over uncorrected errors, but log everything else
> + */
> + if (!mca_cfg.ser) {
> + if (m.status & MCI_STATUS_UC)
> + continue;
> + goto log_it;
> + }
> +
> + /* Log "not enabled" (speculative) errors */
> + if (!(m.status & MCI_STATUS_EN))
> + goto log_it;
> +
> + /*
> + * Log UCNA (SDM: 15.6.3 "UCR Error Classification")
> + * UC == 1 && PCC == 0 && S == 0
> + */
> + if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> + goto log_it;
> +
Can you please include a vendor check with this? MCi_STATUS[56] is not defined the same way on AMD systems.
Thanks,
Yazen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
2019-03-11 20:25 ` Ghannam, Yazen
@ 2019-03-11 20:42 ` Luck, Tony
2019-03-11 22:10 ` Ghannam, Yazen
0 siblings, 1 reply; 6+ messages in thread
From: Luck, Tony @ 2019-03-11 20:42 UTC (permalink / raw)
To: Ghannam, Yazen; +Cc: Borislav Petkov, x86, linux-kernel, Ashok Raj
On Mon, Mar 11, 2019 at 08:25:53PM +0000, Ghannam, Yazen wrote:
> > + if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> > + goto log_it;
> > +
>
> Can you please include a vendor check with this? MCi_STATUS[56] is
> not defined the same way on AMD systems.
Original code also looked at MCi_STATUS[56] without a vendor
check:
> > - (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
Was this OK because you don't set mca_cfg.ser?
If so, my new code will also skip out before getting to this test. But
should probably have a better comment. Something like:
/*
* Newer Intel systems that support software error
* recovery need to make some extra checks. Other
* CPUs should skip over uncorrected errors, but log
* everything else
*/
if (!mca_cfg.ser) {
if (m.status & MCI_STATUS_UC)
continue;
goto log_it;
}
-Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
2019-03-11 20:42 ` Luck, Tony
@ 2019-03-11 22:10 ` Ghannam, Yazen
2019-03-12 17:09 ` [PATCH v2] x86, mce: Fix machine_check_poll() tests for which errors Luck, Tony
0 siblings, 1 reply; 6+ messages in thread
From: Ghannam, Yazen @ 2019-03-11 22:10 UTC (permalink / raw)
To: Luck, Tony; +Cc: Borislav Petkov, x86, linux-kernel, Ashok Raj
> -----Original Message-----
> From: Luck, Tony <tony.luck@intel.com>
> Sent: Monday, March 11, 2019 3:42 PM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: Borislav Petkov <bp@alien8.de>; x86@kernel.org; linux-kernel@vger.kernel.org; Ashok Raj <ashok.raj@intel.com>
> Subject: Re: [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log
>
> On Mon, Mar 11, 2019 at 08:25:53PM +0000, Ghannam, Yazen wrote:
> > > + if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
> > > + goto log_it;
> > > +
> >
> > Can you please include a vendor check with this? MCi_STATUS[56] is
> > not defined the same way on AMD systems.
>
> Original code also looked at MCi_STATUS[56] without a vendor
> check:
>
> > > - (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
>
> Was this OK because you don't set mca_cfg.ser?
>
> If so, my new code will also skip out before getting to this test. But
> should probably have a better comment. Something like:
>
>
> /*
> * Newer Intel systems that support software error
> * recovery need to make some extra checks. Other
> * CPUs should skip over uncorrected errors, but log
> * everything else
> */
> if (!mca_cfg.ser) {
> if (m.status & MCI_STATUS_UC)
> continue;
> goto log_it;
> }
>
Yes, you're right. Thanks for pointing that out.
-Yazen
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] x86, mce: Fix machine_check_poll() tests for which errors
2019-03-11 22:10 ` Ghannam, Yazen
@ 2019-03-12 17:09 ` Luck, Tony
2019-03-27 9:58 ` [tip:ras/core] x86/mce: Fix machine_check_poll() tests for error types tip-bot for Tony Luck
0 siblings, 1 reply; 6+ messages in thread
From: Luck, Tony @ 2019-03-12 17:09 UTC (permalink / raw)
To: Borislav Petkov; +Cc: x86, linux-kernel, Ashok Raj, Ghannam, Yazen
There has been a lurking "TBD" in the machine check poll routine ever
since it was first split out from the machine check handler. The potential
issue is that the poll routine may have just begun a read from the STATUS
register in a machine check bank when the hardware logs an error in that
bank and signals a machine check. That race used to be pretty small back
when machine checks were broadcast, but the addition of local machine check
means that the poll code could continue running and clear the error from the
bank before the local machine check handler on another CPU gets around to
reading it.
Fix the code to be sure to only process errors that need to be processed
in the poll code, leaving other logged errors alone for the machine check
handler to find and process.
Fixes: b79109c3bbcf ("x86, mce: separate correct machine check poller and fatal exception handler")
Fixes: ed7290d0ee8f ("x86, mce: implement new status bits")
Reported-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
V2: Update comment to make it clear that only Intel CPUs with software
error recovery reach the final few tests on whether to log.
arch/x86/kernel/cpu/mce/core.c | 44 ++++++++++++++++++++++++++++------
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 6ce290c506d9..663e8b82eacc 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -712,19 +712,49 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
barrier();
m.status = mce_rdmsrl(msr_ops.status(i));
+
+ /* If this entry is not valid, ignore it */
if (!(m.status & MCI_STATUS_VAL))
continue;
/*
- * Uncorrected or signalled events are handled by the exception
- * handler when it is enabled, so don't process those here.
- *
- * TBD do the same check for MCI_STATUS_EN here?
+ * If we are logging everything (at CPU online) or this
+ * is a corrected error, then we must log it.
*/
- if (!(flags & MCP_UC) &&
- (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
- continue;
+ if ((flags & MCP_UC) || (m.status & MCI_STATUS_UC) == 0)
+ goto log_it;
+
+ /*
+ * Newer Intel systems that support software error
+ * recovery need to make additional checks. Other
+ * CPUs should skip over uncorrected errors, but log
+ * everything else.
+ */
+ if (!mca_cfg.ser) {
+ if (m.status & MCI_STATUS_UC)
+ continue;
+ goto log_it;
+ }
+
+ /* Log "not enabled" (speculative) errors */
+ if (!(m.status & MCI_STATUS_EN))
+ goto log_it;
+
+ /*
+ * Log UCNA (SDM: 15.6.3 "UCR Error Classification")
+ * UC == 1 && PCC == 0 && S == 0
+ */
+ if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
+ goto log_it;
+
+ /*
+ * Skip anything else. Presumption is that our read of this
+ * bank is racing with a machine check. Leave the log alone
+ * for do_machine_check() to deal with it.
+ */
+ continue;
+log_it:
error_seen = true;
mce_read_aux(&m, i);
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [tip:ras/core] x86/mce: Fix machine_check_poll() tests for error types
2019-03-12 17:09 ` [PATCH v2] x86, mce: Fix machine_check_poll() tests for which errors Luck, Tony
@ 2019-03-27 9:58 ` tip-bot for Tony Luck
0 siblings, 0 replies; 6+ messages in thread
From: tip-bot for Tony Luck @ 2019-03-27 9:58 UTC (permalink / raw)
To: linux-tip-commits
Cc: ashok.raj, tony.luck, linux-kernel, tglx, mingo, Yazen.Ghannam,
mingo, hpa, x86, bp, linux-edac
Commit-ID: f19501aa07f18268ab14f458b51c1c6b7f72a134
Gitweb: https://git.kernel.org/tip/f19501aa07f18268ab14f458b51c1c6b7f72a134
Author: Tony Luck <tony.luck@intel.com>
AuthorDate: Tue, 12 Mar 2019 10:09:38 -0700
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Wed, 27 Mar 2019 10:53:49 +0100
x86/mce: Fix machine_check_poll() tests for error types
There has been a lurking "TBD" in the machine check poll routine ever
since it was first split out from the machine check handler. The
potential issue is that the poll routine may have just begun a read from
the STATUS register in a machine check bank when the hardware logs an
error in that bank and signals a machine check.
That race used to be pretty small back when machine checks were
broadcast, but the addition of local machine check means that the poll
code could continue running and clear the error from the bank before the
local machine check handler on another CPU gets around to reading it.
Fix the code to be sure to only process errors that need to be processed
in the poll code, leaving other logged errors alone for the machine
check handler to find and process.
[ bp: Massage a bit and flip the "== 0" check to the usual !(..) test. ]
Fixes: b79109c3bbcf ("x86, mce: separate correct machine check poller and fatal exception handler")
Fixes: ed7290d0ee8f ("x86, mce: implement new status bits")
Reported-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Ashok Raj <ashok.raj@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
Link: https://lkml.kernel.org/r/20190312170938.GA23035@agluck-desk
---
arch/x86/kernel/cpu/mce/core.c | 44 +++++++++++++++++++++++++++++++++++-------
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index b7fb541a4873..e558ca77cfe8 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -712,19 +712,49 @@ bool machine_check_poll(enum mcp_flags flags, mce_banks_t *b)
barrier();
m.status = mce_rdmsrl(msr_ops.status(i));
+
+ /* If this entry is not valid, ignore it */
if (!(m.status & MCI_STATUS_VAL))
continue;
/*
- * Uncorrected or signalled events are handled by the exception
- * handler when it is enabled, so don't process those here.
- *
- * TBD do the same check for MCI_STATUS_EN here?
+ * If we are logging everything (at CPU online) or this
+ * is a corrected error, then we must log it.
*/
- if (!(flags & MCP_UC) &&
- (m.status & (mca_cfg.ser ? MCI_STATUS_S : MCI_STATUS_UC)))
- continue;
+ if ((flags & MCP_UC) || !(m.status & MCI_STATUS_UC))
+ goto log_it;
+
+ /*
+ * Newer Intel systems that support software error
+ * recovery need to make additional checks. Other
+ * CPUs should skip over uncorrected errors, but log
+ * everything else.
+ */
+ if (!mca_cfg.ser) {
+ if (m.status & MCI_STATUS_UC)
+ continue;
+ goto log_it;
+ }
+
+ /* Log "not enabled" (speculative) errors */
+ if (!(m.status & MCI_STATUS_EN))
+ goto log_it;
+
+ /*
+ * Log UCNA (SDM: 15.6.3 "UCR Error Classification")
+ * UC == 1 && PCC == 0 && S == 0
+ */
+ if (!(m.status & MCI_STATUS_PCC) && !(m.status & MCI_STATUS_S))
+ goto log_it;
+
+ /*
+ * Skip anything else. Presumption is that our read of this
+ * bank is racing with a machine check. Leave the log alone
+ * for do_machine_check() to deal with it.
+ */
+ continue;
+log_it:
error_seen = true;
mce_read_aux(&m, i);
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-27 9:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 18:51 [PATCH] x86, mce: Fix machine_check_poll() tests for which errors to log Tony Luck
2019-03-11 20:25 ` Ghannam, Yazen
2019-03-11 20:42 ` Luck, Tony
2019-03-11 22:10 ` Ghannam, Yazen
2019-03-12 17:09 ` [PATCH v2] x86, mce: Fix machine_check_poll() tests for which errors Luck, Tony
2019-03-27 9:58 ` [tip:ras/core] x86/mce: Fix machine_check_poll() tests for error types tip-bot for Tony Luck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).