* [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
@ 2020-08-10 18:36 Grant Peltier
2020-08-11 17:17 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Grant Peltier @ 2020-08-10 18:36 UTC (permalink / raw)
To: linux; +Cc: grant.peltier.jg, linux-kernel, adam.vaughn.xh
Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported PMBus
command.
Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
---
drivers/hwmon/pmbus/isl68137.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 0c622711ef7e..58aa95a3c010 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -67,6 +67,7 @@ enum variants {
raa_dmpvr1_2rail,
raa_dmpvr2_1rail,
raa_dmpvr2_2rail,
+ raa_dmpvr2_2rail_nontc,
raa_dmpvr2_3rail,
raa_dmpvr2_hv,
};
@@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client,
info->pages = 1;
info->read_word_data = raa_dmpvr2_read_word_data;
break;
+ case raa_dmpvr2_2rail_nontc:
+ info->func[0] &= ~PMBUS_HAVE_TEMP;
+ info->func[1] &= ~PMBUS_HAVE_TEMP;
+ fallthrough;
case raa_dmpvr2_2rail:
info->pages = 2;
info->read_word_data = raa_dmpvr2_read_word_data;
@@ -304,7 +309,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
{"raa228000", raa_dmpvr2_hv},
{"raa228004", raa_dmpvr2_hv},
{"raa228006", raa_dmpvr2_hv},
- {"raa228228", raa_dmpvr2_2rail},
+ {"raa228228", raa_dmpvr2_2rail_nontc},
{"raa229001", raa_dmpvr2_2rail},
{"raa229004", raa_dmpvr2_2rail},
{}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
2020-08-10 18:36 [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228 Grant Peltier
@ 2020-08-11 17:17 ` Guenter Roeck
2020-08-11 17:24 ` Grant Peltier
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2020-08-11 17:17 UTC (permalink / raw)
To: Grant Peltier; +Cc: grant.peltier.jg, linux-kernel, adam.vaughn.xh
On 8/10/20 11:36 AM, Grant Peltier wrote:
> Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported PMBus
> command.
>
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
Please copy linux-hwmon@vger.kernel.org on hwmon patches. This patch is not
in the hwmon patchwork, which in general almost guarantees that it gets lost
since I usually pull patches from there. As it happens, you are lucky
that I noticed. Patch applied.
Guenter
> ---
> drivers/hwmon/pmbus/isl68137.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 0c622711ef7e..58aa95a3c010 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -67,6 +67,7 @@ enum variants {
> raa_dmpvr1_2rail,
> raa_dmpvr2_1rail,
> raa_dmpvr2_2rail,
> + raa_dmpvr2_2rail_nontc,
> raa_dmpvr2_3rail,
> raa_dmpvr2_hv,
> };
> @@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client,
> info->pages = 1;
> info->read_word_data = raa_dmpvr2_read_word_data;
> break;
> + case raa_dmpvr2_2rail_nontc:
> + info->func[0] &= ~PMBUS_HAVE_TEMP;
> + info->func[1] &= ~PMBUS_HAVE_TEMP;
> + fallthrough;
> case raa_dmpvr2_2rail:
> info->pages = 2;
> info->read_word_data = raa_dmpvr2_read_word_data;
> @@ -304,7 +309,7 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
> {"raa228000", raa_dmpvr2_hv},
> {"raa228004", raa_dmpvr2_hv},
> {"raa228006", raa_dmpvr2_hv},
> - {"raa228228", raa_dmpvr2_2rail},
> + {"raa228228", raa_dmpvr2_2rail_nontc},
> {"raa229001", raa_dmpvr2_2rail},
> {"raa229004", raa_dmpvr2_2rail},
> {}
>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
2020-08-11 17:17 ` Guenter Roeck
@ 2020-08-11 17:24 ` Grant Peltier
0 siblings, 0 replies; 6+ messages in thread
From: Grant Peltier @ 2020-08-11 17:24 UTC (permalink / raw)
To: Guenter Roeck, Grant Peltier; +Cc: linux-kernel, Adam Vaughn
Ah, my apologies. Duly noted for the future. Thanks for catching it.
Grant
-----Original Message-----
From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
Sent: Tuesday, August 11, 2020 12:17 PM
To: Grant Peltier <grantpeltier93@gmail.com>
Cc: Grant Peltier <grant.peltier.jg@renesas.com>; linux-kernel@vger.kernel.org; Adam Vaughn <adam.vaughn.xh@renesas.com>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
On 8/10/20 11:36 AM, Grant Peltier wrote:
> Per the RAA228228 datasheet, READ_TEMPERATURE_1 is not a supported
> PMBus command.
>
> Signed-off-by: Grant Peltier <grantpeltier93@gmail.com>
Please copy linux-hwmon@vger.kernel.org on hwmon patches. This patch is not in the hwmon patchwork, which in general almost guarantees that it gets lost since I usually pull patches from there. As it happens, you are lucky that I noticed. Patch applied.
Guenter
> ---
> drivers/hwmon/pmbus/isl68137.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/isl68137.c
> b/drivers/hwmon/pmbus/isl68137.c index 0c622711ef7e..58aa95a3c010
> 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -67,6 +67,7 @@ enum variants {
> raa_dmpvr1_2rail,
> raa_dmpvr2_1rail,
> raa_dmpvr2_2rail,
> + raa_dmpvr2_2rail_nontc,
> raa_dmpvr2_3rail,
> raa_dmpvr2_hv,
> };
> @@ -241,6 +242,10 @@ static int isl68137_probe(struct i2c_client *client,
> info->pages = 1;
> info->read_word_data = raa_dmpvr2_read_word_data;
> break;
> + case raa_dmpvr2_2rail_nontc:
> + info->func[0] &= ~PMBUS_HAVE_TEMP;
> + info->func[1] &= ~PMBUS_HAVE_TEMP;
> + fallthrough;
> case raa_dmpvr2_2rail:
> info->pages = 2;
> info->read_word_data = raa_dmpvr2_read_word_data; @@ -304,7 +309,7
> @@ static const struct i2c_device_id raa_dmpvr_id[] = {
> {"raa228000", raa_dmpvr2_hv},
> {"raa228004", raa_dmpvr2_hv},
> {"raa228006", raa_dmpvr2_hv},
> - {"raa228228", raa_dmpvr2_2rail},
> + {"raa228228", raa_dmpvr2_2rail_nontc},
> {"raa229001", raa_dmpvr2_2rail},
> {"raa229004", raa_dmpvr2_2rail},
> {}
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
@ 2020-10-13 18:18 Alex Qiu
2020-10-13 18:22 ` Alex Qiu
2020-10-13 18:37 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Alex Qiu @ 2020-10-13 18:18 UTC (permalink / raw)
To: Grant Peltier, Linux Kernel Mailing List, Adam Vaughn, Guenter Roeck
Cc: Guenter Roeck, Jason Ling
(Intercepting the email thread...)
Hi Grant,
Looks like you made a typo in your patch:
> + case raa_dmpvr2_2rail_nontc:
> + info->func[0] &= ~PMBUS_HAVE_TEMP;
> + info->func[1] &= ~PMBUS_HAVE_TEMP;
> + fallthrough;
Did you mean "/* fallthrough */" instead of "fallthrough;"?
- Alex Qiu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
2020-10-13 18:18 Alex Qiu
@ 2020-10-13 18:22 ` Alex Qiu
2020-10-13 18:37 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Alex Qiu @ 2020-10-13 18:22 UTC (permalink / raw)
To: Grant Peltier, Linux Kernel Mailing List, Adam Vaughn, Guenter Roeck
Cc: Guenter Roeck, Jason Ling
Jason pointed me to the patch
https://github.com/torvalds/linux/commit/294f69e662d1570703e9b56e95be37a9fd3afba5.
Nvm...
- Alex Qiu
On Tue, Oct 13, 2020 at 11:18 AM Alex Qiu <xqiu@google.com> wrote:
>
> (Intercepting the email thread...)
>
> Hi Grant,
>
> Looks like you made a typo in your patch:
>
> > + case raa_dmpvr2_2rail_nontc:
> > + info->func[0] &= ~PMBUS_HAVE_TEMP;
> > + info->func[1] &= ~PMBUS_HAVE_TEMP;
> > + fallthrough;
>
> Did you mean "/* fallthrough */" instead of "fallthrough;"?
>
> - Alex Qiu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
2020-10-13 18:18 Alex Qiu
2020-10-13 18:22 ` Alex Qiu
@ 2020-10-13 18:37 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2020-10-13 18:37 UTC (permalink / raw)
To: Alex Qiu, Grant Peltier, Linux Kernel Mailing List, Adam Vaughn,
Guenter Roeck
Cc: Jason Ling
On 10/13/20 11:18 AM, Alex Qiu wrote:
> (Intercepting the email thread...)
>
> Hi Grant,
>
> Looks like you made a typo in your patch:
>
>> + case raa_dmpvr2_2rail_nontc:
>> + info->func[0] &= ~PMBUS_HAVE_TEMP;
>> + info->func[1] &= ~PMBUS_HAVE_TEMP;
>> + fallthrough;
>
> Did you mean "/* fallthrough */" instead of "fallthrough;"?
>
No, that is the fancy new way to indicate fallthrough in the kernel.
It is converted to either
__attribute__((__fallthrough__))
or to
do {} while (0)
in include/linux/compiler_attributes.h.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-13 18:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10 18:36 [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228 Grant Peltier
2020-08-11 17:17 ` Guenter Roeck
2020-08-11 17:24 ` Grant Peltier
2020-10-13 18:18 Alex Qiu
2020-10-13 18:22 ` Alex Qiu
2020-10-13 18:37 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).