* RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
[not found] <20190330155051.9855-1-festevam@gmail.com>
@ 2019-04-01 8:38 ` Steve Twiss
2019-04-01 12:48 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Steve Twiss @ 2019-04-01 8:38 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: PENGUTRONIX, IMXNXP, smoch, ARMLINUX, andrew, LINUX-ARM-KERNEL,
LKML, Support Opensource, Adam Thomson
Hi Fabio,
On 30 March 2019 15:51 Fabio Estevam, wrote:
> Subject: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
>
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
>
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.
[...]
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
[...]
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index a0705066ccba..185fb17a3500 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -202,7 +202,7 @@
> &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
[...]
This patch looks surprisingly similar to this one ;)
https://lore.kernel.org/patchwork/patch/1052588/
Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Adam Thomson <Adam.Thomson@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Regards,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
2019-04-01 8:38 ` [RFC] ARM: dts: imx: Fix the AR803X phy-mode Steve Twiss
@ 2019-04-01 12:48 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2019-04-01 12:48 UTC (permalink / raw)
To: Steve Twiss
Cc: shawnguo, PENGUTRONIX, IMXNXP, smoch, ARMLINUX, andrew,
LINUX-ARM-KERNEL, LKML, Support Opensource, Adam Thomson
Hi Steve,
On Mon, Apr 1, 2019 at 5:38 AM Steve Twiss
<stwiss.opensource@diasemi.com> wrote:
> This patch looks surprisingly similar to this one ;)
> https://lore.kernel.org/patchwork/patch/1052588/
>
> Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
> Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
> Tested-by: Adam Thomson <Adam.Thomson@diasemi.com>
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
I put your attributions in the formal patch that I have just submitted.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-01 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190330155051.9855-1-festevam@gmail.com>
2019-04-01 8:38 ` [RFC] ARM: dts: imx: Fix the AR803X phy-mode Steve Twiss
2019-04-01 12:48 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).