* [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED [not found] <CGME20210107113207epcms5p268119bdd826f36a0e5e488a5476f82ca@epcms5p2> @ 2021-01-07 11:32 ` 李捷 2021-01-07 11:38 ` gregkh 0 siblings, 1 reply; 5+ messages in thread From: 李捷 @ 2021-01-07 11:32 UTC (permalink / raw) To: mst, gregkh, kvm, linux-kernel Cc: 김경산, 何兴, 吕高飞 From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 From: Jie Li <jie6.li@samsung.com> Date: Mon, 7 Dec 2020 08:05:07 +0800 Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED Some devices use 255 as default value of Interrupt Line register, and this maybe causes pdev->irq is set as IRQ_NOTCONNECTED in some scenarios. For example, NVMe controller connects to Intel Volume Management Device (VMD). In this situation, IRQ_NOTCONNECTED means INTx line is not connected, not fault. If bind uio_pci_generic to these devices, uio frame will return -ENOTCONN through request_irq. This patch allows binding uio_pci_generic to device with dev->irq of IRQ_NOTCONNECTED. Signed-off-by: Jie Li <jie6.li@samsung.com> Acked-by: Kyungsan Kim <ks0204.kim@samsung.com> --- drivers/uio/uio_pci_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c index b8e44d16279f..c7d681fef198 100644 --- a/drivers/uio/uio_pci_generic.c +++ b/drivers/uio/uio_pci_generic.c @@ -92,7 +92,7 @@ static int probe(struct pci_dev *pdev, gdev->info.version = DRIVER_VERSION; gdev->info.release = release; gdev->pdev = pdev; - if (pdev->irq) { + if (pdev->irq && (pdev->irq != IRQ_NOTCONNECTED)) { gdev->info.irq = pdev->irq; gdev->info.irq_flags = IRQF_SHARED; gdev->info.handler = irqhandler; -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED 2021-01-07 11:32 ` [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED 李捷 @ 2021-01-07 11:38 ` gregkh 0 siblings, 0 replies; 5+ messages in thread From: gregkh @ 2021-01-07 11:38 UTC (permalink / raw) To: 李捷 Cc: mst, kvm, linux-kernel, 김경산, 何兴, 吕高飞 On Thu, Jan 07, 2021 at 07:32:07PM +0800, 李捷 wrote: > >From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li <jie6.li@samsung.com> > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED Why is this in the body of the email? Please just use 'git send-email' or some other sane email client to send patches out so that we can apply them correctly. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20210201042758epcas5p1a6cb788bf5eb1bf85efa66662db2edf6@epcas5p1.samsung.com>]
* [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED [not found] <CGME20210201042758epcas5p1a6cb788bf5eb1bf85efa66662db2edf6@epcas5p1.samsung.com> @ 2021-02-01 4:25 ` jie6.li 0 siblings, 0 replies; 5+ messages in thread From: jie6.li @ 2021-02-01 4:25 UTC (permalink / raw) To: gregkh Cc: mst, kvm, linux-kernel, ks0204.kim, xing84.he, gaofei.lv, jie6.li, security.xa From: Jie Li <jie6.li@samsung.com> Some devices use 255 as default value of Interrupt Line register, and this maybe causes pdev->irq is set as IRQ_NOTCONNECTED in some scenarios. For example, NVMe controller connects to Intel Volume Management Device (VMD). In this situation, IRQ_NOTCONNECTED means INTx line is not connected, not fault. If bind uio_pci_generic to these devices, uio frame will return -ENOTCONN through request_irq. This patch allows binding uio_pci_generic to device with dev->irq of IRQ_NOTCONNECTED. Signed-off-by: Jie Li <jie6.li@samsung.com> Acked-by: Kyungsan Kim <ks0204.kim@samsung.com> --- drivers/uio/uio_pci_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c index b8e44d16279f..c7d681fef198 100644 --- a/drivers/uio/uio_pci_generic.c +++ b/drivers/uio/uio_pci_generic.c @@ -92,7 +92,7 @@ static int probe(struct pci_dev *pdev, gdev->info.version = DRIVER_VERSION; gdev->info.release = release; gdev->pdev = pdev; - if (pdev->irq) { + if (pdev->irq && (pdev->irq != IRQ_NOTCONNECTED)) { gdev->info.irq = pdev->irq; gdev->info.irq_flags = IRQF_SHARED; gdev->info.handler = irqhandler; -- 2.17.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <CGME20210107075037epcms5p2b53d8edb70df2ad0f75613ecbbcf9456@epcms5p2>]
[parent not found: <20210107075037epcms5p2b53d8edb70df2ad0f75613ecbbcf9456@epcms5p2>]
* Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED [not found] ` <20210107075037epcms5p2b53d8edb70df2ad0f75613ecbbcf9456@epcms5p2> @ 2021-01-07 9:27 ` gregkh 0 siblings, 0 replies; 5+ messages in thread From: gregkh @ 2021-01-07 9:27 UTC (permalink / raw) To: 李捷 Cc: mst, kvm, linux-kernel, 김경산, 何兴, 吕高飞 On Thu, Jan 07, 2021 at 03:50:37PM +0800, 李捷 wrote: > From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li <jie6.li@samsung.com> > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED > > Some devices use 255 as default value of Interrupt Line register, and this > maybe causes pdev->irq is set as IRQ_NOTCONNECTED in some scenarios. For > example, NVMe controller connects to Intel Volume Management Device (VMD). > In this situation, IRQ_NOTCONNECTED means INTx line is not connected, not > fault. If bind uio_pci_generic to these devices, uio frame will return > -ENOTCONN through request_irq. > > This patch allows binding uio_pci_generic to device with dev->irq of > IRQ_NOTCONNECTED. > > Signed-off-by: Jie Li <jie6.li@samsung.com> > Acked-by: Kyungsan Kim <ks0204.kim@samsung.com> > --- > drivers/uio/uio_pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c > index b8e44d16279f..c7d681fef198 100644 > --- a/drivers/uio/uio_pci_generic.c > +++ b/drivers/uio/uio_pci_generic.c > @@ -92,7 +92,7 @@ static int probe(struct pci_dev *pdev, > gdev->info.version = DRIVER_VERSION; > gdev->info.release = release; > gdev->pdev = pdev; > - if (pdev->irq) { > + if (pdev->irq && (pdev->irq != IRQ_NOTCONNECTED)) { > gdev->info.irq = pdev->irq; > gdev->info.irq_flags = IRQF_SHARED; > gdev->info.handler = irqhandler; > -- > 2.17.1 > > > > > [cid] > > * > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. - Your email was sent in html format, which is rejected by the kernel mailing lists and make it impossible for anyone to find in the archives. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <CGME20210106114851epcms5p81f6ba47c45047d28fda8f201b54d3ae6@epcms5p8>]
[parent not found: <1269705030.4191784.1609933731961@mail-kr5-0>]
* Re: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED [not found] ` <1269705030.4191784.1609933731961@mail-kr5-0> @ 2021-01-06 12:28 ` gregkh 0 siblings, 0 replies; 5+ messages in thread From: gregkh @ 2021-01-06 12:28 UTC (permalink / raw) To: 李捷 Cc: mst, kvm, linux-kernel, 何兴, 吕高飞 On Wed, Jan 06, 2021 at 07:48:51PM +0800, 李捷 wrote: > From 0fbcd7e386898d829d3000d094358a91e626ee4a Mon Sep 17 00:00:00 2001 > From: Jie Li <jie6.li@samsung.com> > Date: Mon, 7 Dec 2020 08:05:07 +0800 > Subject: [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to > IRQ_NOTCONNECTED > > Some devices use 255 as default value of Interrupt Line register, and this > maybe causes pdev->irq is set as IRQ_NOTCONNECTED in some scenarios. For > example, NVMe controller connects to Intel Volume Management Device (VMD). > In this situation, IRQ_NOTCONNECTED means INTx line is not connected, not > fault. If bind uio_pci_generic to these devices, uio frame will return > -ENOTCONN through request_irq. > > This patch allows binding uio_pci_generic to device with dev->irq of > IRQ_NOTCONNECTED. > > Signed-off-by: Jie Li <jie6.li@samsung.com> > Acked-by: Kyungsan Kim <ks0204.kim@samsung.com> > --- > drivers/uio/uio_pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c > index b8e44d16279f..c7d681fef198 100644 > --- a/drivers/uio/uio_pci_generic.c > +++ b/drivers/uio/uio_pci_generic.c > @@ -92,7 +92,7 @@ static int probe(struct pci_dev *pdev, > gdev->info.version = DRIVER_VERSION; > gdev->info.release = release; > gdev->pdev = pdev; > - if (pdev->irq) { > + if (pdev->irq && (pdev->irq != IRQ_NOTCONNECTED)) { > gdev->info.irq = pdev->irq; > gdev->info.irq_flags = IRQF_SHARED; > gdev->info.handler = irqhandler; > -- > 2.17.1 > > > > > > Best regards, > > Jie Li > > [cid] > > * > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/email-clients.txt in order to fix this. - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-01 4:32 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20210107113207epcms5p268119bdd826f36a0e5e488a5476f82ca@epcms5p2> 2021-01-07 11:32 ` [PATCH] uio: uio_pci_generic: don't fail probe if pdev->irq equals to IRQ_NOTCONNECTED 李捷 2021-01-07 11:38 ` gregkh [not found] <CGME20210201042758epcas5p1a6cb788bf5eb1bf85efa66662db2edf6@epcas5p1.samsung.com> 2021-02-01 4:25 ` jie6.li [not found] <CGME20210107075037epcms5p2b53d8edb70df2ad0f75613ecbbcf9456@epcms5p2> [not found] ` <20210107075037epcms5p2b53d8edb70df2ad0f75613ecbbcf9456@epcms5p2> 2021-01-07 9:27 ` gregkh [not found] <CGME20210106114851epcms5p81f6ba47c45047d28fda8f201b54d3ae6@epcms5p8> [not found] ` <1269705030.4191784.1609933731961@mail-kr5-0> 2021-01-06 12:28 ` gregkh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).