From: Eric Biggers <ebiggers@kernel.org>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
herbert@gondor.apana.org.au, davem@davemloft.net,
robh+dt@kernel.org, sboyd@kernel.org, mturquette@baylibre.com,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [Patch v2 0/6] Enable Qualcomm Crypto Engine on sdm845
Date: Thu, 19 Nov 2020 14:44:53 -0800 [thread overview]
Message-ID: <X7b1ZX5SEMq1PbVN@sol.localdomain> (raw)
In-Reply-To: <20201119155233.3974286-1-thara.gopinath@linaro.org>
On Thu, Nov 19, 2020 at 10:52:27AM -0500, Thara Gopinath wrote:
> Qualcomm crypto engine supports hardware accelerated algorithms for
> encryption and authentication. Enable support for aes,des,3des encryption
> algorithms and sha1,sha256, hmac(sha1),hmac(sha256) authentication
> algorithms on sdm845.The patch series has been tested using the kernel
> crypto testing module tcrypto.ko.
Can you please test CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y too? Implementations of
crypto algorithms shouldn't be enabled unless they are passing all tests.
Also, did you compare the performance of this hardware to ARMv8 CE? I thought
that QCE (at least on other SoCs) isn't very useful because ARMv8 CE is faster.
- Eric
next prev parent reply other threads:[~2020-11-19 22:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:52 [Patch v2 0/6] Enable Qualcomm Crypto Engine on sdm845 Thara Gopinath
2020-11-19 15:52 ` [Patch v2 1/6] dt-bindings: clock: Add entry for crypto engine RPMH clock resource Thara Gopinath
2020-11-25 2:05 ` Stephen Boyd
2020-11-19 15:52 ` [Patch v2 2/6] clk: qcom: rpmh: Add CE clock on sdm845 Thara Gopinath
2020-11-25 2:05 ` Stephen Boyd
2020-11-19 15:52 ` [Patch v2 3/6] drivers: crypto: qce: Enable support for crypto engine " Thara Gopinath
2020-11-19 15:52 ` [Patch v2 4/6] drivers: crypto: qce: Fix SHA result buffer corruption issues Thara Gopinath
2020-11-25 2:05 ` Stephen Boyd
2020-11-19 15:52 ` [Patch v2 5/6] dts: qcom: sdm845: Add dt entries to support crypto engine Thara Gopinath
2020-11-19 15:52 ` [Patch v2 6/6] dt-bindings: crypto: qcom-qce: Add v5.4 to binding Thara Gopinath
2020-12-07 22:09 ` Rob Herring
2020-12-12 15:25 ` Thara Gopinath
2020-11-19 22:44 ` Eric Biggers [this message]
2020-11-24 2:42 ` [Patch v2 0/6] Enable Qualcomm Crypto Engine on sdm845 Thara Gopinath
2020-11-27 6:25 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7b1ZX5SEMq1PbVN@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).