From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org,
Raghavendra Rao Ananta <rananta@codeaurora.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jeevan Shriram <jshriram@codeaurora.org>
Subject: Re: [PATCH 2/2] pinctrl: qcom: Add SM8350 pinctrl driver
Date: Thu, 3 Dec 2020 17:54:45 -0600 [thread overview]
Message-ID: <X8l6xU+sVJa/+5r1@builder.lan> (raw)
In-Reply-To: <20201203070900.2651127-2-vkoul@kernel.org>
On Thu 03 Dec 01:09 CST 2020, Vinod Koul wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8350.c b/drivers/pinctrl/qcom/pinctrl-sm8350.c
[..]
> +static const int sm8350_reserved_gpios[] = {
> + 52, 53, 54, 55, 56, 57, 58, 59, -1
> +};
Reserving these gpios here instead of in the DT means that there can
never be a platform configuration using these. Is there a good reason
for this? Or should we just mark them reserved in DT?
Regards,
Bjorn
> +
> +static const struct msm_pinctrl_soc_data sm8350_pinctrl = {
> + .pins = sm8350_pins,
> + .npins = ARRAY_SIZE(sm8350_pins),
> + .functions = sm8350_functions,
> + .nfunctions = ARRAY_SIZE(sm8350_functions),
> + .groups = sm8350_groups,
> + .ngroups = ARRAY_SIZE(sm8350_groups),
> + .reserved_gpios = sm8350_reserved_gpios,
> + .ngpios = 204,
> +};
> +
> +static int sm8350_pinctrl_probe(struct platform_device *pdev)
> +{
> + return msm_pinctrl_probe(pdev, &sm8350_pinctrl);
> +}
> +
> +static const struct of_device_id sm8350_pinctrl_of_match[] = {
> + { .compatible = "qcom,sm8350-pinctrl", },
> + { },
> +};
> +
> +static struct platform_driver sm8350_pinctrl_driver = {
> + .driver = {
> + .name = "sm8350-pinctrl",
> + .of_match_table = sm8350_pinctrl_of_match,
> + },
> + .probe = sm8350_pinctrl_probe,
> + .remove = msm_pinctrl_remove,
> +};
> +
> +static int __init sm8350_pinctrl_init(void)
> +{
> + return platform_driver_register(&sm8350_pinctrl_driver);
> +}
> +arch_initcall(sm8350_pinctrl_init);
> +
> +static void __exit sm8350_pinctrl_exit(void)
> +{
> + platform_driver_unregister(&sm8350_pinctrl_driver);
> +}
> +module_exit(sm8350_pinctrl_exit);
> +
> +MODULE_DESCRIPTION("QTI sm8350 pinctrl driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DEVICE_TABLE(of, sm8350_pinctrl_of_match);
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-12-03 23:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 7:08 [PATCH 1/2] dt-bindings: pinctrl: qcom: Add SM8350 pinctrl bindings Vinod Koul
2020-12-03 7:09 ` [PATCH 2/2] pinctrl: qcom: Add SM8350 pinctrl driver Vinod Koul
2020-12-03 23:54 ` Bjorn Andersson [this message]
2020-12-04 5:03 ` Vinod Koul
2020-12-04 9:24 ` Linus Walleij
2020-12-03 23:49 ` [PATCH 1/2] dt-bindings: pinctrl: qcom: Add SM8350 pinctrl bindings Bjorn Andersson
2020-12-04 5:02 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8l6xU+sVJa/+5r1@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jshriram@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rananta@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).