linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 0/2] tty: n_gsm: revert tx_mutex usage
       [not found] <DB9PR10MB58817A08B92BA7F943CDD9B2E02E9@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
@ 2022-10-24 14:37 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2022-10-24 14:37 UTC (permalink / raw)
  To: Starke, Daniel
  Cc: pchelkin, jirislaby, Alexey Khoroshilov, linux-kernel,
	lvc-project, Pavel Machek

On Mon, Oct 24, 2022 at 01:30:23PM +0000, Starke, Daniel wrote:
> I have checked both patches. Those appear to be correct.
> Furthermore, I also recommend to bring in these reverts.

Can you send a "Reviewed-by:" tag for me to apply?  Hint, don't send it
in an HTML email so that lore.kernel.org will properly pick it up.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 0/2] tty: n_gsm: revert tx_mutex usage
  2022-10-08 11:02 ` [PATCH 0/2] tty: n_gsm: revert tx_mutex usage Fedor Pchelkin
@ 2022-10-25  7:31   ` Pavel Machek
  0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2022-10-25  7:31 UTC (permalink / raw)
  To: Fedor Pchelkin
  Cc: Daniel Starke, Jiri Slaby, lvc-project, Alexey Khoroshilov,
	Greg Kroah-Hartman, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hi!

> As far as switching to tx_mutex turns out to have its own problems,
> we suggest to revert it and to find another solution for the original
> issue described in 902e02ea9385 ("tty: n_gsm: avoid call of sleeping
> functions from atomic context").

We have lived with locking problems for a long time, and we really
don't want data corruption.

Reviewed-by: Pavel Machek <pavel@denx.de>

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 0/2] tty: n_gsm: revert tx_mutex usage
  2022-10-08 10:54 [PATCH v2] tty: n_gsm: avoid call of sleeping functions from atomic context Fedor Pchelkin
@ 2022-10-08 11:02 ` Fedor Pchelkin
  2022-10-25  7:31   ` Pavel Machek
  0 siblings, 1 reply; 3+ messages in thread
From: Fedor Pchelkin @ 2022-10-08 11:02 UTC (permalink / raw)
  To: Daniel Starke
  Cc: Fedor Pchelkin, Jiri Slaby, lvc-project, Alexey Khoroshilov,
	Greg Kroah-Hartman, linux-kernel, Pavel Machek

As far as switching to tx_mutex turns out to have its own problems,
we suggest to revert it and to find another solution for the original
issue described in 902e02ea9385 ("tty: n_gsm: avoid call of sleeping
functions from atomic context").

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-25  7:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <DB9PR10MB58817A08B92BA7F943CDD9B2E02E9@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
2022-10-24 14:37 ` [PATCH 0/2] tty: n_gsm: revert tx_mutex usage Greg KH
2022-10-08 10:54 [PATCH v2] tty: n_gsm: avoid call of sleeping functions from atomic context Fedor Pchelkin
2022-10-08 11:02 ` [PATCH 0/2] tty: n_gsm: revert tx_mutex usage Fedor Pchelkin
2022-10-25  7:31   ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).