From: Tejun Heo <tj@kernel.org>
To: Josh Don <joshdon@google.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Daniel Bristot de Oliveira" <bristot@redhat.com>,
"Valentin Schneider" <vschneid@redhat.com>,
linux-kernel@vger.kernel.org,
"Joel Fernandes" <joel@joelfernandes.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Christian Brauner" <brauner@kernel.org>,
"Zefan Li" <lizefan.x@bytedance.com>
Subject: Re: [PATCH v2] sched: async unthrottling for cfs bandwidth
Date: Tue, 1 Nov 2022 12:38:23 -1000 [thread overview]
Message-ID: <Y2Gf3zxJqxRnkVyf@slm.duckdns.org> (raw)
In-Reply-To: <CABk29Nvj8nRyD0HGo+gZ4CEr0kOJSsUbJnSNFs62D66EDTMGog@mail.gmail.com>
Hello,
(cc'ing Michal, Christian and Li for context)
On Tue, Nov 01, 2022 at 02:59:56PM -0700, Josh Don wrote:
> > If most of the problems were with cpu bw control, fixing that should do for
> > the time being. Otherwise, we'll have to think about finishing kernfs
> > locking granularity improvements and doing something similar to cgroup
> > locking too.
>
> Oh we've easily hit stalls measured in multiple seconds. We
> extensively use cpu.idle to group batch tasks. One of the memory
> bandwidth mitigations implemented in userspace is cpu jailing, which
> can end up pushing lots and lots of these batch threads onto a small
> number of cpus. 5ms min gran * 200 threads is already one second :)
Ah, I see.
> We're in the process of transitioning to using bw instead for this
> instead in order to maintain parallelism. Fixing bw is definitely
> going to be useful, but I'm afraid we'll still likely have some issues
> from low throughput for non-bw reasons (some of which we can't
> directly control, since arbitrary jobs can spin up and configure their
> hierarchy/threads in antagonistic ways, in effect pushing out the
> latency of some of their threads).
Yeah, thanks for the explanation. Making the lock more granular is tedious
but definitely doable. I don't think I can work on it in the near future but
will keep it on mind. If anyone's interested in attacking it, please be my
guest.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-11-01 22:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 22:44 [PATCH v2] sched: async unthrottling for cfs bandwidth Josh Don
2022-10-31 13:04 ` Peter Zijlstra
2022-10-31 21:22 ` Josh Don
2022-10-31 21:50 ` Tejun Heo
2022-10-31 23:15 ` Josh Don
2022-10-31 23:53 ` Tejun Heo
2022-11-01 1:01 ` Josh Don
2022-11-01 1:45 ` Tejun Heo
2022-11-01 19:11 ` Josh Don
2022-11-01 19:15 ` Tejun Heo
2022-11-01 20:56 ` Josh Don
2022-11-01 21:49 ` Tejun Heo
2022-11-01 21:59 ` Josh Don
2022-11-01 22:38 ` Tejun Heo [this message]
2022-11-02 17:10 ` Michal Koutný
2022-11-02 17:18 ` Tejun Heo
2022-10-31 21:56 ` Benjamin Segall
2022-11-02 8:40 ` Peter Zijlstra
2022-11-11 0:14 ` Josh Don
2022-11-02 16:59 ` Michal Koutný
2022-11-03 0:10 ` Josh Don
2022-11-03 10:11 ` Michal Koutný
2022-11-16 3:01 ` Josh Don
2022-11-16 9:57 ` Michal Koutný
2022-11-16 21:45 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Gf3zxJqxRnkVyf@slm.duckdns.org \
--to=tj@kernel.org \
--cc=brauner@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).