From: Manuel Traut <manuel.traut@mt.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 4/5] dt-bindings: input: pwm-beeper: add volume
Date: Thu, 26 Jan 2023 17:08:57 +0100 [thread overview]
Message-ID: <Y9KlmY49Zq17HIOI@mt.com> (raw)
In-Reply-To: <b5aea934-4514-6b30-be95-f427d01f54bb@linaro.org>
> >>> + default-volume-level:
> >>
> >> I propose to use just the value, not the index, so the name should
> >> finish with '-bp' and the $ref can be dropped.
> >
> > I am not so happy with this suggestion. What shall be displayed in
> > sysfs as volume if a user specifies a value that is not defined in
> > the array.. So I tend to keep this as is.
>
> sysfs is not related to bindings. To rephrase your question: what shall
> be shown in anywhere if the index is not correct? The same problem, the
> same solution.
got it, thanks for the hint. I will implement it in v9.
Regards
Manuel
next prev parent reply other threads:[~2023-01-26 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 9:18 [PATCH v8 0/5] input: pwm-beeper: add feature to set volume level Manuel Traut
2023-01-26 9:18 ` [PATCH v8 1/5] dt-bindings: input: pwm-beeper: Convert txt bindings to yaml Manuel Traut
2023-01-26 12:32 ` Krzysztof Kozlowski
2023-01-26 13:21 ` Rob Herring
2023-01-26 9:18 ` [PATCH v8 2/5] input: pwm-beeper: add feature to set volume via sysfs Manuel Traut
2023-01-26 9:18 ` [PATCH v8 3/5] input: pwm-beeper: set volume levels by devicetree Manuel Traut
2023-01-26 9:18 ` [PATCH v8 4/5] dt-bindings: input: pwm-beeper: add volume Manuel Traut
2023-01-26 12:36 ` Krzysztof Kozlowski
2023-01-26 15:11 ` Manuel Traut
2023-01-26 15:20 ` Krzysztof Kozlowski
2023-01-26 16:08 ` Manuel Traut [this message]
2023-01-26 9:18 ` [PATCH v8 5/5] input: pwm-beeper: handle module unloading properly Manuel Traut
2023-01-30 9:07 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KlmY49Zq17HIOI@mt.com \
--to=manuel.traut@mt.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).