From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manuel Traut <manuel.traut@mt.com>
Cc: linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 4/5] dt-bindings: input: pwm-beeper: add volume
Date: Thu, 26 Jan 2023 16:20:36 +0100 [thread overview]
Message-ID: <b5aea934-4514-6b30-be95-f427d01f54bb@linaro.org> (raw)
In-Reply-To: <Y9KYNSWwlJXPcw0L@mt.com>
On 26/01/2023 16:11, Manuel Traut wrote:
>> This is the second patch. Bindings must be introduced before you start
>> using them.
>
> OK, will be done in v9.
>
>>> ---
>>> .../devicetree/bindings/input/pwm-beeper.yaml | 20 +++++++++++++++++++
>>> 1 file changed, 20 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
>>> index 351df83d5cbe..f1f9283ca855 100644
>>> --- a/Documentation/devicetree/bindings/input/pwm-beeper.yaml
>>> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
>>> @@ -26,6 +26,24 @@ properties:
>>> beeper-hz:
>>> description: bell frequency in Hz
>>>
>>> + volume-levels:
>>
>> use -bp suffix:
>> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml#L44
>>
>> which will mean the unit is 1/100 of %, not 1/10. Then you can also drop
>> the $ref.
>
> OK, this is also fine for me. Chaned the description and implementation
> for v9.
>
>>> + description: >
>>> + Array of PWM duty cycle values that correspond to
>>> + linear volume levels. These need to be in the range of
>>> + 0 to 500, while 0 means 0% duty cycle (mute) and 500
>>> + means 50% duty cycle (max volume).
>>> + Please note that the actual volume of most beepers is
>>> + highly non-linear, which means that low volume levels
>>> + are probably somewhere in the range of 1 to 30 (0.1-3%
>>> + duty cycle).
>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>> +
>>> + default-volume-level:
>>
>> I propose to use just the value, not the index, so the name should
>> finish with '-bp' and the $ref can be dropped.
>
> I am not so happy with this suggestion. What shall be displayed in
> sysfs as volume if a user specifies a value that is not defined in
> the array.. So I tend to keep this as is.
sysfs is not related to bindings. To rephrase your question: what shall
be shown in anywhere if the index is not correct? The same problem, the
same solution.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-26 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 9:18 [PATCH v8 0/5] input: pwm-beeper: add feature to set volume level Manuel Traut
2023-01-26 9:18 ` [PATCH v8 1/5] dt-bindings: input: pwm-beeper: Convert txt bindings to yaml Manuel Traut
2023-01-26 12:32 ` Krzysztof Kozlowski
2023-01-26 13:21 ` Rob Herring
2023-01-26 9:18 ` [PATCH v8 2/5] input: pwm-beeper: add feature to set volume via sysfs Manuel Traut
2023-01-26 9:18 ` [PATCH v8 3/5] input: pwm-beeper: set volume levels by devicetree Manuel Traut
2023-01-26 9:18 ` [PATCH v8 4/5] dt-bindings: input: pwm-beeper: add volume Manuel Traut
2023-01-26 12:36 ` Krzysztof Kozlowski
2023-01-26 15:11 ` Manuel Traut
2023-01-26 15:20 ` Krzysztof Kozlowski [this message]
2023-01-26 16:08 ` Manuel Traut
2023-01-26 9:18 ` [PATCH v8 5/5] input: pwm-beeper: handle module unloading properly Manuel Traut
2023-01-30 9:07 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5aea934-4514-6b30-be95-f427d01f54bb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.traut@mt.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).