From: Greg KH <gregkh@linuxfoundation.org>
To: Mukul Mehar <mukulmehar02@gmail.com>
Cc: devel@driverdev.osuosl.org, christian.gromm@microchip.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue.
Date: Tue, 9 Feb 2021 18:27:03 +0100 [thread overview]
Message-ID: <YCLF57aXZY8dooUH@kroah.com> (raw)
In-Reply-To: <20210209130618.18508-1-mukulmehar02@gmail.com>
On Tue, Feb 09, 2021 at 06:36:19PM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
> ---
> drivers/staging/most/sound/sound.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
> index 3a1a59058042..4dd1bf95d1ce 100644
> --- a/drivers/staging/most/sound/sound.c
> +++ b/drivers/staging/most/sound/sound.c
> @@ -228,12 +228,12 @@ static int playback_thread(void *data)
> struct mbo *mbo = NULL;
> bool period_elapsed = false;
>
> - wait_event_interruptible(
> - channel->playback_waitq,
> - kthread_should_stop() ||
> - (channel->is_stream_running &&
> - (mbo = most_get_mbo(channel->iface, channel->id,
> - &comp))));
> + wait_event_interruptible(channel->playback_waitq,
> + kthread_should_stop() ||
> + (channel->is_stream_running &&
> + (mbo = most_get_mbo(channel->iface,
> + channel->id,
> + &comp))));
This line is horrid, you can indent it further (line up the
most_get_mbo() parameters at the least.
Also you lost the extra indentation of the "(mbo " portion, can you make
sure that is there too?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-09 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 13:06 [PATCH] Drivers: staging: most: sound: Fixed styling issue Mukul Mehar
2021-02-09 17:27 ` Greg KH [this message]
2021-02-10 1:00 ` [PATCH v2] " Mukul Mehar
2021-02-10 7:47 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 12:50 [PATCH] " Mukul Mehar
2021-02-09 13:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCLF57aXZY8dooUH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukulmehar02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).