* [PATCH] Drivers: staging: most: sound: Fixed styling issue.
@ 2021-02-09 13:06 Mukul Mehar
2021-02-09 17:27 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Mukul Mehar @ 2021-02-09 13:06 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, christian.gromm, Mukul Mehar
This patch fixes a warning, of the line ending with a '(',
generated by checkpatch.pl.
Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
---
drivers/staging/most/sound/sound.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
index 3a1a59058042..4dd1bf95d1ce 100644
--- a/drivers/staging/most/sound/sound.c
+++ b/drivers/staging/most/sound/sound.c
@@ -228,12 +228,12 @@ static int playback_thread(void *data)
struct mbo *mbo = NULL;
bool period_elapsed = false;
- wait_event_interruptible(
- channel->playback_waitq,
- kthread_should_stop() ||
- (channel->is_stream_running &&
- (mbo = most_get_mbo(channel->iface, channel->id,
- &comp))));
+ wait_event_interruptible(channel->playback_waitq,
+ kthread_should_stop() ||
+ (channel->is_stream_running &&
+ (mbo = most_get_mbo(channel->iface,
+ channel->id,
+ &comp))));
if (!mbo)
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue.
2021-02-09 13:06 [PATCH] Drivers: staging: most: sound: Fixed styling issue Mukul Mehar
@ 2021-02-09 17:27 ` Greg KH
2021-02-10 1:00 ` [PATCH v2] " Mukul Mehar
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2021-02-09 17:27 UTC (permalink / raw)
To: Mukul Mehar; +Cc: devel, christian.gromm, linux-kernel
On Tue, Feb 09, 2021 at 06:36:19PM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
> ---
> drivers/staging/most/sound/sound.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
> index 3a1a59058042..4dd1bf95d1ce 100644
> --- a/drivers/staging/most/sound/sound.c
> +++ b/drivers/staging/most/sound/sound.c
> @@ -228,12 +228,12 @@ static int playback_thread(void *data)
> struct mbo *mbo = NULL;
> bool period_elapsed = false;
>
> - wait_event_interruptible(
> - channel->playback_waitq,
> - kthread_should_stop() ||
> - (channel->is_stream_running &&
> - (mbo = most_get_mbo(channel->iface, channel->id,
> - &comp))));
> + wait_event_interruptible(channel->playback_waitq,
> + kthread_should_stop() ||
> + (channel->is_stream_running &&
> + (mbo = most_get_mbo(channel->iface,
> + channel->id,
> + &comp))));
This line is horrid, you can indent it further (line up the
most_get_mbo() parameters at the least.
Also you lost the extra indentation of the "(mbo " portion, can you make
sure that is there too?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] Drivers: staging: most: sound: Fixed styling issue.
2021-02-09 17:27 ` Greg KH
@ 2021-02-10 1:00 ` Mukul Mehar
2021-02-10 7:47 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Mukul Mehar @ 2021-02-10 1:00 UTC (permalink / raw)
To: gregkh; +Cc: christian.gromm, devel, linux-kernel, Mukul Mehar
This patch fixes a warning, of the line ending with a '(',
generated by checkpatch.pl.
Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
---
Changes since v1:
- Fixed indentation.
---
drivers/staging/most/sound/sound.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
index 4dd1bf95d1ce..4d497ce6d7b8 100644
--- a/drivers/staging/most/sound/sound.c
+++ b/drivers/staging/most/sound/sound.c
@@ -231,9 +231,9 @@ static int playback_thread(void *data)
wait_event_interruptible(channel->playback_waitq,
kthread_should_stop() ||
(channel->is_stream_running &&
- (mbo = most_get_mbo(channel->iface,
- channel->id,
- &comp))));
+ (mbo = most_get_mbo(channel->iface,
+ channel->id,
+ &comp))));
if (!mbo)
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] Drivers: staging: most: sound: Fixed styling issue.
2021-02-10 1:00 ` [PATCH v2] " Mukul Mehar
@ 2021-02-10 7:47 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-02-10 7:47 UTC (permalink / raw)
To: Mukul Mehar; +Cc: devel, christian.gromm, linux-kernel
On Wed, Feb 10, 2021 at 06:30:45AM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
> ---
> Changes since v1:
> - Fixed indentation.
> ---
> drivers/staging/most/sound/sound.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
> index 4dd1bf95d1ce..4d497ce6d7b8 100644
> --- a/drivers/staging/most/sound/sound.c
> +++ b/drivers/staging/most/sound/sound.c
> @@ -231,9 +231,9 @@ static int playback_thread(void *data)
> wait_event_interruptible(channel->playback_waitq,
> kthread_should_stop() ||
> (channel->is_stream_running &&
> - (mbo = most_get_mbo(channel->iface,
> - channel->id,
> - &comp))));
> + (mbo = most_get_mbo(channel->iface,
> + channel->id,
> + &comp))));
> if (!mbo)
> continue;
>
This patch does not apply to my tree at all :(
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Drivers: staging: most: sound: Fixed styling issue.
@ 2021-02-09 12:50 Mukul Mehar
2021-02-09 13:00 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Mukul Mehar @ 2021-02-09 12:50 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Mukul Mehar
This patch fixes a warning, of the line ending with a '(',
generated by checkpatch.pl.
Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
---
drivers/staging/most/sound/sound.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c
index 3a1a59058042..4dd1bf95d1ce 100644
--- a/drivers/staging/most/sound/sound.c
+++ b/drivers/staging/most/sound/sound.c
@@ -228,12 +228,12 @@ static int playback_thread(void *data)
struct mbo *mbo = NULL;
bool period_elapsed = false;
- wait_event_interruptible(
- channel->playback_waitq,
- kthread_should_stop() ||
- (channel->is_stream_running &&
- (mbo = most_get_mbo(channel->iface, channel->id,
- &comp))));
+ wait_event_interruptible(channel->playback_waitq,
+ kthread_should_stop() ||
+ (channel->is_stream_running &&
+ (mbo = most_get_mbo(channel->iface,
+ channel->id,
+ &comp))));
if (!mbo)
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue.
2021-02-09 12:50 [PATCH] " Mukul Mehar
@ 2021-02-09 13:00 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-02-09 13:00 UTC (permalink / raw)
To: Mukul Mehar; +Cc: devel, linux-kernel
On Tue, Feb 09, 2021 at 06:20:37PM +0530, Mukul Mehar wrote:
> This patch fixes a warning, of the line ending with a '(',
> generated by checkpatch.pl.
>
> Signed-off-by: Mukul Mehar <mukulmehar02@gmail.com>
> ---
> drivers/staging/most/sound/sound.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Any reason you didn't also cc: the other developer that
get_maintainer.pl tells you to for this file?
Please fix that up and resend, especially as that developer also sent a
different patch for this driver right before you, so someone's patch is
going to get confused...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-10 7:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 13:06 [PATCH] Drivers: staging: most: sound: Fixed styling issue Mukul Mehar
2021-02-09 17:27 ` Greg KH
2021-02-10 1:00 ` [PATCH v2] " Mukul Mehar
2021-02-10 7:47 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 12:50 [PATCH] " Mukul Mehar
2021-02-09 13:00 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).