* [PATCH v3 0/3] Modify subject description and rectify spelling mistake.
@ 2021-04-11 9:55 Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Mitali Borkar @ 2021-04-11 9:55 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
This patch fixes style issues
Changes from v2:-
[PATCH v2 1/3]:- Modified subject description.
[PATCH V2 2/3]:- No changes.
[PATCH v2 3/3]:- Rectified spelling mistake in subject description.
Changes from v1:-
[PATCH 1/3]:- Removed unnecessary parentheses around boolean expression.
Changes has been made in v2.
[PATCH 2/3]:- No changes.
[PATCH 3/3]:- No changes.
Mitali Borkar (3):
staging: rtl8192e: remove parentheses around boolean expression
staging: rtl8192e: remove unnecessary ftrace-like logging
staging: rtl8192e: remove unnecessary parentheses
drivers/staging/rtl8192e/rtl819x_HTProc.c | 18 ++-
1 files changed, 7 insertions(+), 11 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression
2021-04-11 9:55 [PATCH v3 0/3] Modify subject description and rectify spelling mistake Mitali Borkar
@ 2021-04-11 9:55 ` Mitali Borkar
2021-04-11 10:07 ` [Outreachy kernel] " Julia Lawall
2021-04-11 9:55 ` [PATCH v3 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging Mitali Borkar
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Mitali Borkar @ 2021-04-11 9:55 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher
precedance than '||'
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v2:- Modified subject description.
Changes from v1:- Removed unnecessary parentheses around boolean expression.
Changes has been made in v2.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index b1fa8e9a4f28..431202927036 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
struct rt_hi_throughput *pHT = ieee->pHTInfo;
struct ht_capab_ele *pCapELE = NULL;
- if ((!posHTCap) || (!pHT)) {
+ if (!posHTCap || !pHT) {
netdev_warn(ieee->dev,
"%s(): posHTCap and pHTInfo are null\n", __func__);
return;
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging
2021-04-11 9:55 [PATCH v3 0/3] Modify subject description and rectify spelling mistake Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
@ 2021-04-11 9:55 ` Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 3/3] staging: rtl8192e: remove unnecessary parentheses Mitali Borkar
2021-04-12 9:34 ` [PATCH v3 0/3] Modify subject description and rectify spelling mistake Greg KH
3 siblings, 0 replies; 6+ messages in thread
From: Mitali Borkar @ 2021-04-11 9:55 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
Removed unncessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v2:- No changes.
Changes from v1:- NO changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 0b1e92f17805..89d0e9ec188d 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -630,7 +630,6 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
{
struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
- netdev_vdbg(ieee->dev, "%s()\n", __func__);
pHTInfo->bCurrentHTSupport = false;
pHTInfo->bCurBW40MHz = false;
@@ -698,7 +697,6 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
u8 bIOTAction = 0;
- netdev_vdbg(ieee->dev, "%s()\n", __func__);
/* unmark bEnableHT flag here is the same reason why unmarked in
* function rtllib_softmac_new_net. WB 2008.09.10
*/
@@ -832,8 +830,6 @@ static void HTSetConnectBwModeCallback(struct rtllib_device *ieee)
{
struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
- netdev_vdbg(ieee->dev, "%s()\n", __func__);
-
if (pHTInfo->bCurBW40MHz) {
if (pHTInfo->CurSTAExtChnlOffset == HT_EXTCHNL_OFFSET_UPPER)
ieee->set_chan(ieee->dev,
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3 3/3] staging: rtl8192e: remove unnecessary parentheses
2021-04-11 9:55 [PATCH v3 0/3] Modify subject description and rectify spelling mistake Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging Mitali Borkar
@ 2021-04-11 9:55 ` Mitali Borkar
2021-04-12 9:34 ` [PATCH v3 0/3] Modify subject description and rectify spelling mistake Greg KH
3 siblings, 0 replies; 6+ messages in thread
From: Mitali Borkar @ 2021-04-11 9:55 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
Removed unnecessary parentheses because they must be used only when it
is necessary or they improve readability.
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v2:- Rectified spelling mistake in subject description.
Changes from v1:- No changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 89d0e9ec188d..b1fa8e9a4f28 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -287,7 +287,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
- pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
+ pCapELE = (struct ht_capab_ele *)&posHTCap[4];
*len = 30 + 2;
} else {
pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -646,13 +646,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
- memset((void *)(&(pHTInfo->SelfHTCap)), 0,
+ memset((void *)(&pHTInfo->SelfHTCap), 0,
sizeof(pHTInfo->SelfHTCap));
- memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
+ memset((void *)(&pHTInfo->SelfHTInfo), 0,
sizeof(pHTInfo->SelfHTInfo));
- memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
+ memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
sizeof(pHTInfo->PeerHTCapBuf));
- memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
+ memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
sizeof(pHTInfo->PeerHTInfoBuf));
pHTInfo->bSwBwInProgress = false;
@@ -668,7 +668,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->IOTRaFunc = 0;
{
- u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
+ u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
RegHTSuppRateSets[0] = 0xFF;
RegHTSuppRateSets[1] = 0xFF;
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression
2021-04-11 9:55 ` [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
@ 2021-04-11 10:07 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2021-04-11 10:07 UTC (permalink / raw)
To: Mitali Borkar
Cc: gregkh, linux-staging, linux-kernel, outreachy-kernel, mitali_s
On Sun, 11 Apr 2021, Mitali Borkar wrote:
> Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher
> precedance than '||'
The log message is too wide. It should be at most around 70 characters
wide, because git will indent it a little.
julia
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
>
> Changes from v2:- Modified subject description.
> Changes from v1:- Removed unnecessary parentheses around boolean expression.
> Changes has been made in v2.
>
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index b1fa8e9a4f28..431202927036 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
> struct rt_hi_throughput *pHT = ieee->pHTInfo;
> struct ht_capab_ele *pCapELE = NULL;
>
> - if ((!posHTCap) || (!pHT)) {
> + if (!posHTCap || !pHT) {
> netdev_warn(ieee->dev,
> "%s(): posHTCap and pHTInfo are null\n", __func__);
> return;
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/30a330377667aa5043a60ed3cdf1bbb37099631c.1618133351.git.mitaliborkar810%40gmail.com.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 0/3] Modify subject description and rectify spelling mistake.
2021-04-11 9:55 [PATCH v3 0/3] Modify subject description and rectify spelling mistake Mitali Borkar
` (2 preceding siblings ...)
2021-04-11 9:55 ` [PATCH v3 3/3] staging: rtl8192e: remove unnecessary parentheses Mitali Borkar
@ 2021-04-12 9:34 ` Greg KH
3 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-04-12 9:34 UTC (permalink / raw)
To: Mitali Borkar; +Cc: linux-staging, linux-kernel, outreachy-kernel, mitali_s
On Sun, Apr 11, 2021 at 03:25:05PM +0530, Mitali Borkar wrote:
> This patch fixes style issues
"this" is not a patch :(
And the subject line here also needs fixed up.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-12 9:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-11 9:55 [PATCH v3 0/3] Modify subject description and rectify spelling mistake Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 1/3] staging: rtl8192e: remove parentheses around boolean expression Mitali Borkar
2021-04-11 10:07 ` [Outreachy kernel] " Julia Lawall
2021-04-11 9:55 ` [PATCH v3 2/3] staging: rtl8192e: remove unnecessary ftrace-like logging Mitali Borkar
2021-04-11 9:55 ` [PATCH v3 3/3] staging: rtl8192e: remove unnecessary parentheses Mitali Borkar
2021-04-12 9:34 ` [PATCH v3 0/3] Modify subject description and rectify spelling mistake Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).