From: LABBE Corentin <clabbe@baylibre.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: pavel@ucw.cz, robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: remove ide-disk trigger
Date: Mon, 5 Jul 2021 22:34:23 +0200 [thread overview]
Message-ID: <YONsz9dG08YZOLg6@Red> (raw)
In-Reply-To: <1153e311-e0cf-d869-e3f8-b679eb2e60de@metux.net>
Le Tue, Jun 29, 2021 at 12:47:27PM +0200, Enrico Weigelt, metux IT consult a écrit :
> On 28.06.21 21:17, Corentin Labbe wrote:
>
> > diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c
> > index 0741910785bb..38a5c21c0466 100644
> > --- a/drivers/leds/trigger/ledtrig-disk.c
> > +++ b/drivers/leds/trigger/ledtrig-disk.c
> > @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void)
> > led_trigger_register_simple("disk-activity", &ledtrig_disk);
> > led_trigger_register_simple("disk-read", &ledtrig_disk_read);
> > led_trigger_register_simple("disk-write", &ledtrig_disk_write);
> > - led_trigger_register_simple("ide-disk", &ledtrig_ide);
> >
> > return 0;
> > }
>
> Shouldn't this line also be removed ?
>
> DEFINE_LED_TRIGGER(ledtrig_ide);
>
Yes, I will send a v2.
Thanks
prev parent reply other threads:[~2021-07-05 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 19:17 [PATCH] leds: remove ide-disk trigger Corentin Labbe
2021-06-29 10:47 ` Enrico Weigelt, metux IT consult
2021-07-05 20:34 ` LABBE Corentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YONsz9dG08YZOLg6@Red \
--to=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkml@metux.net \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).