* [PATCH v1 1/1] parport: Use string_upper() instead of open coded variant
@ 2021-05-18 13:34 Andy Shevchenko
2021-07-29 8:43 ` Sudip Mukherjee
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-05-18 13:34 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel; +Cc: Sudip Mukherjee, Greg Kroah-Hartman
Use string_upper() from string helper module instead of open coded variant.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/parport/probe.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c
index 7e6d713fa5ac..5d1b9aacb130 100644
--- a/drivers/parport/probe.c
+++ b/drivers/parport/probe.c
@@ -8,8 +8,8 @@
#include <linux/module.h>
#include <linux/parport.h>
-#include <linux/ctype.h>
#include <linux/string.h>
+#include <linux/string_helpers.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
@@ -74,11 +74,7 @@ static void parse_data(struct parport *port, int device, char *str)
u = sep + strlen (sep) - 1;
while (u >= p && *u == ' ')
*u-- = '\0';
- u = p;
- while (*u) {
- *u = toupper(*u);
- u++;
- }
+ string_upper(p, p);
if (!strcmp(p, "MFG") || !strcmp(p, "MANUFACTURER")) {
kfree(info->mfr);
info->mfr = kstrdup(sep, GFP_KERNEL);
@@ -90,8 +86,7 @@ static void parse_data(struct parport *port, int device, char *str)
kfree(info->class_name);
info->class_name = kstrdup(sep, GFP_KERNEL);
- for (u = sep; *u; u++)
- *u = toupper(*u);
+ string_upper(sep, sep);
for (i = 0; classes[i].token; i++) {
if (!strcmp(classes[i].token, sep)) {
info->class = i;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] parport: Use string_upper() instead of open coded variant
2021-05-18 13:34 [PATCH v1 1/1] parport: Use string_upper() instead of open coded variant Andy Shevchenko
@ 2021-07-29 8:43 ` Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2021-07-29 8:43 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, Greg Kroah-Hartman
Thanks Andy and sorry for the extreme delay in replying.
On Tue, May 18, 2021 at 04:34:58PM +0300, Andy Shevchenko wrote:
> Use string_upper() from string helper module instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks Greg for taking this.
--
Regards
Sudip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-29 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 13:34 [PATCH v1 1/1] parport: Use string_upper() instead of open coded variant Andy Shevchenko
2021-07-29 8:43 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).