* [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly
@ 2021-10-16 5:25 Dmitry Torokhov
2021-10-16 16:03 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2021-10-16 5:25 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, Sebastian Reichel
We are using devm_input_allocate_device() that already sets parent
of the input device, there is no need to do that again.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/cpcap-pwrbutton.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
index 372cb44d0635..879790bbf9fe 100644
--- a/drivers/input/misc/cpcap-pwrbutton.c
+++ b/drivers/input/misc/cpcap-pwrbutton.c
@@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
button->idev->name = "cpcap-pwrbutton";
button->idev->phys = "cpcap-pwrbutton/input0";
- button->idev->dev.parent = button->dev;
input_set_capability(button->idev, EV_KEY, KEY_POWER);
err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
--
2.33.0.1079.g6e70778dc9-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly
2021-10-16 5:25 [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly Dmitry Torokhov
@ 2021-10-16 16:03 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2021-10-16 16:03 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Hi,
On Fri, Oct 15, 2021 at 10:25:58PM -0700, Dmitry Torokhov wrote:
> We are using devm_input_allocate_device() that already sets parent
> of the input device, there is no need to do that again.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> drivers/input/misc/cpcap-pwrbutton.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
> index 372cb44d0635..879790bbf9fe 100644
> --- a/drivers/input/misc/cpcap-pwrbutton.c
> +++ b/drivers/input/misc/cpcap-pwrbutton.c
> @@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
>
> button->idev->name = "cpcap-pwrbutton";
> button->idev->phys = "cpcap-pwrbutton/input0";
> - button->idev->dev.parent = button->dev;
> input_set_capability(button->idev, EV_KEY, KEY_POWER);
>
> err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> --
> 2.33.0.1079.g6e70778dc9-goog
>
>
> --
> Dmitry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-16 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-16 5:25 [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly Dmitry Torokhov
2021-10-16 16:03 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).